Reviewers: ,

Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=5563

Following my proposal (copied here from the issue tracker):
The fix should IMO be (and I believe it was in my initial patch that
introduced the handler/mapper dichotomy) to ignore classes in the
generator instead of bailing. If the class is abstract, deferred binding
will later fail because it cannot instantiate the class (if the class is
abstract, you should have configured a replace-with or generate-with
rule to bypass the PlaceHistoryMapperGenerator anyway, so it's your
fault); same thing if the class doesn't have a no-args constructor; and
in the last case, the class should be instantiated using its no-args
constructor.


Please review this at http://gwt-code-reviews.appspot.com/1293801/show

Affected files:
  user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
  user/src/com/google/gwt/place/rebind/PlaceHistoryMapperGenerator.java
  user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java
user/test/com/google/gwt/place/rebind/PlaceHistoryGeneratorContextTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to