[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-02 Thread rjrjr
r9933 http://gwt-code-reviews.appspot.com/1399803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-01 Thread Ray Ryan
ping On Thu, Mar 31, 2011 at 1:41 PM, rj...@google.com wrote: Reviewers: fabbott, Description: Adds a no-op emulation of TestSuite, to prevent error spam (or outright failure under -strict mode) in web mode tests that accidentally pick the things up in their class path. Please review

[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-01 Thread fabbott
LGTM with nits about which comments are helpful. http://gwt-code-reviews.appspot.com/1399803/diff/1/user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java File user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java (right):

[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-01 Thread rjrjr
http://gwt-code-reviews.appspot.com/1399803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-01 Thread rjrjr
http://gwt-code-reviews.appspot.com/1399803/diff/1/user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java File user/super/com/google/gwt/junit/translatable/junit/framework/TestSuite.java (right):

[gwt-contrib] Re: Adds a no-op emulation of TestSuite, to prevent error spam (or outright (issue1399803)

2011-04-01 Thread fabbott
LGTM, now without nits. http://gwt-code-reviews.appspot.com/1399803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors