LGTM. On Sun, Aug 22, 2010 at 2:07 AM, <cromwell...@google.com> wrote:
> Reviewers: amitmanjhi, rjrjr, > > Description: > Fix for date serialization problem in JsonRequestProcessor. Datanucleus > returns custom subtypes of java.util.Date from the datastore, which > causes Dates to be serialized as english strings. > > > Please review this at http://gwt-code-reviews.appspot.com/790801/show > > Affected files: > M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > > > Index: > user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > =================================================================== > --- user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > (revision 8616) > +++ user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > (working copy) > @@ -320,7 +320,7 @@ > if (Boolean.class == type) { > return value; > } > - if (Date.class == type) { > + if (Date.class.isAssignableFrom(type)) { > return String.valueOf(((Date) value).getTime()); > } > if (Enum.class.isAssignableFrom(type)) { > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
