[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-31 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/14003/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-31 Thread rdayal
https://gwt-code-reviews.appspot.com/1646803/diff/21002/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-31 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/21002/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-31 Thread rdayal
On 2012/05/31 15:02:27, tbroyer wrote: https://gwt-code-reviews.appspot.com/1646803/diff/21002/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-30 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-30 Thread rdayal
LGTM. https://gwt-code-reviews.appspot.com/1646803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-30 Thread rdayal
https://gwt-code-reviews.appspot.com/1646803/diff/14003/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-29 Thread rdayal
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-29 Thread rdayal
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-27 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-05-22 Thread rdayal
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-04-27 Thread rdayal
Just add the comment about the subtlety with the IdentityHashMap, and I think we're good to go. https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-04-27 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-04-10 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-04-09 Thread rdayal
Generally, looks good, but wouldn't mind hearing your comments to my questions before the submit. https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java