[gwt-contrib] Re: Fix the escaping done by UrlBuilder. (issue754803)

2010-09-02 Thread t . broyer
I don't quite understand what this change in RemoteServiceServlet has to do with UrlBuilder... http://gwt-code-reviews.appspot.com/754803/diff/21001/22002 File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java (right):

[gwt-contrib] Re: Fix the escaping done by UrlBuilder. (issue754803)

2010-09-02 Thread t . broyer
In brief: URIs (RFC 3986) is a mess, and back to URL.encode for the path in UrlBuilder? (with a second pass though) http://gwt-code-reviews.appspot.com/754803/diff/21001/22002 File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java (right):

[gwt-contrib] Re: Fix the escaping done by UrlBuilder. (issue754803)

2010-08-26 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/754803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix the escaping done by UrlBuilder. (issue754803)

2010-08-24 Thread t . broyer
http://gwt-code-reviews.appspot.com/754803/diff/1/2 File user/src/com/google/gwt/http/client/UrlBuilder.java (right): http://gwt-code-reviews.appspot.com/754803/diff/1/2#newcode69 user/src/com/google/gwt/http/client/UrlBuilder.java:69: for (String segment : path.split(/)) { It'd probably be