[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr
Some nits. Needs Rafa's LGTM http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right):

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right):

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right):

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes
http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java (right):

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr
Looks good as soon as I see FieldWriterOfExsitingTypeTest.java. It's okay to hold off on the integration test, but there shouldn't be anything in the way of writing a unit test a la FieldWriterOfGeneratedCssResourceTest. Sorry, I could have sworn I asked for that in the first review. Must have

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr
LGTM Hermes will follow up with tests posthaste http://gwt-code-reviews.appspot.com/1428807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread Rafael Castro
LGTM On Mon, May 2, 2011 at 7:15 PM, rj...@google.com wrote: LGTM Hermes will follow up with tests posthaste http://gwt-code-reviews.appspot.com/1428807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors