[gwt-contrib] Re: Issue 6193: Fix memory-leak in WeakMapping when the value holds a reference on the key (issue1401802)

2011-05-03 Thread t . broyer
http://gwt-code-reviews.appspot.com/1401802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6193: Fix memory-leak in WeakMapping when the value holds a reference on the key (issue1401802)

2011-04-09 Thread t . broyer
I introduced an IsShim interface that all AutoBean shims (whether generated or VM proxies) implement to get the associated AutoBean back, instead of using WeakMapping. WeakMapping is now only used when the key is a wrapped object. This still causes a leak if the developer fails to unwrap() the

[gwt-contrib] Re: Issue 6193: Fix memory-leak in WeakMapping when the value holds a reference on the key (issue1401802)

2011-04-04 Thread BobV
This change would break the contract of the WeakMapping, since the value object isn't guaranteed to outlive the key object. A better way to fix AutoBeans is to only use WeakMapping for non-generated bean implementations, and have the shim implement a private interface that's queried by

[gwt-contrib] Re: Issue 6193: Fix memory-leak in WeakMapping when the value holds a reference on the key (issue1401802)

2011-04-04 Thread Thomas Broyer
On Monday, April 4, 2011 8:18:49 PM UTC+2, Bob Vawter wrote: This change would break the contract of the WeakMapping, since the value object isn't guaranteed to outlive the key object. Oh, right, of course! A better way to fix AutoBeans is to only use WeakMapping for non-generated bean