http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I handled those cases and added unit tests.
http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
Nice! I would probably just add a test for empty strings.
http://gwt-code-reviews.appspot.com/1123801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1123801/diff/1/2
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/1123801/diff/1/2#newcode879
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:879:
return
updated patch
http://gwt-code-reviews.appspot.com/1123801/diff/1/2
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/1123801/diff/1/2#newcode879
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:879:
return
Really sorry to be so picky, but if you call getClassSubstring(String
fullMethodName) with something like myClass, it'll throw an
IndexOutOfBoundsException (start longer than end). It'll also fail for
the empty string (end: 0, start: 1).
BTW, I can't see the side-by-side diff, not sure if
