[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

2008-10-15 Thread Scott Blum
What if we move FastStringMap into http://code.google.com/p/google-web-toolkit/source/browse/#svn/trunk/user/src/com/google/gwt/user/client/impl ? On Wed, Oct 15, 2008 at 11:00 AM, Emily Crutcher [EMAIL PROTECTED] wrote: I do not think we want to make FastStringMap public where it is, though

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

2008-10-15 Thread Emily Crutcher
If we rename it FastStringMapImpl at the same time that would work. The rename is useful because people using class-lookup to find gwt utility classes cannot fail to realize it is an impl class. Of course, what I really want is a public JsStringMap api, and so consider the fact that we are

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

2008-10-15 Thread Bruce Johnson
Let's not do this in 1.5.3. On Wed, Oct 15, 2008 at 12:11 PM, Emily Crutcher [EMAIL PROTECTED] wrote: If we rename it FastStringMapImpl at the same time that would work. The rename is useful because people using class-lookup to find gwt utility classes cannot fail to realize it is an impl

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

2008-10-15 Thread Amit Manjhi
Should I incorporate Emily's and Scott's changes and commit this to 1.6? Regards, Amit On Wed, Oct 15, 2008 at 12:24 PM, Bruce Johnson [EMAIL PROTECTED] wrote: Let's not do this in 1.5.3. On Wed, Oct 15, 2008 at 12:11 PM, Emily Crutcher [EMAIL PROTECTED] wrote: If we rename it