[gwt-contrib] Re: Rolling back r8329 because it hands in IE8. (issue630802)

2010-06-30 Thread rice
LGTM I'll rewrite the tests to be a lot faster (although possibly not as thorough) http://gwt-code-reviews.appspot.com/630802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rolling back r8329 because it hands in IE8. (issue630802)

2010-06-29 Thread דניאל רייס
We probably don't need these tests to run in full for every test cycle. They would be useful, though, to run as smoke tests when new browser versions are released. If there is a way to keep the test code around but only invoke it infrequently I would be in favor of that. Dan On Tue, Jun 29, 2

[gwt-contrib] Re: Rolling back r8329 because it hands in IE8. (issue630802)

2010-06-29 Thread jlabanca
That might help. I'm not sure if its a slow script warning, a selenium operation timeout, or an infrastructure timeout. Breaking the method into RepeatingCommands would surely help with the first two. http://gwt-code-reviews.appspot.com/630802/show -- http://groups.google.com/group/Google-Web-

[gwt-contrib] Re: Rolling back r8329 because it hands in IE8. (issue630802)

2010-06-29 Thread t . broyer
On 2010/06/29 21:56:58, jlabanca wrote: I think all of the doTestParseUnescaped loops in JSONTest are causing the tests to timeout. We'll have to break these tests down so they don't timeout. How about taking advantage of being in a GWTTestCase and use a Scheduler.RepeatingCommand? http://g

[gwt-contrib] Re: Rolling back r8329 because it hands in IE8. (issue630802)

2010-06-29 Thread jlabanca
I think all of the doTestParseUnescaped loops in JSONTest are causing the tests to timeout. We'll have to break these tests down so they don't timeout. http://gwt-code-reviews.appspot.com/630802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors