[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread zundel
http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread zundel
Before this patch, compiling this app would return many lines of output of the form: [java] Checking rule generate-with class='com.google.gwt.validation.rebind.GwtSpecificValidatorGenerator'/ [java][WARN] Unknown type

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread zundel
Submitted as r10020 http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread Eric Ayers
good question. I know that the -sources.jar file is needed to just make the errors go away for legacy projects that don't reference any classes that use javax.validation, but I haven't seen the messages for a sample that actually needs validation. On Tue, Apr 19, 2011 at 11:13 AM,

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread Rodrigo Chandia
On Tue, Apr 19, 2011 at 11:19 AM, Eric Ayers zun...@google.com wrote: good question. I know that the -sources.jar file is needed to just make the errors go away for legacy projects that don't reference any classes that use javax.validation, but I haven't seen the messages for a sample that

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-19 Thread Eric Ayers
Well you are right. This patch will suppress errors if you are missing both .jar files, but if you add in validation-api-version-sources.jar, you get a different slew of non-fatal errors. followup patch at: http://gwt-code-reviews.appspot.com/1422804 On Tue, Apr 19, 2011 at 11:24 AM, Rodrigo

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-18 Thread zundel
http://gwt-code-reviews.appspot.com/1424804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-18 Thread zundel
I am proposing this patch to suppress the errors that occur when the java validation .jar file is missing. The requirement for this .jar file is new in GWT 2.3 and legacy projects will spew forth lots of unhelpful messages. One thing that is kind of icky is that I used a static boolean to

[gwt-contrib] Re: Suppresses multiple warnings related to validation .jar file and (issue1424804)

2011-04-18 Thread jbrosenberg
LGTM + nits http://gwt-code-reviews.appspot.com/1424804/diff/3001/dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java File dev/core/src/com/google/gwt/dev/cfg/ConditionWhenTypeAssignableTo.java (right):