LGTM
Oops. Thanks Nick. I'll need to remember to put this on the 2.4 branch.
On Sep 13, 2011 7:27 PM, <ncha...@google.com> wrote:
> Reviewers: rjrjr,
>
> Description:
> Update the checkstule path for validation sample
> Fix the @NotSupported count
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1547803/
>
> Affected files:
> M samples/common.ant.xml
> M user/build.xml
>
>
> Index: samples/common.ant.xml
> ===================================================================
> --- samples/common.ant.xml (revision 8405)
> +++ samples/common.ant.xml (working copy)
> @@ -189,8 +189,8 @@
> <target name="checkstyle" description="Static analysis of source">
> <gwt.checkstyle outputdirectory="${sample.build}">
> <fileset dir="src" >
> - <exclude name="org/**/super/org/**/*.java"/>
> - <exclude
> name="com/google/gwt/sample/validation*/**/ValidationMessages.java" />
> + <exclude name="main/java/org/**/super/org/**/*.java"/>
> + <exclude
>
name="main/java/com/google/gwt/sample/validation*/**/ValidationMessages.java"
> />
> </fileset>
> </gwt.checkstyle>
> </target>
> Index: user/build.xml
> ===================================================================
> --- user/build.xml (revision 8405)
> +++ user/build.xml (working copy)
> @@ -803,13 +803,14 @@
> <countfilter match="@Failing" property="jsr303.marked.Failing"
> init="0"/>
> <countfilter match="@NonTckTest"
> property="jsr303.marked.NonTckTest" init="0"/>
> <countfilter match="@NotSupported"
> property="jsr303.marked.NotSupported" init="0"/>
> - <countfilter match="@TestNotCompatible"
> property="jsr303.marked.NotSupported" init="0"/>
> + <countfilter match="@TestNotCompatible"
> property="jsr303.marked.TestNotCompatible" init="0"/>
> </filterchain>
> </scan>
>
> <!-- force to zero if not set above -->
> <property name="jsr303.marked.Failing" value="0"/>
> <property name="jsr303.marked.NonTckTest" value="0"/>
> + <property name="jsr303.marked.NotSupported" value="0"/>
> <property name="jsr303.marked.TestNotCompatible" value="0"/>
>
> <echo message="Marked Failing = ${jsr303.marked.Failing}" />
>
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
