Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Matt Mastracci
I'm getting closer to figuring out exactly what happened here. The extra classes that were getting included were all under root-package/ client. I've restructured our half-dozen GWT modules so that they all inherit source paths and imports from a basic set of root modules. For modules

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread John Tamplin
On Mon, Nov 23, 2009 at 1:33 PM, Matt Mastracci matt...@mastracci.comwrote: I'll work around the implicit source path issue for now by using fake source paths in modules that don't have any additional source imports. If possible, it would be useful if there were a log warning explaining that

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Bruce Johnson
Maybe not a warning, but maybe an INFO-level log entry, or perhaps a TRACE-level one. I think the default introduction of source path=client is net confusing. Forcing people to specify it would have helped (forced?) people to understand what is going on. On Mon, Nov 23, 2009 at 1:40 PM, John

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Ray Ryan
FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right thing. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Isaac Truett
+1 deprecate and warn. On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan rj...@google.com wrote: FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Bruce Johnson
let's remember to talk about this more for the release after 2.0 On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett itru...@gmail.com wrote: +1 deprecate and warn. On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan rj...@google.com wrote: FWIW, this confusion is exactly why webAppCreator no longer

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-23 Thread Matt Mastracci
Filed a bug on this: http://code.google.com/p/google-web-toolkit/issues/detail?id=4268 On 23-Nov-09, at 12:40 PM, Bruce Johnson wrote: let's remember to talk about this more for the release after 2.0 On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett itru...@gmail.com wrote: +1 deprecate and

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-20 Thread Scott Blum
Hi Matt, I need more information, because on the face of it, I don't see how we can be pulling in all types in all cases. We have specific type oracle tests that check how many types total end up in type oracle. If it was a fundamental problem, these tests should be blowing up. Example:

Re: [gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-20 Thread Matt Mastracci
I can't repro this on a smaller scale. I created small project with two modules and TypeOracle was populated correctly (GWT 2.0-RC1 and trunk), even when compiling both modules together or running DevMode with both modules specified. I'll keep trying to reproduce this, sorry for the false

[gwt-contrib] TypeOracle allTypes including types not in a source path

2009-11-19 Thread Matt Mastracci
Hey all, Sorry to keep spamming GWT 2.0 issues. I've run into a difference in how TypeOracle works that seems to have changed in GWT 2.0. In previous versions, calling context.getTypeOracle().getTypes() from a generator would limit itself to types available on the source paths. I have