[gwt-contrib] Re: Fixes a strange compiler bug where types generated into new packages may not be found. (issue831802)
lgtm http://gwt-code-reviews.appspot.com/831802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes a strange compiler bug where types generated into new packages may not be found. (issue831802)
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004 File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right): http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257 dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java:257: } Are we going to need to loop here like we do with optimizers? Couldn't additional types found with rebinds lead to further discovery of new types with JSNI? Or maybe just run the doFindAdditionalTypesUsingJsni one more time (in case the generator creates more JSNI) http://gwt-code-reviews.appspot.com/831802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes a strange compiler bug where types generated into new packages may not be found. (issue831802)
http://gwt-code-reviews.appspot.com/831802/diff/5001/3004 File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right): http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257 dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java:257: } The short answer is no: the looping behavior is intrinsic in how we interact with JDT. Once we add the new types (as source), then once they get compiled by JDT we will visit the compiled units and look for more rebinds and jsni, iteratively. I did the reordering here because only Rebinds can actually generate any new types that weren't in CompilationState before. JSNI can only reference existing type. http://gwt-code-reviews.appspot.com/831802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes a strange compiler bug where types generated into new packages may not be found. (issue831802)
LGTM2 On Thu, Sep 2, 2010 at 11:30 AM, sco...@google.com wrote: http://gwt-code-reviews.appspot.com/831802/diff/5001/3004 File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right): http://gwt-code-reviews.appspot.com/831802/diff/5001/3004#newcode257 dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java:257: } The short answer is no: the looping behavior is intrinsic in how we interact with JDT. Once we add the new types (as source), then once they get compiled by JDT we will visit the compiled units and look for more rebinds and jsni, iteratively. I did the reordering here because only Rebinds can actually generate any new types that weren't in CompilationState before. JSNI can only reference existing type. http://gwt-code-reviews.appspot.com/831802/show -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
