Re: [gphoto-devel] Canon EOS M2 support: patch

2018-03-08 Thread Marcus Meissner
On Tue, Feb 27, 2018 at 12:51:34AM +0300, Alexey Kryukov wrote: > Hi Marcus, > > please find attached my patch for EOS M2 support. The changes (except > obvious ones) are as follows: > > -- is_canon_eos_m() now returns an EOS M version (not just 1 or 0). > That's because M2 has turned out to

Re: [gphoto-devel] Canon EOS M2 support: patch

2018-03-05 Thread Alexey Kryukov
On Sun, 4 Mar 2018 22:30:42 +0100 Marcus Meissner wrote: > I split parts out and merged the 2nd and 3rd prt, changed the 3rd a > bit. Thank you for committing this. I performed some more tests and I see the situation is unfortunately a bit more complex than I supposed previously. The camera

Re: [gphoto-devel] Canon EOS M2 support

2018-02-23 Thread Alexey Kryukov
Might it be reasonable to check at the beginning of ptp_unpack_EOS_FocusInfoEx() if data is zero-filled (so nothing useful), and, if so, just exit the function posting an appropriate message to the log, but without triggering an error? Thus it would be possible to avoid camera-specific

Re: [gphoto-devel] Canon EOS M2 support

2018-02-20 Thread Alexey Kryukov
On Mon, 19 Feb 2018 22:18:09 +0100 Marcus Meissner wrote: > But this is the way I would go here. Can you just try? In fact I've tried already, and that's why I am writing here :) It works now as expected, I only would like to optimize it somehow. > FWIW, do you get an PTP event of

Re: [gphoto-devel] Canon EOS M2 support

2018-02-19 Thread Marcus Meissner
On Tue, Feb 20, 2018 at 12:07:56AM +0300, Alexey Kryukov wrote: > Hi, > > I am trying to get EOS M2 supported in libgphoto2. Basically the camera > looks perfectly controllable over USB (better than its descendants), > but some tweaks are needed, and I'd like to discuss them here before >