Hello Stefan
Here are a few comments:
- virtnet_enqueue_iob: The address of the local variable 'header' is
passed to vring_add_buf(). As you said on IRC, the hypervisor could
access the data after 'header' went out of scope and 'header' could
already be overwritten by something else.
- We have
On Fri, Jul 9, 2010 at 12:48 PM, Thomas Miletich
thomas.milet...@gmail.com wrote:
Hello Stefan
Here are a few comments:
- virtnet_enqueue_iob: The address of the local variable 'header' is
passed to vring_add_buf(). As you said on IRC, the hypervisor could
access the data after 'header' went
On Sat, Jul 3, 2010 at 10:07 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Sat, Jul 3, 2010 at 9:52 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
This patch adds a native gPXE virtio-net driver and removes the legacy
Etherboot virtio-net driver. The main reasons for doing this are:
1.
This patch adds a native gPXE virtio-net driver and removes the legacy
Etherboot virtio-net driver. The main reasons for doing this are:
1. Multiple virtio-net NICs are now supported by gPXE. The legacy
driver kept global state and caused issues in virtual machines with
more than one
On Sat, Jul 3, 2010 at 9:52 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
This patch adds a native gPXE virtio-net driver and removes the legacy
Etherboot virtio-net driver. The main reasons for doing this are:
1. Multiple virtio-net NICs are now supported by gPXE. The legacy
driver kept