Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

On lines 228 and 1069 you should not mix p2d and this. I would go with both p2d.pointTypes and p2d.numTypes in both cases... ...jim On 3/6/15 2:03 PM, Laurent Bourgès wrote: Phil, Here is a new webrev: http://cr.openjdk.java.net/~lbourges/webrev_Path2D_1/ See my comm

Re: [OpenJDK Rasterizer] Path2D optimizations

First, the test cases that I asked for were to verify that a path that was cloned was still operational. I see no tests that verify that the returned objects will still function, only tests that examine internal data structures for a metric that may not be appropriate in the future. On 3/6/15

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

We should probably focus on a single Mailing List for code reviews. This particular review is not necessarily specific to the rasterizer, so it should probably have only been sent to the 2d-dev list (Path2D is owned by 2D). Also, please start a new thread for code reviews (and new topics). Th

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

On 03/06/2015 03:21 PM, Laurent Bourgès wrote: Phil, > Two more things regarding the test > 1. It was pointed out that you are using GPL+CP .. tests just use GPL You mean I must fix the test file header ? Yes, please. > 2. There's no @bug tag the test. In fact there's no bug ID here at al

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Phil, > Two more things regarding the test > 1. It was pointed out that you are using GPL+CP .. tests just use GPL You mean I must fix the test file header ? > 2. There's no @bug tag the test. In fact there's no bug ID here at all :-) > > A bug ID is needed in order to push. > You have a JBS acc

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Hi, Two more things regarding the test 1. It was pointed out that you are using GPL+CP .. tests just use GPL 2. There's no @bug tag the test. In fact there's no bug ID here at all :-) A bug ID is needed in order to push. You have a JBS account now so could have created it yourself .. but by the

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Phil, Here is a new webrev: http://cr.openjdk.java.net/~lbourges/webrev_Path2D_1/ See my comments below: > you placed the test in the java.awt.geom package. >> >> 25 package java.awt.geom; >> >> and are accessing internals of that package. >> >> In jigsaw/modular mode that won't even compile.

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Hi, On 03/06/2015 12:37 PM, Laurent Bourgès wrote: Phil, Thanks for your feedback ! 2015-03-06 20:06 GMT+01:00 Phil Race >: Hi, you placed the test in the java.awt.geom package. 25 package java.awt.geom; and are accessing internals of that

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Phil, Thanks for your feedback ! 2015-03-06 20:06 GMT+01:00 Phil Race : > Hi, > > you placed the test in the java.awt.geom package. > > 25 package java.awt.geom; > > and are accessing internals of that package. > > In jigsaw/modular mode that won't even compile. > Ok it is annoying: as all Pa

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Hi, you placed the test in the java.awt.geom package. 25 package java.awt.geom; and are accessing internals of that package. In jigsaw/modular mode that won't even compile. So the test should go in the anonymous package and avoid accessing internals. It should be possible to use just publi

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Jim, Here is my first "official" webrev (vs graphics-rasterizer forest) concerning Path2D copy constructors: http://cr.openjdk.java.net/~lbourges/webrev_Path2D_0/ this is a simple Path2D patch to trim arrays (numTypes & float/double Coords) in copy constructors (Path2D.Float and Path2D.Double var