Re: [OpenJDK Rasterizer] Marlin renderer contribution for review

Hi Laurent, I'll defer to Phil on any instructions for pushing to the repo in case I make a mistake and give bad advice. On 3/30/15 2:24 PM, Laurent Bourgès wrote: Here is my list of ideas to be discussed: First: - improve coordinate rounding ie ceil(x - 0.5) or better ? Maybe ceil/floor(flo

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Path2D optimizations

Hi Laurent, On 3/30/15 2:31 PM, Laurent Bourgès wrote: Big one: I figured out a bug in Path2d happening with 0 capacity: rectCrossing and ptCrossing fail. I'm guessing that is why there are the new shortcut returns on the intersects/contains methods in Path2D? I see it

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Path2D optimizations

Jim, Test program, line 490 - MOVETO has 2 coordinates associated with it. > Well spotted: I did it too quickly, sorry. Test program, line 492 - perhaps we should throw an exception on default > since it indicates a problem with the iterator > Ok. > Other than that, it looks good... > Thanks

Re: [OpenJDK Rasterizer] Marlin renderer contribution for review

Jim, 2015-03-30 20:34 GMT+02:00 Jim Graham : > Looks like it is good to go into the graphics-rasterizer repo, then. > > Thanks for the hard work on the cleanup Laurent! > Thanks for your reviews too, but I am really happy that marlin goes in (back). What kind of performance / regression tests do

Re: [OpenJDK Rasterizer] [OpenJDK 2D-Dev] Path2D optimizations

Hi Laurent, Test program, line 490 - MOVETO has 2 coordinates associated with it. Test program, line 492 - perhaps we should throw an exception on default since it indicates a problem with the iterator Other than that, it looks good... On 3/29/15 7:40 AM, Laurent Bourgès wrote: - What am I

Re: [OpenJDK Rasterizer] Marlin renderer contribution for review

Looks like it is good to go into the graphics-rasterizer repo, then. Thanks for the hard work on the cleanup Laurent! We'll need to get people testing this with their programs and start looking into any additional cleanup. Did you have a list of things you were planning on working on?

Re: [OpenJDK Rasterizer] Marlin renderer contribution for review

On 29.03.2015 16:45, Laurent Bourgès wrote: Hi Jim, Here is the new webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin.6/ Thanks, Laurent, my concerns on FloatMath have been resolved in this version. cheers, dalibor topic -- Dalibor Topic | Principal Produ