Re: [OpenJDK Rasterizer] RFR: Marlin renderer #2

2015-06-10 Thread Jim Graham
Hi Laurent, On 6/10/15 2:00 PM, Laurent Bourgès wrote: Because a nanosecond on an operation that takes several milliseconds is worth making the code obscure? ;) Also, factoring out the subtraction has a side affect of requiring you to insert a new "+1" that didn't use to be the

Re: [OpenJDK Rasterizer] RFR: Marlin renderer #2

2015-06-10 Thread Laurent Bourgès
Jim, Here is the new webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-s2.2/ CollinearSimplifier: > >> >> Looks good. I'm still curious why you didn't use an enum - is the >> code more efficient just dealing with basic numbers rather than enum >> instances? >> >> >> I did no