Re: [OpenJDK Rasterizer] Fix Overflow in Marlin ArrayCache

2015-12-01 Thread Jim Graham
Hi Laurent, I submitted the following bug: https://bugs.openjdk.java.net/browse/JDK-815 The change looks fine. Are the long modifiers (12L, 1L, etc) really needed on the shift parameters given that the first operand (needSize) is already a long? 202 size = ((needSize >> 1

Re: [OpenJDK Rasterizer] Fix Overflow in Marlin ArrayCache

2015-11-27 Thread Laurent Bourgès
Hi, Here is a new webrev that fix the Renderer usage of getNewLargeSize() as the overflow check fails due to integer maths: http://cr.openjdk.java.net/~lbourges/marlin/marlin-s6.1/ Patched line: final long edgeNewSize = ArrayCache.getNewLargeSize(_edges.length,- edgePtr +

[OpenJDK Rasterizer] Fix Overflow in Marlin ArrayCache

2015-11-27 Thread Laurent Bourgès
Hi Jim, Here is a simple fix on potential overflow in ArrayCache.getNewLargeSize() discussed during Marlin integration: http://cr.openjdk.java.net/~lbourges/marlin/marlin-s6.0/ I added the ArrayCacheSizeTest class which now passes in jtreg. Could you create a bug, I am not sure what I should fil