Jim,
thanks for your review.
Please read my comments below:
2015-03-18 2:13 GMT+01:00 Jim Graham :
> Hi Laurent,
>
> I'm now looking at your webrev. There are a number of things that I think
> we should look at once it goes in, and I'll mention those in subsequent
> emails, but I want to just
Hi Laurent,
On 3/18/15 9:17 AM, Laurent Bourgès wrote:
I advocate I used the "fluent"-like approach to modify less lines and
avoid too much changes.
In Pisces, several instances were created like "r = new
Renderer(params)" then I replaced by "r = rdrCtx.renderer.init(params)":
-r =
Hi Laurent,
On 3/18/15 9:17 AM, Laurent Bourgès wrote:
TransformingPathConsumer2D - the if/else style being replaced here
was actually intentional. The lack of a trailing "return" statement
ensures that all cases were specifically handled above in either an
if, or its associated
Hi Laurent,
Keep in mind that the "things to consider later" parts of the review
shouldn't hold up the process, but if you see something you want to fix
now, feel free to address them sooner or later.
On 3/18/15 9:17 AM, Laurent Bourgès wrote:
Here are some "things to consider l
On 3/18/15 2:50 PM, Jim Graham wrote:
On 3/18/15 9:17 AM, Laurent Bourgès wrote:
Here are some "things to consider later" -
I just realized the main case where we want to deal with cleaning
out dirty arrays and it would be the crossings accumulation arrays.
It
Jim,
2015-03-18 23:03 GMT+01:00 Jim Graham :
>
>
> On 3/18/15 2:50 PM, Jim Graham wrote:
>
>> On 3/18/15 9:17 AM, Laurent Bourgčs wrote:
>>
>>> Here are some "things to consider later" -
>>>
>>> I just realized the main case where we want to deal with cleaning
>>> out
Jim,
Here is the new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin.3/
Changes:
- discussed changes in Dasher, Stroker, TransformingPathConsumer2D
- indentation, line breaks (continuation lines)
- revert many float suffix in math operations (useless ? does the compiler
make conversion
