Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Wed, Oct 14, 2015 at 5:16 AM, Vaclav Petras wrote: > la.h removed from gmath.h in r66485. I tested that with and without LAPACK > configured. Work as expected. Perhaps the #error can be removed from the > modules if it makes sense to have it in la.h (as I did that). I

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Mon, Oct 12, 2015 at 6:53 AM, Glynn Clements wrote: > > > Having la.h as a separate header would conveniently hide the compilation > > issue on that Debian server. > > > > So, should I remove la.h from gmath.h? > > I think so. la.h removed from gmath.h in r66485. I

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

Vaclav Petras wrote: > I like the idea of a separate header but I would leave the implementation > in lib/gmath. Or is this going too much against how other libraries are > done? I'm also not sure how the prefixes should work, but these seems OK > since there are functions with same prefix (G_)

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Wed, Oct 7, 2015 at 7:00 PM, Glynn Clements wrote: > > Vaclav Petras wrote: > > > I was not able to determine from svn why gmath.h contains la.h. > > AFAICT, it's because the functions are in lib/gmath. Of course, that > then brings up the question why they're there,

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

Vaclav Petras wrote: > I was not able to determine from svn why gmath.h contains la.h. AFAICT, it's because the functions are in lib/gmath. Of course, that then brings up the question why they're there, rather than in a separate library ... Incidentally, the whole of lib/gmath/la.c is

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Tue, Oct 6, 2015 at 10:03 AM, Moritz Lennert wrote: > On 05/10/15 16:49, Vaclav Petras wrote: ... >> Sorry for being -pedantic but I don't think we should leave the code >> messy. > > +1 Then it needs to be removed everywhere here: cd grass-addons find . -type f

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On 05/10/15 16:49, Vaclav Petras wrote: On Mon, Oct 5, 2015 at 3:44 AM, Martin Landa > wrote: > > Hi, > > 2015-10-05 9:41 GMT+02:00 Martin Landa >: > > compilation was simply

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Tue, Oct 6, 2015 at 4:22 AM, Markus Neteler wrote: > > On Tue, Oct 6, 2015 at 10:03 AM, Moritz Lennert > wrote: > > On 05/10/15 16:49, Vaclav Petras wrote: > ... > >> Sorry for being -pedantic but I don't think we should leave the code > >>

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Tue, Oct 6, 2015 at 12:26 PM, Glynn Clements wrote: > > Markus Neteler wrote: > > > >> Sorry for being -pedantic but I don't think we should leave the code > > >> messy. > > > > > > +1 > > > > Then it needs to be removed everywhere here: > > > > cd grass-addons > >

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

Markus Neteler wrote: > >> Sorry for being -pedantic but I don't think we should leave the code > >> messy. > > > > +1 > > Then it needs to be removed everywhere here: > > cd grass-addons > find . -type f | grep -v pristin | xargs grep 'la.h>' > ./grass6/imagery/i.spec.unmix/global.h:#include

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

Hi, 2015-10-05 3:04 GMT+02:00 Vaclav Petras : > this shouldn't be necessary and same for r66404, gmath.h contains already > grass/la.h. Any possible compilation issue is an issue with configuration > (local or in GRASS) or with the gmath.h file. What was the reason for the >

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

Hi, 2015-10-05 9:41 GMT+02:00 Martin Landa : > compilation was simply failing on build server (Debian stable): > >> In file included from main.c:47:0: >> global.h:28:29: error: unknown type name ‘vec_struct’ >> global.h:28:43: error: unknown type name ‘vec_struct’ >>

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Mon, Oct 5, 2015 at 3:44 AM, Martin Landa wrote: > > Hi, > > 2015-10-05 9:41 GMT+02:00 Martin Landa : > > compilation was simply failing on build server (Debian stable): It is working on Ubuntu and probably Fedora as well. Perhaps it is a local

Re: [GRASS-dev] [GRASS-SVN] r66413 - grass-addons/grass7/vector/v.kriging

On Sun, Oct 4, 2015 at 9:08 AM, wrote: > > Author: neteler > Date: 2015-10-04 06:08:45 -0700 (Sun, 04 Oct 2015) > New Revision: 66413 > > Modified: >grass-addons/grass7/vector/v.kriging/local_proto.h > Log: > v.kriging: add missing la.h header > > @@ -13,6 +13,7 @@ >