Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-26 Thread Markus Metz
On Thu, Jan 26, 2017 at 3:18 PM, Markus Metz wrote: > > > > On Mon, Jan 23, 2017 at 11:19 AM, Rashad Kanavath < mohammedrasha...@gmail.com> wrote: > > > > > > > > On Mon, Jan 23, 2017 at 9:22 AM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > >> > >> Hi

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-26 Thread Markus Metz
On Mon, Jan 23, 2017 at 11:19 AM, Rashad Kanavath < mohammedrasha...@gmail.com> wrote: > > > > On Mon, Jan 23, 2017 at 9:22 AM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: >> >> Hi Rashad, >> >> On 22/01/17 11:00, Rashad Kanavath wrote: >>> >>> I fixed all the points from last mail. >>

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-23 Thread Rashad Kanavath
On Mon, Jan 23, 2017 at 9:22 AM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > Hi Rashad, > > On 22/01/17 11:00, Rashad Kanavath wrote: > >> I fixed all the points from last mail. >> > > Wonderful ! > > It seems that you missed one point (see in the ticket #3142/#3247). > > Thank you so

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-23 Thread Moritz Lennert
Hi Rashad, On 22/01/17 11:00, Rashad Kanavath wrote: I fixed all the points from last mail. Wonderful ! It seems that you missed one point (see in the ticket #3142/#3247). Thank you so much for this great job ! Moritz On Fri, Jan 6, 2017 at 9:28 AM, Markus Metz

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-22 Thread Rashad Kanavath
I fixed all the points from last mail. On Fri, Jan 6, 2017 at 9:28 AM, Markus Metz wrote: > > > On Tue, Dec 27, 2016 at 9:05 PM, Rashad Kanavath < > mohammedrasha...@gmail.com> wrote: > >> >> >> I had pushed a updated version of code: >> >> Done: >> 1. input is a

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2017-01-06 Thread Markus Metz
On Tue, Dec 27, 2016 at 9:05 PM, Rashad Kanavath wrote: > > > I had pushed a updated version of code: > > Done: > 1. input is a imagery group from i.group (handles all raster in the group) > 2. removed rgb2lab conversion > 3. implementation of id output map > 4.

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-27 Thread Rashad Kanavath
I had pushed a updated version of code: Done: 1. input is a imagery group from i.group (handles all raster in the group) 2. removed rgb2lab conversion 3. implementation of id output map 4. replaced fmin with MIN and MAX macro 5. compactness is a new option to module? (default is 20 from paper)

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-22 Thread Markus Neteler
On Thu, Dec 22, 2016 at 12:01 AM, Markus Metz wrote: ... > Adding > > #undef MIN > #define MIN(a,b) ((a) < (b) ? (a) : (b)) > > as in other GRASS modules is a nice solution to keep things simple and > portable. ... how about a adding this and similar definitions to

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-21 Thread Markus Metz
On Wed, Dec 21, 2016 at 7:53 AM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > > > > Le 20 décembre 2016 23:39:09 GMT+01:00, Markus Metz < markus.metz.gisw...@gmail.com> a écrit : > >On Tue, Dec 20, 2016 at 11:09 PM, Martin Landa > >wrote: > >> > >> Hi, > >> > >>

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Moritz Lennert
Le 20 décembre 2016 23:39:09 GMT+01:00, Markus Metz a écrit : >On Tue, Dec 20, 2016 at 11:09 PM, Martin Landa >wrote: >> >> Hi, >> >> 2016-12-20 22:17 GMT+01:00 Markus Metz >: >> > I think the module is

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Markus Neteler
On Dec 20, 2016 11:39 PM, "Markus Metz" wrote: > On Tue, Dec 20, 2016 at 11:09 PM, Martin Landa wrote: > > 2016-12-20 22:17 GMT+01:00 Markus Metz : > > > I think the module is automatically compiled only if it

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Markus Metz
On Tue, Dec 20, 2016 at 11:09 PM, Martin Landa wrote: > > Hi, > > 2016-12-20 22:17 GMT+01:00 Markus Metz : > > I think the module is automatically compiled only if it is added to > > grass-addons/grass7/imagery/Makefile which it is not yet. >

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Martin Landa
Hi, 2016-12-20 22:17 GMT+01:00 Markus Metz : > I think the module is automatically compiled only if it is added to > grass-addons/grass7/imagery/Makefile which it is not yet. no it's compiled automatically, see [1]. There is an compilation error. Ma [1]

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Markus Metz
On Tue, Dec 20, 2016 at 12:06 PM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > > On 20/12/16 10:04, Markus Metz wrote: >> >> Thanks a lot for the implementation! Since this is work in progress, the >> module could be moved from grass-addons to sandbox until the name and >> options are

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Moritz Lennert
On 20/12/16 10:04, Markus Metz wrote: Thanks a lot for the implementation! Since this is work in progress, the module could be moved from grass-addons to sandbox until the name and options are fixed? I had suggested addons since this allows Windows users who do not have the compilation chain

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Rashad Kanavath
On Tue, Dec 20, 2016 at 10:04 AM, Markus Metz wrote: > > > On Mon, Dec 19, 2016 at 6:02 PM, Rashad Kanavath < > mohammedrasha...@gmail.com> wrote: > > > > Hello > > > > On Mon, Dec 19, 2016 at 5:30 PM, Moritz Lennert < > mlenn...@club.worldonline.be> wrote: > >> >

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-20 Thread Markus Metz
On Mon, Dec 19, 2016 at 6:02 PM, Rashad Kanavath wrote: > > Hello > > On Mon, Dec 19, 2016 at 5:30 PM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: >> >> Hi Rashad, >> >> Another reflection: IIUC, in the current implementation all pixel values from all bands

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-19 Thread Rashad Kanavath
Hello On Mon, Dec 19, 2016 at 5:30 PM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > Hi Rashad, > > Another reflection: IIUC, in the current implementation all pixel values > from all bands are read into memory. This can quickly become a limiting > factor when working with very large

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-19 Thread Rashad Kanavath
On Mon, Dec 19, 2016 at 4:05 PM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > On 19/12/16 09:38, Rashad Kanavath wrote: > >> >> >> On Sun, Dec 18, 2016 at 2:53 PM, Moritz Lennert >> > >> wrote: >> >> On 18/12/16

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-19 Thread Moritz Lennert
Hi Rashad, Another reflection: IIUC, in the current implementation all pixel values from all bands are read into memory. This can quickly become a limiting factor when working with very large images. For now we can work this way until the general algorithm is clear, but in the long run, I

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-19 Thread Moritz Lennert
On 19/12/16 09:38, Rashad Kanavath wrote: On Sun, Dec 18, 2016 at 2:53 PM, Moritz Lennert > wrote: On 18/12/16 14:01, Rashad Kanavath wrote: Hello, As promised, I had pushed code to G7 addons repo

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-19 Thread Rashad Kanavath
On Sun, Dec 18, 2016 at 2:53 PM, Moritz Lennert < mlenn...@club.worldonline.be> wrote: > On 18/12/16 14:01, Rashad Kanavath wrote: > >> Hello, >> >> As promised, I had pushed code to G7 addons repo >> >> https://trac.osgeo.org/grass/browser/grass-addons/grass7/ima >> gery/i.superpixels.slic >>

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-18 Thread Moritz Lennert
On 18/12/16 14:01, Rashad Kanavath wrote: Hello, As promised, I had pushed code to G7 addons repo https://trac.osgeo.org/grass/browser/grass-addons/grass7/imagery/i.superpixels.slic Great job, thanks a lot

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-18 Thread Rashad Kanavath
Hello, As promised, I had pushed code to G7 addons repo https://trac.osgeo.org/grass/browser/grass-addons/grass7/ imagery/i.superpixels.slic I had tested with some small datasets and is working. More testing welcome :) On Wed, Dec 14, 2016 at 4:55 PM, Moritz Lennert <

Re: [GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-14 Thread Moritz Lennert
Le Wed, 14 Dec 2016 16:02:38 +0100, Rashad Kanavath a écrit : > Hello, > > From the trac ticket, I had started on slic implementation in grass. > I had an beta version > based on orginal c++ code. i.superpixels.slic > > It accepts three inputs for r,g,b and output a

[GRASS-dev] i.superpixels.slic ( was: #3142 Implementing SLIC image segmentation)

2016-12-14 Thread Rashad Kanavath
Hello, >From the trac ticket, I had started on slic implementation in grass. I had an beta version based on orginal c++ code. i.superpixels.slic It accepts three inputs for r,g,b and output a map with contour segments, there is work to expose some parameters such as pixelsize / step size,