Re: [GRASS-dev] [GRASS-SVN] r72686 - grass/trunk/raster/r.mode/testsuite

2018-05-04 Thread Anna Petrášová 
Hi,

I just wanted to point out, that some of the newly added tests were
actually not testing anything (see below) or failing because of
whitespace, please be more careful what you commit.

Thank you,

Anna

On Fri, May 4, 2018 at 11:47 PM,   wrote:
> Author: annakrat
> Date: 2018-05-04 20:47:30 -0700 (Fri, 04 May 2018)
> New Revision: 72686
>
> Modified:
>grass/trunk/raster/r.mode/testsuite/testrmode.py
> Log:
> r.mode: fix nonsense testsuite
>
> Modified: grass/trunk/raster/r.mode/testsuite/testrmode.py
> ===
> --- grass/trunk/raster/r.mode/testsuite/testrmode.py2018-05-05 03:32:36 
> UTC (rev 72685)
> +++ grass/trunk/raster/r.mode/testsuite/testrmode.py2018-05-05 03:47:30 
> UTC (rev 72686)
> @@ -1,7 +1,7 @@
>  """
>  Name:   r.mode test
>  Purpose:Tests r.mode and its flags/options.
> -
> +
>  Author: Supreet Singh
>  Copyright:  (C) 2018 by Supreet Singh and the GRASS Development Team
>  Licence:This program is free software under the GNU General Public
> @@ -13,10 +13,11 @@
>  from grass.gunittest.case import TestCase
>  from grass.gunittest.main import test
>
> +
>  class Testrmode(TestCase):
> -output='rmode'
> -base='geology'
> -cover='soils'
> +output = 'rmode'
> +base = 'geology'
> +cover = 'soils'
>
>  @classmethod
>  def setUpClass(cls):
> @@ -31,23 +32,10 @@
>  self.runModule('g.remove', type='raster', flags='f', 
> name=self.output)
>
>  def test_1(self):
> -soilsID='soils'
>  self.assertModule('r.mode', base=self.base, cover=self.cover, 
> output=self.output)
> -self.assertRasterMinMax(map=soilsID, refmin=18683, refmax=46555,
> -   msg="soilsID in degrees must be between 18683 
> and 46555")
> +self.assertRasterMinMax(map=self.output, refmin=21513, refmax=46487,
> +msg="soils must be between 21513 and 46487")
>
> -def test_2(self):
> -lakes='lakes'
> -self.assertModule('r.mode', base=self.base, cover=self.cover, 
> output=self.output)
> -self.assertRasterMinMax(map=lakes, refmin=34300, refmax=43600,
> -   msg="lakes in degrees must be between 34300 
> and 43600")
>
> -def test_3(self):
> -elevation='elevation'
> -self.assertModule('r.mode', base=self.base, cover=self.cover, 
> output=self.output)
> -self.assertRasterMinMax(map=elevation, refmin=2, refmax=4,
> -   msg="elevation in degrees must be between 
> NULL and NULL")
> -
>  if __name__ == '__main__':
>  test()
> -
>
> ___
> grass-commit mailing list
> grass-com...@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-commit
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-04 Thread Markus Neteler 
On Fri, May 4, 2018 at 10:02 PM, Martin Landa  wrote:
> Hi,
>
> 2018-04-25 20:26 GMT+02:00 Markus Neteler :
>> If there are no objections, I'll prepare RC1 in the next few days.
>
> since there is no blocker [1] I suggest to go ahead and prepare RC1 ASAP. 
> Martin
>
> [1] 
> https://trac.osgeo.org/grass/query?status=new=assigned=reopened=blocker=critical=7.4.1=7.4.0=type=priority

Delayed with respect to our roadmap I have now tagged GRASS GIS 7.4.1 RC1:

* Source code: https://grass.osgeo.org/grass74/source/grass-7.4.1RC1.tar.gz
* SVN Source Code Checkout 7.4.1RC1:
svn checkout
https://svn.osgeo.org/grass/grass/tags/release_20180504_grass_7_4_1RC1
* Draft release notes (please update!):
https://trac.osgeo.org/grass/wiki/Release/7.4.1-News

Please test!

Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3223: r.info displays wrong timestamp after t.rast.series with a where clause

2018-05-04 Thread GRASS GIS 
#3223: r.info displays wrong timestamp after t.rast.series with a where clause
--+-
  Reporter:  veroandreo   |  Owner:  grass-dev@…
  Type:  defect   | Status:  new
  Priority:  normal   |  Milestone:  7.4.1
 Component:  Default  |Version:  svn-trunk
Resolution:   |   Keywords:  r.info
   CPU:  Unspecified  |   Platform:  Linux
--+-

Comment (by neteler):

 Please close the ticket if issue is solved.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] Brainstorm about new GRASS GIS startup

2018-05-04 Thread Markus Neteler 
(time to revive this discussion)


On Tue, Mar 20, 2018 at 12:33 AM, Moritz Lennert
 wrote:
> Le Mon, 19 Mar 2018 21:34:58 +,
> Stefan Blumentrath  a écrit :
>
>> Hi Moritz,
>>
>> Looks nice.
>>
>> The "Open into a predefined lat-long location but give information
>> message" option seems less involved than the first. Thus if
>> "simplification" is the aim, I would probably continue in that
>> direction. Having lots of choices already at the first startup-screen
>> is probably counter-productive.
>
> Some even dream of a one-button system...

Three buttons at most:
 in - out - help

:)

>> An example location can be helpful for new users to get the concept
>> in any case. And I would suggest to start the predefined lat-lon
>> location in a mapset other than PERMANENT...
>
> We discussed this today. I personally agree that using something else
> than PERMANENT is good practice, but at the argument was that this is
> probably not really relevant for first time users and that using
> mapsets is actually already an advanced usage of GRASS.
>
>>
>> However, the placement of the GISDBASE directory is also an important
>> choice, that is not covert by the current mockups. So, maybe a more
>> wizard like approach might be worth a thought? Right after choosing
>> the GISDBASE dir, there can then be a "let me explore in sample
>> project" button (together with the other main buttons from the first
>> alternative maybe).
>
> Again, we discussed this today. One suggestion was even to
> automagically create a hidden GISDBASE directory and just create the
> first location there. Again, does a new user really have to worry about
> the location of the GISDBASE ?

+1

>> In any case, I would also consider a "don`t show this message again"
>> checkbox together with a grassrc setting...

This would be nice.

[...]
>> For better wiki structure, the page was renamed to:
>>
>> https://trac.osgeo.org/grass/wiki/wxGUIDevelopment/New_Startup

best,
Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-04 Thread Martin Landa 
Hi,

2018-04-25 20:26 GMT+02:00 Markus Neteler :
> If there are no objections, I'll prepare RC1 in the next few days.

since there is no blocker [1] I suggest to go ahead and prepare RC1 ASAP. Martin

[1] 
https://trac.osgeo.org/grass/query?status=new=assigned=reopened=blocker=critical=7.4.1=7.4.0=type=priority

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-04 Thread Michael Barton 
No. This is the more fixable but less critical pull custom down list control. 
When I get back to my computer I’ll look for the trac report

Michael Barton
School of Human Evolution  Change
Center for Social Dynamics & Complexity
Arizona State University

...Sent from my iPad

> On May 4, 2018, at 11:30 AM, Markus Neteler  wrote:
> 
>> On Mon, Apr 30, 2018 at 9:19 PM, Michael Barton  
>> wrote:
>> The crash is in both wxPython 3 and 4. There is a bug report with output 
>> text and a link to a possible lead on what is wrong. You can reproduce this 
>> on any of the new Mac binaries.
> 
> Is it this report?
> https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.osgeo.org_grass_ticket_3471=DwIBaQ=l45AxH-kUV29SRQusp9vYR0n1GycN4_2jInuKy6zbqQ=lk-7X7CEOMDN8GaGVhiDsuO6gEp1wbG6nfT1XEEEtR0=fDYqX08AaRAB7_yOgmL3Y-Nc0tBP-bpjESSjqcD3tgU=x5lF28M1OLNSnYxoq-IJbSxtXAwOSGVKUsZ6P4zvuBw=
> 
> Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [release planning] 7.4.1

2018-05-04 Thread Markus Neteler 
On Mon, Apr 30, 2018 at 9:19 PM, Michael Barton  wrote:
> The crash is in both wxPython 3 and 4. There is a bug report with output text 
> and a link to a possible lead on what is wrong. You can reproduce this on any 
> of the new Mac binaries.

Is it this report?
https://trac.osgeo.org/grass/ticket/3471

Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] v.extracy fails for type=boundary

2018-05-04 Thread Nikos Alexandris 

* Markus Metz  [2018-05-04 16:41:59 +0200]:


On Fri, May 4, 2018 at 4:09 PM, Nikos Alexandris 
wrote:


Dears,

I get something unexpected using type=boundary with `v.external`:

```
v.extract input=european_grid_10k_boundaries out=test type=boundary --v

--o

Using native format
Extracting features...
100%
Building topology for vector map ...
Registering primitives...
0 primitives registered
0 vertices registered
Topology was built
Number of nodes: 0
Number of primitives: 0
Number of points: 0
Number of lines: 0
Number of boundaries: 0
Number of centroids: 0
Number of areas: 0
Number of isles: 0
Writing attributes...
```


The default answer for the layer option of v.extract is 1, i.e. only
features with a category in layer 1 will be extracted. If you want to
extract all features of a given type, use e.g. v.extract layer=-1
type=boundary.

Markus M


Understood, it works. It's also in the NOTES of the manual, which I
obviously missed to read carefully.

Thank you Markus



signature.asc
Description: PGP signature
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] v.extracy fails for type=boundary

2018-05-04 Thread Markus Metz 
On Fri, May 4, 2018 at 4:09 PM, Nikos Alexandris 
wrote:
>
> Dears,
>
> I get something unexpected using type=boundary with `v.external`:
>
> ```
> v.extract input=european_grid_10k_boundaries out=test type=boundary --v
--o
> Using native format
> Extracting features...
> 100%
> Building topology for vector map ...
> Registering primitives...
> 0 primitives registered
> 0 vertices registered
> Topology was built
> Number of nodes: 0
> Number of primitives: 0
> Number of points: 0
> Number of lines: 0
> Number of boundaries: 0
> Number of centroids: 0
> Number of areas: 0
> Number of isles: 0
> Writing attributes...
> ```

The default answer for the layer option of v.extract is 1, i.e. only
features with a category in layer 1 will be extracted. If you want to
extract all features of a given type, use e.g. v.extract layer=-1
type=boundary.

Markus M

>
> I tried this in both 7.4 and trunk.
>
> The map does have boundaries,
> ```
> v.info -t european_grid_10k_boundaries
> nodes=253
> points=0
> lines=0
> boundaries=422
> centroids=177
> areas=177
> islands=8
> primitives=599
> map3d=0
> ```
>
> I can draw the boundaries on-screen using `d.vect type=boundary`.
>
> The vector map is small, so I have attached it here-in, in case someone
> can have a quick look.
>
> Thank you, Nikos
>
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] v.extracy fails for type=boundary

2018-05-04 Thread Nikos Alexandris 

* Nikos Alexandris  [2018-05-04 16:09:38 +0200]:


Dears,

I get something unexpected using type=boundary with `v.external`:


It's only `v.extract`, `v.external` has nothing to do with here. Sorry. 


[..]

Nikos


signature.asc
Description: PGP signature
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] v.extracy fails for type=boundary

2018-05-04 Thread Nikos Alexandris 

Dears,

I get something unexpected using type=boundary with `v.external`:

```
v.extract input=european_grid_10k_boundaries out=test type=boundary --v --o
Using native format
Extracting features...
100%
Building topology for vector map ...
Registering primitives...
0 primitives registered
0 vertices registered
Topology was built
Number of nodes: 0
Number of primitives: 0
Number of points: 0
Number of lines: 0
Number of boundaries: 0
Number of centroids: 0
Number of areas: 0
Number of isles: 0
Writing attributes...
```

I tried this in both 7.4 and trunk.

The map does have boundaries,
```
v.info -t european_grid_10k_boundaries
nodes=253
points=0
lines=0
boundaries=422
centroids=177
areas=177
islands=8
primitives=599
map3d=0
```

I can draw the boundaries on-screen using `d.vect type=boundary`.

The vector map is small, so I have attached it here-in, in case someone
can have a quick look.

Thank you, Nikos


european_grid_10k_boundaries.grasspack
Description: Binary data


signature.asc
Description: PGP signature
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev