Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  enhancement| Status:  reopened
  Priority:  normal |  Milestone:  7.6.0
 Component:  Vector |Version:  svn-trunk
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by neteler):

 For SQL reserved word collisions, see also #578, #1755, #3563

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  enhancement| Status:  reopened
  Priority:  normal |  Milestone:  7.6.0
 Component:  Vector |Version:  svn-trunk
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-
Changes (by neteler):

 * version:  7.4.0 => svn-trunk
 * type:  defect => enhancement
 * milestone:  7.4.2 => 7.6.0


Comment:

 Replying to [comment:3 pierreroudier]:
 > Patch for the v.in.ogr documentation

 Thanks, applied with modifications to trunk, relbr76, and relbr74.

 Turning into enhancement ticket for "Rename column to eg. ORDER_, print
 warning and continue" suggestion from above.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  reopened
  Priority:  normal |  Milestone:  7.4.1
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by sbl):

 Quoting identifiers (as also described in the link you provided) should
 work...

 However, this would require significant changes, as modules (subsequent to
 v.in.ogr) are not necessarily able to handle quoted identifiers.

 In addition, this SQL standard is not implemented in all DBMS equally.
 E.g. MySQL uses backticks for quoting (instead of quotes).

 See also: #3071

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  reopened
  Priority:  normal |  Milestone:  7.4.1
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by pierreroudier):

 Replying to [comment:6 martinl]:
 > G74:v.in.ogr could be more clever about such issues. Rename column to
 eg. ORDER_, print warning and continue.

 That would be a great feature -- with maybe a flag to control this
 behaviour: when using a flag such as say `-s`, `v.in.ogr` would add an
 underscore to any reserved SQL word rather than failing.

 In SQLite you could also bracket those words, but this does not look like
 standard SQL (source: https://www.sqlite.org/lang_keywords.html)

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  reopened
  Priority:  normal |  Milestone:  7.4.1
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-
Changes (by pierreroudier):

 * Attachment "v.in.ogr.html.patch" added.

 Patch for the v.in.ogr documentation

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  reopened
  Priority:  normal |  Milestone:  7.4.1
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by martinl):

 G74:v.in.ogr could be more clever about such issues. Rename column to eg.
 ORDER_, print warning and continue.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  reopened
  Priority:  normal |  Milestone:  7.4.1
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:  v.in.ogr
   CPU:  Unspecified|   Platform:  Unspecified
+-
Changes (by neteler):

 * status:  closed => reopened
 * keywords:   => v.in.ogr
 * resolution:  fixed =>
 * milestone:   => 7.4.1


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  closed
  Priority:  normal |  Milestone:
 Component:  Vector |Version:  7.4.0
Resolution:  fixed  |   Keywords:
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by neteler):

 Reopening: please add the patch as attachment, thanks

 (the ticket may be closed once the patch is applied, like this or in
 modified form and backported if needed)

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  closed
  Priority:  normal |  Milestone:
 Component:  Vector |Version:  7.4.0
Resolution:  fixed  |   Keywords:
   CPU:  Unspecified|   Platform:  Unspecified
+-
Changes (by pierreroudier):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by pierreroudier):

 Replying to [comment:1 hellik]:
 > >ORDER: Real (0.0)
 >
 > Order may be a SQL reserved word. try to rename it before

 Thanks -- that was indeed the problem! (This goes to show how limited my
 knoywledge of SQL is).

 It would maybe pay off to put a warning about this in the v.in.ogr
 documentation for users who like me don't do SQL very well.

 This is a patch that tries to address this:


 {{{
 --- v.in.ogr.html   2018-05-17 09:20:57.587213200 +1200
 +++ v.in.ogr-pr.html2018-05-17 09:30:55.141497148 +1200
 @@ -411,19 +411,41 @@

  ERROR MESSAGES

 -
 -DBMI-DBF driver error: SQL parser error: syntax error,
 -unexpected DESC, expecting NAME processing 'DESC'
 -indicates that a column name corresponds to a reserved SQL word
 (here: 'DESC').
 +SQL synthax errors
 +
 +Depending on the SQL driver, you can have errors such as:
 +
 +
 +DBMI-SQLite driver error:
 +Error in sqlite3_prepare():
 +near "ORDER": syntax error
 +
 +
 +Or:
 +
 +
 +DBMI-DBF driver error:
 +SQL parser error:
 +syntax error, unexpected DESC, expecting NAME processing 'DESC
 +
 +
 +This indicates that a column name in the input dataset corresponds to a
 reserved SQL word (here: 'ORDER' and 'DESC' respectively).
  A different column name should be used. The columns parameter can
 be used
 -to assign different column names on the fly.
 -Projection of dataset does not appear to match the current
 location.
 -You need to create a location whose projection matches the data
 +to assign different column names on the fly.
 +
 +See a list of SQL reserved words for SQLite (the default driver) here.
 +
 +Projection errors
 +
 +
 +Projection of dataset does not appear to match the current location.
 +
 +
 +You need to create a location whose projection matches the data
  you wish to import. Try using location parameter to create a
  new location based upon the projection information in the file. If
  desired, you can then re-project it to another location
 -with v.proj.
 -
 +with v.proj.

  REFERENCES


 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3563: v.in.ogr can't create tables in GRASS 7.4

[GRASS GIS]

#3563: v.in.ogr can't create tables in GRASS 7.4
+-
  Reporter:  pierreroudier  |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:
 Component:  Vector |Version:  7.4.0
Resolution: |   Keywords:
   CPU:  Unspecified|   Platform:  Unspecified
+-

Comment (by hellik):

 >ORDER: Real (0.0)

 Order may be a SQL reserved word. try to rename it before

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev