[Group.of.nepali.translators] [Bug 1615780] Re: Confusing 'success' message when apply_net fails.
This bug is believed to be fixed in curtin in 17.1. If this is still a problem for you, please make a comment and set the state back to New Thank you. ** Changed in: curtin Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of नेपाली भाषा समायोजकहरुको समूह, which is subscribed to Xenial. Matching subscriptions: Ubuntu 16.04 Bugs https://bugs.launchpad.net/bugs/1615780 Title: Confusing 'success' message when apply_net fails. Status in curtin: Fix Released Status in curtin package in Ubuntu: Fix Released Status in curtin source package in Xenial: Fix Released Bug description: [Impact] * Curtin produced a configusing 'success' message when failying to apply a provided network configuration. Curtin has been updated to ensure that if 'apply_net' commands fail the return code is propagated up to the invocation and no longer prints both a success and failure message when a failure occurs. [Test Case] * Install proposed curtin package and run the command - # curtin apply_net -t target -c bad.yaml PASS: Curtin does not emit successful message: 'Applied network configuration successfully' FAIL: Curtin emits both 'Applied network configuration successfully' and 'failed to apply network config' [Regression Potential] * Users of apply_net cli command may have examined the output of the command which is now modified, as well as the return code. [Original Description] When apply_net fails, the user both a fail message and a success message.. a bit confusing. root@x1:~# curtin apply_net -t target -c bad.yaml Applying network configuration failed to apply network config Traceback (most recent call last): File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 78, in apply_net_main network_config=state['network_config']) File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 44, in apply_net ns = net.parse_net_config(network_config) File "/usr/lib/python3/dist-packages/curtin/net/__init__.py", line 283, in parse_net_config net_config = config.load_config(path) File "/usr/lib/python3/dist-packages/curtin/config.py", line 117, in load_config return yaml.safe_load(content) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 94, in safe_load return load(stream, SafeLoader) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 72, in load return loader.get_single_data() File "/usr/lib/python3/dist-packages/yaml/constructor.py", line 35, in get_single_data node = self.get_single_node() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 55, in compose_document node = self.compose_node(None, None) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 133, in compose_mapping_node item_value = self.compose_node(node, item_key) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 127, in compose_mapping_node while not self.check_event(MappingEndEvent): File "/usr/lib/python3/dist-packages/yaml/parser.py", line 98, in check_event self.current_event = self.state() File "/usr/lib/python3/dist-packages/yaml/parser.py", line 428, in parse_block_mapping_key if self.check_token(KeyToken): File "/usr/lib/python3/dist-packages/yaml/scanner.py", line 116, in check_token self.fetch_more_tokens() File "/usr/lib/python3/dist-packages/yaml/scanner.py", line 257, in fetch_more_tokens self.get_mark()) yaml.scanner.ScannerError: while scanning for the next token found character '\t' that cannot start any token in "", line 4, column 5: config: ^ Applied network configuration successfully Note the emitting of messages "failed to apply network config" AND "Applied network configuration successfully" Really a minor issue. To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1615780/+subscriptions ___ Mailing list: https://launchpad.net/~group.of.nepali.translators Post to : group.of.nepali.translators@lists.launchpad.net Unsubscribe : https://launchpad.net/~group.of.nepali.translators More help : https://help.launchpad.net/ListHelp
[Group.of.nepali.translators] [Bug 1615780] Re: Confusing 'success' message when apply_net fails.
This bug was fixed in the package curtin - 0.1.0~bzr425-0ubuntu1~16.04.1 --- curtin (0.1.0~bzr425-0ubuntu1~16.04.1) xenial-proposed; urgency=medium [ Scott Moser ] * debian/new-upstream-snapshot: add writing of debian changelog entries. [ Ryan Harper ] * New upstream snapshot. - unittest,tox.ini: catch and fix issue with trusty-level mock of open - block/mdadm: add option to ignore mdadm_assemble errors (LP: #1618429) - curtin/doc: overhaul curtin documentation for readthedocs.org (LP: #1351085) - curtin.util: re-add support for RunInChroot (LP: #1617375) - curtin/net: overhaul of eni rendering to handle mixed ipv4/ipv6 configs - curtin.block: refactor clear_holders logic into block.clear_holders and cli cmd - curtin.apply_net should exit non-zero upon exception. (LP: #1615780) - apt: fix bug in disable_suites if sources.list line is blank. - vmtests: disable Wily in vmtests - Fix the unittests for test_apt_source. - get CURTIN_VMTEST_PARALLEL shown correctly in jenkins-runner output - fix vmtest check_file_strippedline to strip lines before comparing - fix whitespace damage in tests/vmtests/__init__.py - fix dpkg-reconfigure when debconf_selections was provided. (LP: #1609614) - fix apt tests on non-intel arch - Add apt features to curtin. (LP: #1574113) - vmtest: easier use of parallel and controlling timeouts - mkfs.vfat: add force flag for formating whole disks (LP: #1597923) - block.mkfs: fix sectorsize flag (LP: #1597522) - block_meta: cleanup use of sys_block_path and handle cciss knames (LP: #1562249) - block.get_blockdev_sector_size: handle _lsblock multi result return (LP: #1598310) - util: add target (chroot) support to subp, add target_path helper. - block_meta: fallback to parted if blkid does not produce output (LP: #1524031) - commands.block_wipe: correct default wipe mode to 'superblock' - tox.ini: run coverage normally rather than separately - move uefi boot knowledge from launch and vmtest to xkvm -- Ryan Harper Mon, 03 Oct 2016 13:43:54 -0500 ** Changed in: curtin (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of नेपाली भाषा समायोजकहरुको समूह, which is subscribed to Xenial. Matching subscriptions: Ubuntu 16.04 Bugs https://bugs.launchpad.net/bugs/1615780 Title: Confusing 'success' message when apply_net fails. Status in curtin: Fix Committed Status in curtin package in Ubuntu: Fix Released Status in curtin source package in Xenial: Fix Released Bug description: [Impact] * Curtin produced a configusing 'success' message when failying to apply a provided network configuration. Curtin has been updated to ensure that if 'apply_net' commands fail the return code is propagated up to the invocation and no longer prints both a success and failure message when a failure occurs. [Test Case] * Install proposed curtin package and run the command - # curtin apply_net -t target -c bad.yaml PASS: Curtin does not emit successful message: 'Applied network configuration successfully' FAIL: Curtin emits both 'Applied network configuration successfully' and 'failed to apply network config' [Regression Potential] * Users of apply_net cli command may have examined the output of the command which is now modified, as well as the return code. [Original Description] When apply_net fails, the user both a fail message and a success message.. a bit confusing. root@x1:~# curtin apply_net -t target -c bad.yaml Applying network configuration failed to apply network config Traceback (most recent call last): File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 78, in apply_net_main network_config=state['network_config']) File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 44, in apply_net ns = net.parse_net_config(network_config) File "/usr/lib/python3/dist-packages/curtin/net/__init__.py", line 283, in parse_net_config net_config = config.load_config(path) File "/usr/lib/python3/dist-packages/curtin/config.py", line 117, in load_config return yaml.safe_load(content) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 94, in safe_load return load(stream, SafeLoader) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 72, in load return loader.get_single_data() File "/usr/lib/python3/dist-packages/yaml/constructor.py", line 35, in get_single_data node = self.get_single_node() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 55, in compose_document node = self.compo
[Group.of.nepali.translators] [Bug 1615780] Re: Confusing 'success' message when apply_net fails.
** Also affects: curtin (Ubuntu) Importance: Undecided Status: New ** Also affects: curtin (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: curtin (Ubuntu) Status: New => Fix Released ** Changed in: curtin (Ubuntu Xenial) Status: New => Fix Committed -- You received this bug notification because you are a member of नेपाली भाषा समायोजकहरुको समूह, which is subscribed to Xenial. Matching subscriptions: Ubuntu 16.04 Bugs https://bugs.launchpad.net/bugs/1615780 Title: Confusing 'success' message when apply_net fails. Status in curtin: In Progress Status in curtin package in Ubuntu: Fix Released Status in curtin source package in Xenial: Fix Committed Bug description: [Impact] * Curtin produced a configusing 'success' message when failying to apply a provided network configuration. Curtin has been updated to ensure that if 'apply_net' commands fail the return code is propagated up to the invocation and no longer prints both a success and failure message when a failure occurs. [Test Case] * Install proposed curtin package and run the command - # curtin apply_net -t target -c bad.yaml PASS: Curtin does not emit successful message: 'Applied network configuration successfully' FAIL: Curtin emits both 'Applied network configuration successfully' and 'failed to apply network config' [Regression Potential] * Users of apply_net cli command may have examined the output of the command which is now modified, as well as the return code. [Original Description] When apply_net fails, the user both a fail message and a success message.. a bit confusing. root@x1:~# curtin apply_net -t target -c bad.yaml Applying network configuration failed to apply network config Traceback (most recent call last): File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 78, in apply_net_main network_config=state['network_config']) File "/usr/lib/python3/dist-packages/curtin/commands/apply_net.py", line 44, in apply_net ns = net.parse_net_config(network_config) File "/usr/lib/python3/dist-packages/curtin/net/__init__.py", line 283, in parse_net_config net_config = config.load_config(path) File "/usr/lib/python3/dist-packages/curtin/config.py", line 117, in load_config return yaml.safe_load(content) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 94, in safe_load return load(stream, SafeLoader) File "/usr/lib/python3/dist-packages/yaml/__init__.py", line 72, in load return loader.get_single_data() File "/usr/lib/python3/dist-packages/yaml/constructor.py", line 35, in get_single_data node = self.get_single_node() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/usr/lib/python3/dist-packages/yaml/composer.py", line 55, in compose_document node = self.compose_node(None, None) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 133, in compose_mapping_node item_value = self.compose_node(node, item_key) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/usr/lib/python3/dist-packages/yaml/composer.py", line 127, in compose_mapping_node while not self.check_event(MappingEndEvent): File "/usr/lib/python3/dist-packages/yaml/parser.py", line 98, in check_event self.current_event = self.state() File "/usr/lib/python3/dist-packages/yaml/parser.py", line 428, in parse_block_mapping_key if self.check_token(KeyToken): File "/usr/lib/python3/dist-packages/yaml/scanner.py", line 116, in check_token self.fetch_more_tokens() File "/usr/lib/python3/dist-packages/yaml/scanner.py", line 257, in fetch_more_tokens self.get_mark()) yaml.scanner.ScannerError: while scanning for the next token found character '\t' that cannot start any token in "", line 4, column 5: config: ^ Applied network configuration successfully Note the emitting of messages "failed to apply network config" AND "Applied network configuration successfully" Really a minor issue. To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1615780/+subscriptions ___ Mailing list: https://launchpad.net/~group.of.nepali.translators Post to : group.of.nepali.translators@lists.launchpad.net Unsubscribe : https://launchpad.net/~group.of.nepali.translators More help : https://help.launchpad.net/ListHelp
