Re: [grpc-io] Re: gRFC L16 on new API to make gRPC C++ library initialization explicit

2018-02-09 Thread 'Yang Gao' via grpc.io
Hi Arpit, This discussion is not really related to this gRFC now, as it does not seem to be related to grpc_init/shutdown issue. If I recall correctly, what you did is correct. Let's say you have a thread pool driving the ServerCompletionQueue's to handle events for the async rpc, and in the

Re: [grpc-io] Re: gRFC L16 on new API to make gRPC C++ library initialization explicit

2018-01-31 Thread Arpit Baldeva
Hi, Any feedback on this? Thanks. On Thursday, January 4, 2018 at 10:05:56 AM UTC-8, Arpit Baldeva wrote: > > Hi Yang, > > Sorry for the delayed reply. I was on vacation. > > Let me restate the problem very simply - Currently, I can't call > grpc::Server::Shutdown without first making sure

Re: [grpc-io] Re: gRFC L16 on new API to make gRPC C++ library initialization explicit

2018-01-04 Thread Arpit Baldeva
Hi Yang, Sorry for the delayed reply. I was on vacation. Let me restate the problem very simply - Currently, I can't call grpc::Server::Shutdown without first making sure that all the "operations" are completed first but without calling grpc::Server::Shutdown, the server keeps sending me work

Re: [grpc-io] Re: gRFC L16 on new API to make gRPC C++ library initialization explicit

2017-12-20 Thread Arpit Baldeva
Hi, I have looked at the gRFC and not too sure how it fixes some of the current issues with library shutdown (you referenced the issues I mentioned on GitHub/private conversations). First off, I don't know about other users but I was already forced to use grpc_init/shutdown in my code (so I

[grpc-io] Re: gRFC L16 on new API to make gRPC C++ library initialization explicit

2017-12-19 Thread 'Vijay Pai' via grpc.io
Hi there, I'd very much like to discuss this issue. Switching to explicit initialization increases friction for users, but keeping it the existing way just increases friction for the library writers (unless the code ends up being so failure-prone that it affects users through a loss of