Broken A20 gate handling

2005-06-30 Thread Ludovic Drolez
Hi ! Recently I tried to use grub(2) with a compaq evo D510. These boxes do not seem to have a keyboard controller, so grub freeze in gatea20(). Most free bootloaders fail, but one is okay: syslinux/isolinux. I've taken a look at syslinux's code, and indeed A20 activation is done much more c

Re: [PATCH 1/2] Various cleanups in kern/misc.c

2005-06-30 Thread Rodrigo Steinmüller Wanderley
Sorry Vicent, I was too lazy to look over the hole function and test it, I think there is more wrong in it. --- misc.orig.c 2005-06-30 08:39:32.0 -0300 +++ misc.test.c 2005-06-30 08:44:31.0 -0300 static char * grub_itoa (char *str, int c, unsigned n) { unsigned base = (c == '

Re: [PATCH 1/2] Various cleanups in kern/misc.c

2005-06-30 Thread Rodrigo Steinmüller Wanderley
Hi Vicent, Just one small comment here... I know its silly, but: 29/06 as 16:30: Vincent escreveu: VP> static char * VP> -grub_itoa (char *str, int c, unsigned n) VP> +grub_itoa (char *str, int c, unsigned int n) VP> { VP> - unsigned base = (c == 'x') ? 16 : 10; VP> + unsigned int base = (c

Re: [Bulk] Re: [PATCH] grub2: commands/cmp.c: grub_cmd_cmp()

2005-06-30 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marco Gerards wrote: > I think BUFFER_SIZE would be a better name. Another size can be > used. Perhaps it is better to use a bigger buffer size? As we read from a block device, I think the best size would be a multiple of the block size... But yes,

Re: [PATCH] grub2: commands/cmp.c: grub_cmd_cmp()

2005-06-30 Thread Marco Gerards
Vincent Pelletier <[EMAIL PROTECTED]> writes: Hi Vincent, Thanks for your patch. It looks ok to me. A few small comments... > 2005-06-29 Vincent Pelletier <[EMAIL PROTECTED]> > > * commands/cmp.c > (grub_cmd_cmp): Close the right file at the right time. Compare > only data