Re: [PATCH] [RFC] Add exitcode support

2015-08-18 Thread Dann Frazier
On Tue, Aug 18, 2015 at 1:17 PM, Ben Hildred <426...@gmail.com> wrote: > > > On Tue, Aug 18, 2015 at 12:56 PM, Dann Frazier > wrote: >> >> On Tue, Aug 18, 2015 at 12:03 PM, Ben Hildred <426...@gmail.com> wrote: >> > I only briefly scanned this, but this is cool (at least the idea is >> > something

Re: [PATCH] [RFC] Add exitcode support

2015-08-18 Thread Ben Hildred
On Tue, Aug 18, 2015 at 12:56 PM, Dann Frazier wrote: > On Tue, Aug 18, 2015 at 12:03 PM, Ben Hildred <426...@gmail.com> wrote: > > I only briefly scanned this, but this is cool (at least the idea is > > something I want to see implemented everywhere it makes sense to do so). > > Cool, thanks for

Re: [PATCH] [RFC] Add exitcode support

2015-08-18 Thread Dann Frazier
On Tue, Aug 18, 2015 at 12:03 PM, Ben Hildred <426...@gmail.com> wrote: > I only briefly scanned this, but this is cool (at least the idea is > something I want to see implemented everywhere it makes sense to do so). Cool, thanks for the feedback :) > Just one humdinger of a question: does efi as

Re: [PATCH] tcp: add window scaling support

2015-08-18 Thread Josef Bacik
On 08/17/2015 09:15 AM, Andrei Borzenkov wrote: 12.08.2015 18:57, Josef Bacik пишет: Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, whi

Re: [PATCH] [RFC] Add exitcode support

2015-08-18 Thread Ben Hildred
I only briefly scanned this, but this is cool (at least the idea is something I want to see implemented everywhere it makes sense to do so). Just one humdinger of a question: does efi assume nonzero is an error? Does platform X assume a nonzero exit is an error? Do we want to assume nonzero is an

[PATCH] net: don't free uninitialized sockets in dns

2015-08-18 Thread Josef Bacik
If we cannot open a connection to our dns server we will have NULL sockets in our array, so don't do the cleanup on any sockets that didn't get created. Signed-off-by: Josef Bacik --- grub-core/net/dns.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/grub-core/net/dns.c

Re: [PATCH] tcp: ack when we get an OOO/lost packet

2015-08-18 Thread Josef Bacik
On 08/17/2015 05:38 AM, Andrei Borzenkov wrote: On Thu, Aug 13, 2015 at 4:59 PM, Josef Bacik wrote: On 08/13/2015 04:19 AM, Andrei Borzenkov wrote: On Wed, Aug 12, 2015 at 6:16 PM, Josef Bacik wrote: While adding tcp window scaling support I was finding that I'd get some packet loss or reo

[PATCH] [RFC] Add exitcode support

2015-08-18 Thread dann frazier
Some platforms are capable of changing behavior based on the bootloader exit code. In particular, UEFI boot managers use this code to determine if they should try the next boot entry or not. I'd like to use this as a way to make my PXE server tell clients to attempt to boot from their next entry (p

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 18.08.15 at 14:00, wrote: > On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > @@ -119,10 +213,11 @@ __start: >> > >> > /* Save the Multiboot info struct (after relocation) for later >> > use. */ >> > mov $sym_phys(c

Re: [PATCH] progress: Check for NULL filename

2015-08-18 Thread Andrei Borzenkov
14.08.2015 00:04, dann frazier пишет: On Thu, Aug 13, 2015 at 10:52:19AM +0300, Andrei Borzenkov wrote: On Wed, Aug 12, 2015 at 6:53 PM, dann frazier wrote: Avoid a NULL pointer dereference if the upper fs layer hasn't set the file->name field. Files opened through the grub_net_fs interface cu

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Daniel Kiper
On Tue, Aug 18, 2015 at 02:12:58AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: [...] > > @@ -119,10 +213,11 @@ __start: > > > > /* Save the Multiboot info struct (after relocation) for later > > use. */ > > mov $sym_phys(cpu0_stack)+1024,%esp > > +

Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2015-08-18 Thread Daniel Kiper
On Tue, Aug 11, 2015 at 02:59:56PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 20, 2015 at 04:35:54PM +0200, Daniel Kiper wrote: > > Do not pass memory maps to image if it asked for EFI boot services. Maps are > > usually invalid in that case and they can confuse potential user. Image > > sh

Re: Keyboard not working with QEMU and coreboot and GRUB payload

2015-08-18 Thread Andrei Borzenkov
On Tue, Aug 18, 2015 at 12:41 AM, Paul Menzel wrote: > Dear GRUB folks, > > > just a note that using QEMU with coreboot and GRUB payload, I am unable > to enter anything. > > Using libpayload based payloads, the keyboard works, so I think it’s > GRUB related. > Does it work with any earlier GRUB

Keyboard not working with QEMU and coreboot and GRUB payload

2015-08-18 Thread Paul Menzel
Dear GRUB folks, just a note that using QEMU with coreboot and GRUB payload, I am unable to enter anything. Using libpayload based payloads, the keyboard works, so I think it’s GRUB related. Thanks, Paul $ qemu-system-i386 -M q35 -bios 20150808--coreboot-qemu-q35-with-grub.rom -serial stdi

Re: [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-18 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > v2 - not fixed yet: >- dynamic dependency generation for xen/arch/x86/boot/reloc.S; > this requires more work; I am not sure that it pays because > potential patch requires more changes than addition of just > multiboot2.h to Makefile > (s