Re: [PATCH] Ensure that MIPS target code is compiled for the O32 ABI.

2015-08-20 Thread Andrei Borzenkov
19.08.2015 21:35, Mark H Weaver пишет: Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile code for the O32 ABI when targetting MIPS, since the MIPS assembly code in GRUB assumes this. This flag is also needed when compiling asm-tests/mips.S from configure, because GNU as rejec

Re: [PATCH] net: don't free uninitialized sockets in dns

2015-08-20 Thread Andrei Borzenkov
18.08.2015 21:03, Josef Bacik пишет: If we cannot open a connection to our dns server we will have NULL sockets in our array, so don't do the cleanup on any sockets that didn't get created. We can avoid having holes to start with. Could you test attached patch? Signed-off-by: Josef Bacik --

Re: [PATCH] Avoid NULL pointer dereference in progress module.

2015-08-20 Thread Andrei Borzenkov
18.08.2015 00:57, dann frazier пишет: grub_net_fs_open() saves off a copy of the file structure it gets passed and uses it to create a bufio structure. It then overwrites the passed in file structure with this new bufio structure. Since file->name doesn't get set until we return back to grub_file

Re: [PATCH v2 14/23] efi: split out efi_find_gop_mode()

2015-08-20 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -665,6 +665,58 @@ static EFI_GRAPHICS_OUTPUT_PROTOCOL __init > *efi_get_gop(void) > return gop; > } > > +static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, > +

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-20 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Build xen.gz with EFI code. We need this to support multiboot2 > protocol on EFI platforms. > > If we wish to load not ELF file using multiboot (v1) or multiboot2 then DYM "a non-ELF file"? > it must contain "linear" (or "flat") representation of code and data

Re: [PATCH v2 09/23] efi: create efi_enabled()

2015-08-20 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > --- a/xen/arch/x86/efi/stub.c > +++ b/xen/arch/x86/efi/stub.c > @@ -4,9 +4,14 @@ > #include > #include > > -#ifndef efi_enabled > -const bool_t efi_enabled = 0; > -#endif > +struct efi __read_mostly efi = { > + .flags = 0, /* Initialized later. */ > +