Re: grub2-probe confused by double bind mount?

2017-08-08 Thread Chris Murphy
On Tue, Aug 8, 2017 at 2:04 AM, Vladimir 'phcoder' Serbinenko wrote: > Did you mount /proc ? What is the contents of /proc/self/mountinfo ? /proc is mounted. The way these ostree environments get assembled is super messy, and I can't be sure I'm truly assembling it exactly as

Re: [PATCH v2 04/14] efi: add grub_efi_get_ram_base() function for arm*

2017-08-08 Thread Leif Lindholm
On Thu, Aug 03, 2017 at 03:30:40PM +, Vladimir 'phcoder' Serbinenko wrote: > Any reason to use plain error numbers without grub_error? Well, no. In the way I'm using it, it will cascade down to a grub_error (GRUB_ERR_OUT_OF_MEMORY, N_("out of memory")); on failure. Do we need a specific one

Re: [PATCH v2 02/14] efi: add central copy of grub_efi_find_mmap_size

2017-08-08 Thread Leif Lindholm
On Thu, Aug 03, 2017 at 03:19:25PM +, Vladimir 'phcoder' Serbinenko wrote: > Looks good. But out of context the name is not descriptive enough. Can we > add a comment near declaration to clarify what this functions is for? Sure - will do. / Leif > Le Thu, Aug 3, 2017 à 12:07 PM, Leif

Re: grub2-probe confused by double bind mount?

2017-08-08 Thread Vladimir 'phcoder' Serbinenko
Did you mount /proc ? What is the contents of /proc/self/mountinfo ? On Tue, Aug 8, 2017, 06:35 Chris Murphy wrote: > On Mon, Aug 7, 2017 at 9:09 AM, Vladimir 'phcoder' Serbinenko > wrote: > > Upstream doesn't use grub2 prefix. Please try with latest

Re: [PATCH] * grub-core/fs/udf.c: Fix reading label, lvd.ident is dstring

2017-08-08 Thread Pali Rohár
Thanks a lot! On Monday 07 August 2017 15:40:15 Vladimir 'phcoder' Serbinenko wrote: > Committed with fixes and simplifications. The biggest problem was lack of > check whether grub_malloc succeeded > > Le Thu, Jun 22, 2017 à 2:34 PM, Pali Rohár a écrit : > > > UDF