Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 18:10, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: >> Initialize the needed Xen specific data. This is: >> >> - the Xen start of day page containing the console and Xenstore ring >> page PFN and event channel >> - the grant table >> - the

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 17:40, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 70 >>

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 17:33, Roger Pau Monné wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 36 >> +++ >>

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed,

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Roger Pau Monné
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 36 > +++ > grub-core/kern/i386/xen/startup_pvh.S | 29

Re: [Xen-devel] [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:48, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: >> Initialize the needed Xen specific data. This is: >> >> - the Xen start of day page containing the console and Xenstore ring >> page PFN and event channel >> - the grant table >> - the

Re: [Xen-devel] [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:40, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:10PM +0200, Juergen Gross wrote: >> Retrieve the memory map from the hypervisor and normalize it to contain >> no overlapping entries and to be sorted by address. >> >> Signed-off-by: Juergen Gross >> --- >>

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:30, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> Add the needed code to setup the hypercall page for calling into the >> Xen hypervisor. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/pvh.c | 70 >>

Re: [Xen-devel] [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:17, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: >> Add the code for the Xen PVH mode boot entry. >> >> Signed-off-by: Juergen Gross >> --- >> grub-core/kern/i386/xen/startup_pvh.S | 50 >> +++ >> 1 file

Re: [Xen-devel] [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Juergen Gross
On 19/10/2018 14:05, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: >> Add the hooks to current code needed for Xen PVH. > > I am not against the code itself but it would be nice to know why you > add, AIUI, just stubs here which will be filled with proper

Re: [Xen-devel] [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-19 Thread Juergen Gross
On 19/10/2018 13:54, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:06PM +0200, Juergen Gross wrote: >> include/grub/offsets.h needs some defines for Xen PVH mode. >> >> Add them. While at it line up the values in the surrounding lines to >> start at the same column. >> >> Signed-off-by:

Re: [PATCH v2 12/18] xen: setup Xen specific data for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:11PM +0200, Juergen Gross wrote: > Initialize the needed Xen specific data. This is: > > - the Xen start of day page containing the console and Xenstore ring > page PFN and event channel > - the grant table > - the shared info page > > Set the RSDP address for the

Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Andrew Cooper
On 19/10/18 13:30, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> + >> + __arg0 = a0; >> + __arg1 = a1; >> + __arg2 = a2; >> + __arg3 = a3; >> + __arg4 = a4; >> + asm volatile ("call *%[callno]" >> +: "=r" (__res), "+r" (__arg0), "+r"

Re: [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: > Add the needed code to setup the hypercall page for calling into the > Xen hypervisor. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 70 > +++ > 1 file changed, 70

Re: [PATCH v2 11/18] xen: get memory map from hypervisor for PVH

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:10PM +0200, Juergen Gross wrote: > Retrieve the memory map from the hypervisor and normalize it to contain > no overlapping entries and to be sorted by address. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/pvh.c | 98 >

Re: [PATCH v2 09/18] xen: add PVH boot entry code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:08PM +0200, Juergen Gross wrote: > Add the code for the Xen PVH mode boot entry. > > Signed-off-by: Juergen Gross > --- > grub-core/kern/i386/xen/startup_pvh.S | 50 > +++ > 1 file changed, 50 insertions(+) > > diff --git

Re: [PATCH v2 08/18] xen: add basic hooks for PVH in current code

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:07PM +0200, Juergen Gross wrote: > Add the hooks to current code needed for Xen PVH. I am not against the code itself but it would be nice to know why you add, AIUI, just stubs here which will be filled with proper code later. Daniel

Re: [PATCH v2 07/18] xen: add PVH specific defines to offset.h

2018-10-19 Thread Daniel Kiper
On Tue, Oct 09, 2018 at 01:03:06PM +0200, Juergen Gross wrote: > include/grub/offsets.h needs some defines for Xen PVH mode. > > Add them. While at it line up the values in the surrounding lines to > start at the same column. > > Signed-off-by: Juergen Gross > --- > include/grub/offsets.h | 21

Re: [Xen-devel] [PATCH v2 04/18] xen: prepare common code for Xen PVH support

2018-10-19 Thread Juergen Gross
On 18/10/2018 17:39, Juergen Gross wrote: > On 18/10/2018 16:59, Daniel Kiper wrote: >> On Tue, Oct 09, 2018 at 01:03:03PM +0200, Juergen Gross wrote: >>> Some common code needs to be special cased for Xen PVH mode. This hits >>> mostly Xen PV mode specific areas. >>> >>> Signed-off-by: Juergen