Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-19 Thread Matthew Garrett
On Mon, Nov 19, 2018 at 1:13 AM Daniel P. Smith wrote: > > It would be great if the TPM commands that are using EFI protocol and > exposed to TPM command module be name spaced under efi, e.g. > grub_efi_tpm_log_event. As I lay in a TIS implementation, I can mimic a > similar set of tis name

Re: [PATCH V2 2/3] verifiers: Core TPM support

2018-11-19 Thread Daniel Kiper
On Wed, Nov 14, 2018 at 03:24:53PM -0800, Matthew Garrett wrote: > From: Matthew Garrett > > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. In future we might > want to have some sort of mechanism for choosing which

Re: [PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Mon, Nov 19, 2018 at 11:20:06AM -0800, Nick Terrell wrote: > Hi all, > > This patch set imports the upstream zstd library, adds zstd support to the > btrfs module, and adds a test case. I've also tested the patch set by storing > my boot partition in btrfs with and without zstd compression and

[PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - Switch to

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
> On Nov 19, 2018, at 7:11 AM, Daniel Kiper wrote: > >> On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote: >>> On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: >>> - Adds zstd support to the btrfs module. >>> - Adds a test case for btrfs zstd support. >>> - Changes

Re: [PATCH v3 10/10] fdt: Add device tree file type

2018-11-19 Thread Leif Lindholm
On Mon, Nov 19, 2018 at 11:11:09AM +0100, Andreas Schwab wrote: > On Nov 14 2018, Alexander Graf wrote: > > > diff --git a/grub-core/loader/efi/fdt.c b/grub-core/loader/efi/fdt.c > > index a4c6e8036..d8ebe648e 100644 > > --- a/grub-core/loader/efi/fdt.c > > +++ b/grub-core/loader/efi/fdt.c > >

Re: PLEASE REVERT URGENTLY: Re: [PATCH v5 2/3] x86/boot: add acpi rsdp address to setup_header

2018-11-19 Thread Konrad Rzeszutek Wilk
On Sun, Nov 11, 2018 at 10:49:39AM -0800, H. Peter Anvin wrote: > On 11/10/18 1:03 AM, Juergen Gross wrote: > > > > How would that help? The garabge data written could have the correct > > terminal sentinel value by chance. > > > > That's why I re-used an existing field in setup_header (the

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote: > On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: > > - Adds zstd support to the btrfs module. > > - Adds a test case for btrfs zstd support. > > - Changes top_srcdir to srcdir in the btrfs module's lzo include > >

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Daniel Kiper
On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: > - Adds zstd support to the btrfs module. > - Adds a test case for btrfs zstd support. > - Changes top_srcdir to srcdir in the btrfs module's lzo include > following comments from Daniel Kiper about the zstd include. > > Tested on

Re: [PATCH v3 10/10] fdt: Add device tree file type

2018-11-19 Thread Andreas Schwab
On Nov 14 2018, Alexander Graf wrote: > diff --git a/grub-core/loader/efi/fdt.c b/grub-core/loader/efi/fdt.c > index a4c6e8036..d8ebe648e 100644 > --- a/grub-core/loader/efi/fdt.c > +++ b/grub-core/loader/efi/fdt.c > @@ -123,7 +123,7 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ >