Re: [PATCH] grub: add grub variable update functionality

2019-01-15 Thread Prarit Bhargava
On 1/14/19 10:49 AM, Daniel Kiper wrote: > On Fri, Jan 04, 2019 at 07:53:42AM -0500, Prarit Bhargava wrote: >> Please be aware I am NOT subscribed to grub-devel. >> >> P. >> >> ---8<--- >> >> Customers and users of the kernel are commenting that there is no way to >> update >> a grub variable

Re: TPM/Verifiers testing bug?

2019-01-15 Thread Matthew Garrett
On Tue, Jan 15, 2019 at 3:58 AM Daniel Kiper wrote: > > On Mon, Jan 14, 2019 at 11:42:21AM -0800, Matthew Garrett wrote: > > On Mon, Jan 14, 2019 at 6:09 AM 'Max Tottenham' via mjg59 > > wrote: > > > > > I went ahead and did some debugging. Below is a patch that seems to fix > > > my problem.

Re: bash completions in GRUB

2019-01-15 Thread Daniel Kiper
On Thu, Jan 10, 2019 at 11:37:48AM -0600, Bruce Dubbs wrote: > It appears that GRUB is not consistent with other applications when > installing the bash completions script. I suggest the following patch: > > diff --git a/util/bash-completion.d/Makefile.am > b/util/bash-completion.d/Makefile.am >

[PATCH] uboot: Add the missing disk write operation support

2019-01-15 Thread Cristian Ciocaltea
uboot_disk_write() is currently lacking the write support to storage devices because, historically, those devices did not implement block_write() in U-Boot. The solution has been tested using a patched U-Boot loading and booting GRUB in a QEMU vexpress-a9 environment. The disk write operations

[PATCH] Re: MKPasswd idempotency patch

2019-01-15 Thread grub-devel
Hello, just wanted to ask, if this patch got unnoticed, or if I just have to wait a bit longer for a response. This is my first time submitting a patch to the grub project, so please bear with me ;-) Best, Klaus Frank On Tue, Dec 25, 2018 at 12:01:12PM +0100, grub-de...@agowa338.de wrote: >

Re: [PATCH v3 3/4] mkimage: arm64-efi: Align header to page granularity

2019-01-15 Thread Daniel Kiper
On Tue, Jan 15, 2019 at 01:52:41PM +0100, Alexander Graf wrote: > On 01/15/2019 01:45 PM, Daniel Kiper wrote: > > On Mon, Jan 14, 2019 at 04:27:17PM +0100, Alexander Graf wrote: > > > In order to enforce NX semantics on non-code pages, UEFI firmware > > > may require that all code is EFI_PAGE_SIZE

Re: [PATCH v3 3/4] mkimage: arm64-efi: Align header to page granularity

2019-01-15 Thread Alexander Graf
On 01/15/2019 01:45 PM, Daniel Kiper wrote: On Mon, Jan 14, 2019 at 04:27:17PM +0100, Alexander Graf wrote: In order to enforce NX semantics on non-code pages, UEFI firmware may require that all code is EFI_PAGE_SIZE (4k) aligned. A similar change has recently been applied to edk2 to accomodate

Re: [PATCH v3 1/4] mkimage: Simplify header size logic

2019-01-15 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 04:27:15PM +0100, Alexander Graf wrote: > For EFI images, we always have the following layout: > > [PE header] > [padding] > [first section (which also is the entry point)] > > Currently there are 2 places where we define how big header+padding are: > in the

Re: TPM/Verifiers testing bug?

2019-01-15 Thread Daniel Kiper
On Mon, Jan 14, 2019 at 11:42:21AM -0800, Matthew Garrett wrote: > On Mon, Jan 14, 2019 at 6:09 AM 'Max Tottenham' via mjg59 > wrote: > > > I went ahead and did some debugging. Below is a patch that seems to fix > > my problem. Although those calls to grub_efi_open_protocol() in the tpm > >