Threading of patch series (was: [PATCH v6 00/14] error: Do compile-time format string checking on grub>)

2021-03-05 Thread Paul Menzel
Dear Glenn, Am 06.03.21 um 00:15 schrieb Glenn Washburn: On Fri, 5 Mar 2021 17:27:01 +0100 Daniel Kiper wrote: […] By the way, my I ask you once again to send each patch series as separate thread. Now you are attaching all patch sets to one cover letter which is confusing. Please stop

[PATCH] templates: Properly disable the os-prober by default

2021-03-05 Thread Philip Müller
- disable os-prober by default in grub-mkconfig.in by setting GRUB_DISABLE_OS_PROBER to true - fixes logic in 30_os-prober.in Reason for code shuffle in grub-mkconfig.in: The default was GRUB_DISABLE_OS_PROBER=false if you don't set GRUB_DISABLE_OS_PROBER at all. To prevent os-prober from

Re: [PATCH v6 00/14] error: Do compile-time format string checking on grub>

2021-03-05 Thread Glenn Washburn
On Fri, 5 Mar 2021 17:27:01 +0100 Daniel Kiper wrote: > On Thu, Mar 04, 2021 at 06:22:31PM -0600, Glenn Washburn wrote: > > Daniel, you mentioned wanting a separate patch series which is the > > real fix for patch #12. I've added it to this patch series, since > > they go together. I can send

Re: [PATCH] templates: Properly disable the os-prober by default

2021-03-05 Thread Didier Spaier
Le 05/03/2021 à 22:15, Philip Müller a écrit : - disable os-prober by default in grub-mkconfig.in by setting GRUB_DISABLE_OS_PROBER to true - fixes logic in 30_os-prober.in Reason for code shuffle in grub-mkconfig.in: The default was GRUB_DISABLE_OS_PROBER=false if you don't set

Re: [PATCH v6 00/14] error: Do compile-time format string checking on grub>

2021-03-05 Thread Daniel Kiper
On Thu, Mar 04, 2021 at 06:22:31PM -0600, Glenn Washburn wrote: > Daniel, you mentioned wanting a separate patch series which is the real fix > for patch #12. I've added it to this patch series, since they go together. > I can send the single patch as a separate thread if that still desirable.

Re: [PATCH] style: Format string macro should have a space between quotes

2021-03-05 Thread Daniel Kiper
On Thu, Mar 04, 2021 at 04:46:50PM -0600, Glenn Washburn wrote: > On Thu, 4 Mar 2021 20:03:34 +0100 > Daniel Kiper wrote: > > > Does this patch fix all such issues in the GRUB source code? > > > > Daniel > > I don't know and its unclear the scope of your question. However, this > is the grep I

Re: [PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Dimitri John Ledkov
On Fri, Mar 5, 2021 at 1:34 PM Michael Chang wrote: > > On Fri, Mar 05, 2021 at 12:21:49PM +, Dimitri John Ledkov wrote: > > This is not an oversight but intentional. > > > > Currently there is no chainloader support with SBAT as further > > development is required to ensure policy is applied

Re: [PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Dimitri John Ledkov
This is not an oversight but intentional. Currently there is no chainloader support with SBAT as further development is required to ensure policy is applied correctly. Once SBAT support for chainloading is defined, it will be introduced. And yes it is intended to continue to allow "boot windows"

[PATCH v2] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Michael Chang via Grub-devel
While attempting to dual boot Microsoft Windows with efi chainloader, it failed with below error when secure boot was enabled. error ../../grub-core/kern/verifiers.c:119:verification requested but nobody cares: /EFI/Microsoft/Boot/bootmgfw.efi. It is a regression, as previously it worked without

Re: [PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Michael Chang via Grub-devel
On Fri, Mar 05, 2021 at 12:21:49PM +, Dimitri John Ledkov wrote: > This is not an oversight but intentional. > > Currently there is no chainloader support with SBAT as further > development is required to ensure policy is applied correctly. Once > SBAT support for chainloading is defined, it

Re: [PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Michael Chang via Grub-devel
On Fri, Mar 05, 2021 at 01:32:57PM +0100, Thomas Frauendorfer wrote: > On Fri, Mar 5, 2021 at 1:12 PM Michael Chang via Grub-devel > wrote: > > > > While attempting to dual boot Microsoft Windows with efi chainloader, it > > failed with below error when secure boot was enabled. > > > > error

Re: [PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Thomas Frauendorfer
On Fri, Mar 5, 2021 at 1:12 PM Michael Chang via Grub-devel wrote: > > While attempting to dual boot Microsoft Windows with efi chainloader, it > failed with below error when secure boot was enabled. > > error ../../grub-core/kern/verifiers.c:119:verification requested but > nobody cares:

[PATCH] Add chainloaded image as shim's verifiable object

2021-03-05 Thread Michael Chang via Grub-devel
While attempting to dual boot Microsoft Windows with efi chainloader, it failed with below error when secure boot was enabled. error ../../grub-core/kern/verifiers.c:119:verification requested but nobody cares: /EFI/Microsoft/Boot/bootmgfw.efi. It is a regression, as previously it worked without