[PATCH 11/12] grub-shell: Use malta qemu-mips machine type instead off non-existant indy

2021-03-31 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index fbc809a8c..c69fbd080 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -119,7 +119,7 @@

[PATCH 04/12] grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar

2021-03-31 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 9d8c417da..e80471126 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -211,7 +211,7 @@

[PATCH 09/12] grub-shell: Add --verbose to mkrescue when $debug is greater than 2

2021-03-31 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index 198b03057..854508750 100644 --- a/tests/util/grub-shell.in +++ b/tests/util/grub-shell.in @@ -404,7 +404,9

[PATCH 06/12] grub-shell: Add grub output logfile with grub-shell --debug

2021-03-31 Thread Glenn Washburn
This allows seeing full qemu output of grub-shell, which can be invaluable when debugging failing tests. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in

[PATCH 12/12] grub-shell: Update qemu UEFI firmware names to be more generic

2021-03-31 Thread Glenn Washburn
The current qemu firmware paths for arm-efi and arm64-efi are hardcoded and not available on Ubuntu/Debian. Make these paths relative and basenames generic. The idea is that regardless where or what names firmware images are installed under they can be copied and renamed into a temporary

[PATCH 07/12] grub-shell: Set exit status to qemu exit status

2021-03-31 Thread Glenn Washburn
This allows us to test if unexpected output in test scripts is because of a bug in grub, because there was an error in qemu, or qemu was killed due to a timeout. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH 10/12] grub-shell: Only turn on qemu head when large debug value is specified

2021-03-31 Thread Glenn Washburn
There are several levels of debug and more may be added. But the qemu head should be one of the highest debug levels. Set debug to a high value of 10 to turn on the head. We do not want to accidentally turn it on when adding a new debug level to the testing system. Signed-off-by: Glenn Washburn

[PATCH 08/12] tests: Allow turning on shell tracing from environment variables

2021-03-31 Thread Glenn Washburn
This allows turning on shell tracing when its not practical or not possible to use commandline arguments. Turn on tracing when the envvar is an integer greater than 1, since these can log a lot of messages. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 2 ++

[PATCH 00/12] Grub-shell improvements

2021-03-31 Thread Glenn Washburn
I've extracted this patch series from the GitLab CI patch series, which some minor modifications. Mostly these are improvements to grub-shell to facilitate debugging. The only patch that might be considered a fix, as opposed to an improvement, would be patch #11, which fixes the issue where

[PATCH 03/12] grub-shell: Only show grub-mkrescue output if it returns an error

2021-03-31 Thread Glenn Washburn
The previous behavior ignored an error and the output from grub-mkrescue. This made it a pain to discover that grub-mkrescue was the reason that tests which rely on grub-shell were failing. Even after discovering grub-mkrescue was the culprit, there was no output to indicate why it was failing.

[PATCH 05/12] grub-shell: Put all generated files into working dir and use better file names

2021-03-31 Thread Glenn Washburn
When running tests there are many invocations of grub-shell, and because the output files are all random names in the same tmp directory, it becomes more work to figure out which files went with which grub-shell invocations. So all generated files from one invocation of grub-shell are put into a

[PATCH 02/12] grub-shell: Trim line should always be matched from the beginning of the line

2021-03-31 Thread Glenn Washburn
When turning on shell tracing the trim line will be output before we actually want to start the trim. However, in this case the trim line never starts from the beginning of the line. So start trimming from the correct line by matching from the beginning of the line. Signed-off-by: Glenn Washburn

[PATCH 01/12] grub-shell: Allow specifying non-default trim line contents

2021-03-31 Thread Glenn Washburn
This will be useful for tests that have unwanted output from setup. This is not documented because its only intended to be internal at the moment. Also, --no-trim is allowed to explicitly turn off trim. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 14 +- 1 file

Re: multiboot2 and module2 boot issues via GRUB2

2021-03-31 Thread Roman Shaposhnik
Hi Andrew! first of all -- thanks for pointing me in the right direction. So after reading relevant sources: comments inline. On Tue, Mar 30, 2021 at 12:08 PM Andrew Cooper wrote: > On 30/03/2021 19:28, Roman Shaposhnik wrote: > > Hi! > > > > seems like I've run into an issue with multiboot2

[PATCH 2/2] docs: Conform badmem and cutmem description indentations with other commands

2021-03-31 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 93ae12a88..e2c58415a 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4125,7 +4125,6 @@ can be changed only when using @samp{gfxterm}

[PATCH 1/2] docs: Add note to cryptomount that UUIDs should be specified without dashes

2021-03-31 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index eeb3118eb..93ae12a88 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4307,6 +4307,9 @@ GRUB suports devices encrypted using LUKS, LUKS2 and geli.

[PATCH 0/2] Misc doc changes

2021-03-31 Thread Glenn Washburn
The first patch adds a long overdue note to the cryptomount command that UUIDs should be specified without dash, differently than how fs uuids are specified. The second patch makes the indentation of command description text for cutmem and badmem conform with the indentation of the rest of the

[PATCH] password: Fix backspace in username prompt

2021-03-31 Thread egori
From: Egor Ignatov Allow control characters in the bidi visual. Resolves: #60114 Signed-off-by: Egor Ignatov --- grub/grub-core/normal/charset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/grub/grub-core/normal/charset.c b/grub/grub-core/normal/charset.c index b0ab47d73..30e819bdf

Re: Dell BIOS issue reading Disk Extended data

2021-03-31 Thread Jordan Uggla
This should *not* be made default because grub's native drivers don't get very much testing, and they do cause grub to hang on some hardware, but you can likely get around this limitation with: grub-install --target=i386-pc --disk-module native /dev/sdX If you want to test it without installing

Re: Dell BIOS issue reading Disk Extended data

2021-03-31 Thread Guilherme Piccoli
On Tue, Mar 30, 2021 at 2:43 PM K, Narendra wrote: > > On Fri, Jan 22, 2021 at 3:41 PM Limonciello, Mario > > wrote: > > > > > > > > > > > Hello Dell folks, I'm Guilherme Piccoli from Canonical - first of > > > > all, apologies for the out-of-nowhere communication. We've been > > > >