Re: [PATCH v2] po: Un-transliterate the %zu format code

2022-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2022 at 01:08:32AM -0600, Glenn Washburn wrote: > Commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is > too long) uses the %zu format specifier which has not been used in > any translated strings yet. So the sed scripts used for tranliterating > certain

Re: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-11 Thread Daniel Kiper
On Fri, Mar 11, 2022 at 11:09:16AM -0600, Glenn Washburn wrote: > On Fri, 11 Mar 2022 00:35:57 +0100 > Daniel Kiper wrote: > > > Latest GCC may complain in that way: > > > > commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: > > commands/i386/pc/sendkey.c:223:21: error: writing

Re: [PATCH 0/6] Various fixes and cleanups

2022-03-11 Thread Robbie Harwood
Daniel Kiper writes: > Hey, > > Mostly build fixes plus one cleanup and INSTALL file update. > > Daniel > > INSTALL | 3 ++- > conf/i386-cygwin-img-ld.sc | 4 > configure.ac | 4 ++-- > grub-core/commands/i386/pc/sendkey.c |

Re: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-11 Thread Vladimir 'phcoder' Serbinenko
LGTM On Fri, Mar 11, 2022 at 12:37 AM Daniel Kiper wrote: > > Latest GCC may complain in that way: > > commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: > commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of > size 0 [-Werror=stringop-overflow=] > 223

Re: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-11 Thread Toomas Soome via Grub-devel
> On 11. Mar 2022, at 19:10, Glenn Washburn wrote: > > On Fri, 11 Mar 2022 00:35:57 +0100 > Daniel Kiper wrote: > >> Latest GCC may complain in that way: >> >> commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: >> commands/i386/pc/sendkey.c:223:21: error: writing 1 byte

Re: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-11 Thread Glenn Washburn
On Fri, 11 Mar 2022 00:35:57 +0100 Daniel Kiper wrote: > Latest GCC may complain in that way: > > commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: > commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of > size 0 [-Werror=stringop-overflow=] > 223 |