[PATCH V2] grub-core: modify sector by sysfs as disk sector

The disk sector size provided by sysfs file system considers the sector size of 512 irrespective of disk sector size, Thus causing the read by grub to an incorrect offset from what was originally intended. Considering the 512 sector size of sysfs data the actual sector needs to be modified

[PATCH v2] tests: Add pathological iso9660 filesystem tests

These are not added to grub-fs-tester because they are not generated and none of the filesystem tests are run on these isos. The test is to run the command "ls /" on the iso, and a failure is determined if the command times out, has non-zero return value or has any output. Signed-off-by: Glenn

Re: Incorrect comment in disk.h (and bigger cache) ?

* On 2/9/23 01:05, Benjamin Herrenschmidt wrote: > Stumbled upon this: > > /* The size of a disk cache in 512B units. Must be at least as big as the >largest supported sector size, currently 16K. */ > #define GRUB_DISK_CACHE_BITS 6 > #define GRUB_DISK_CACHE_SIZE (1 << GRUB_DISK_CACHE_BITS)

Incorrect comment in disk.h (and bigger cache) ?

Hi 1 Stumbled upon this: /* The size of a disk cache in 512B units. Must be at least as big as the largest supported sector size, currently 16K. */ #define GRUB_DISK_CACHE_BITS6 #define GRUB_DISK_CACHE_SIZE(1 << GRUB_DISK_CACHE_BITS) It's me or somebody had a bad day with math ? :-)

Re: [PATCH] grub-core: modify sector by sysfs as disk sector

On Fri, Feb 03, 2023 at 10:10:43AM +0530, Mukesh Kumar Chaurasiya wrote: > The disk sector size provided by sysfs file system considers the > sector size of 512 irrespective of disk sector size, Thus > causing the read by grub to an incorrect offset from what was > originally intended. > >

Re: [PATCH] tests/util/grub-fs-tester: Use shell variable instead of autoconf

On Sat, Feb 04, 2023 at 06:26:07PM -0600, Glenn Washburn wrote: > By using a shell variable that is set once by the expansion of an autoconf > variable, the resulting script is more readable. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel

Re: [PATCH] tests/util/grub-fs-tester: Remove unused variable

On Sat, Feb 04, 2023 at 06:26:06PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] luks2: Add support for LUKS2 in (proc)/luks_script

On Sun, Feb 05, 2023 at 01:05:31AM -0600, Glenn Washburn wrote: > The sector size in bytes is added to each line and it is allowed to be 5 > decimal digits long, which covers the most common cases of 512 and 4096 > byte sectors with space for an additional digit as future-proofing. The > size

Re: [PATCH] net/bootp: Fix unchecked return value

On Fri, Feb 03, 2023 at 05:18:14PM -0500, Alec Brown wrote: > In the function send_dhcp_packet(), added an error check for the return value > of > grub_netbuff_push(). > > Fixes: CID 404614 > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel