[PATCH] fix listing values of variables with read hook in set command

2013-05-16 Thread Andrey Borzenkov
Variables with read hook may return valid value even before they are explicitly set. Use grub_env_get() to fetch values to ensure hooks are called. Signed-off-by: Andrey Borzenkov --- ChangeLog| 5 + grub-core/kern/corecmd.c | 2 +- 2 files changed, 6 insertions(+), 1

Re: Where is GRUB development?

2013-05-13 Thread Andrey Borzenkov
В Mon, 13 May 2013 13:07:14 -0400 "Lennart Sorensen" пишет: > On Mon, May 13, 2013 at 09:24:34AM -0700, Bruce Korb wrote: > > I've been Googling around to no particular avail. I have this > > _really_ difficult problem. I need to boot into single user mode and > > GRUB2 has made it so difficult

Re: New command eval.

2013-05-11 Thread Andrey Borzenkov
В Sat, 11 May 2013 17:07:19 -0700 Seth Goldberg пишет: > Hi, > > What about the feature environment variable to allow dynamic detection of > this enhancement? > That really does not scale. Commands come and go. What about single command "has" (or probably better "implements") as in impleme

[PATCH] emit EXTRA_DIST unconditionally so tarball does not depend on configured platform

2013-05-11 Thread Andrey Borzenkov
ory compilation terminated. Change gentpl.py to emit dist_noinst_DATA instead. Automake collects them even when assignment is under false condition, so it ensures tarball always includes the same files on every platform. It also changes data to emit dist__DATA instead of using EXTRA_DIST.

Re: New command eval.

2013-05-11 Thread Andrey Borzenkov
В Sat, 11 May 2013 19:02:58 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 11.05.2013 18:35, Andrey Borzenkov wrote: > > > + grub_size_t size = argc; /* +1 for final zero */ > > + char *str, *p; > > + grub_err_t ret; > > + > >

New command eval.

2013-05-11 Thread Andrey Borzenkov
? I decided to split off pure execute_sourcecode so that eval context would not clobber positional arguments. diff --git a/ChangeLog b/ChangeLog index cd8213a..8ca9874 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2013-05-11 Andrey Borzenkov + + * grub-core/script/execute.c (gru

Re: [PATCH] fix grub-install efibootmgr presence test with --removable

2013-05-11 Thread Andrey Borzenkov
В Sat, 11 May 2013 08:49:00 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 11.05.2013 06:43, Andrey Borzenkov wrote: > > > В Fri, 10 May 2013 16:57:38 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >> On 09.05.2013

Re: Obtaining the MAC address of the boot NIC for a PXE boot

2013-05-10 Thread Andrey Borzenkov
В Fri, 10 May 2013 09:12:57 -0700 (PDT) Rigoberto Corujo пишет: > > Thank you Andrey.  I can confirm that the net_default_interface, > net_default_ip, and net_default_mac variables worked as expected.  I did > notice, however, then when I'm in the grub shell and I type "set", these > variable

Re: [PATCH] fix grub-install efibootmgr presence test with --removable

2013-05-10 Thread Andrey Borzenkov
В Fri, 10 May 2013 16:57:38 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 09.05.2013 12:44, Leif Lindholm wrote: > > > When executed for an EFI target, grub-install checks for the path of > > efibootmgr - however, this utility is not required (or used) when > > installing to a removabl

Re: Loading OS/X 10.7 by grub x86_64-efi fails

2013-05-10 Thread Andrey Borzenkov
В Fri, 10 May 2013 14:18:42 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 09.05.2013 20:32, Andrey Borzenkov wrote: > > > I have MacBook (Pro?) 3.1 with OS/X 10.7. I installed as second OS > > openSUSE 12.3 using EFI CD boot (worked just fine) and x8

Re: Loading OS/X 10.7 by grub x86_64-efi fails

2013-05-09 Thread Andrey Borzenkov
В Thu, 9 May 2013 22:32:05 +0400 Andrey Borzenkov пишет: > I have MacBook (Pro?) 3.1 with OS/X 10.7. I installed as second OS > openSUSE 12.3 using EFI CD boot (worked just fine) and x86_64-efi > grub2. I had to manually bless grub on EFI partition to actually boot > it. os-probe

Re: [PATCH] fix grub-install efibootmgr presence test with --removable

2013-05-09 Thread Andrey Borzenkov
В Thu, 9 May 2013 10:44:35 + Leif Lindholm пишет: > When executed for an EFI target, grub-install checks for the path of > efibootmgr - however, this utility is not required (or used) when > installing to a removable media (with --removable). > > However, since grub-install does "set -e", th

Loading OS/X 10.7 by grub x86_64-efi fails

2013-05-09 Thread Andrey Borzenkov
I have MacBook (Pro?) 3.1 with OS/X 10.7. I installed as second OS openSUSE 12.3 using EFI CD boot (worked just fine) and x86_64-efi grub2. I had to manually bless grub on EFI partition to actually boot it. os-prober also found installed OS/X and added to boot menu. The problem is, both 32 and 64

[PATCH] clarify network drive description

2013-05-09 Thread Andrey Borzenkov
Mention that network drives can include server address and that necessary modules are not autoloaded and must be loaded manually. Also cross-reference to net_default_server. Signed-off-by: Andrey Borzenkov --- ChangeLog | 5 + docs/grub.texi | 9 ++--- 2 files changed, 11

Re: Obtaining the MAC address of the boot NIC for a PXE boot

2013-05-08 Thread Andrey Borzenkov
В Wed, 8 May 2013 10:27:47 -0700 (PDT) Rigoberto Corujo пишет: > > Thank you very much, Andrey.  This worked.  I did have to add the following > lines to "grub-core/Makefile.core.am" to get a "eval.mod" generated, but I'm > sure that it's probably because I missed an important step that would

Re: Documentation for (Re: Obtaining the MAC address of the boot NIC for a PXE boot)

2013-05-08 Thread Andrey Borzenkov
В Tue, 07 May 2013 21:45:14 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > +@item net_default_interface > > +The name of interface that was used to load grub. Read-only. > > + > > It's read-write. Also its value doesn't influence anything other than > net_default_* variables. Added

Documentation for (Re: Obtaining the MAC address of the boot NIC for a PXE boot)

2013-05-07 Thread Andrey Borzenkov
e (do we need to list possible values?). OK to commit? From: Andrey Borzenkov To: grub-devel@gnu.org Subject: [PATCH] document new net_default_(interface|ip|mac) variables Also generalize description to indicate that other variables may apply to more than pxe interface. Signed-off-by:

Re: Obtaining the MAC address of the boot NIC for a PXE boot

2013-05-04 Thread Andrey Borzenkov
В Sat, 04 May 2013 23:19:50 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Patch for net_default_*. Please test. > > === modified file 'grub-core/net/bootp.c' > --- grub-core/net/bootp.c 2013-01-20 13:24:47 + > +++ grub-core/net/bootp.c 2013-05-04 21:16:02 + > @@ -211,6 +21

Re: GRUB and the risk of block list corruption in extX

2013-05-02 Thread Andrey Borzenkov
В Thu, 07 Feb 2013 11:47:33 +0100 Martin Wilck пишет: > Hello, > > this is a question about the long-running topic of installing GRUB in > partitions or partitionless disks. > Here is example how using filesystem blocklists may lead to unbootable system without any extX corruption involved. -

[PATCH] fix tarball compile failure due to missing tests/checksums.c

2013-05-02 Thread Andrey Borzenkov
make[3]: Entering directory `/home/bor/build/grub/grub-2.00/grub-core' gcc -DHAVE_CONFIG_H -I. -I.. -Wall -W -I../include -I../include -DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I386_PC -DGRUB_TARGET_CPU_I386=1 -m32 -nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/4.7/include -DGRUB_FILE=\"test

Re: [PATCH] define rs_decoder.S and sm712_start.S as nodist header files

2013-05-02 Thread Andrey Borzenkov
В Thu, 02 May 2013 14:06:40 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 02.05.2013 13:52, Andrey Borzenkov wrote: > > > > > -boot/i386/pc/startup_raw.S: $(builddir)/rs_decoder.S > > -boot/mips/loongson/fwstart.S: $(builddir)/sm712_start.S > &

[PATCH] define rs_decoder.S and sm712_start.S as nodist header files

2013-05-02 Thread Andrey Borzenkov
into rs_decoder.h, so automake does the right thing. For consistency do the same with sm712_start.S which is not required during "make dist" as well. Signed-off-by: Andrey Borzenkov --- grub-core/Makefile.am | 9 +++-- grub-core/Makefile.core.def| 2 +

Re: Obtaining the MAC address of the boot NIC for a PXE boot

2013-05-01 Thread Andrey Borzenkov
В Mon, 29 Apr 2013 05:55:32 -0700 (PDT) Rigoberto Corujo пишет: > Hello everyone, > > With pxelinux, you can specify "IPAPPEND 2" in your boot loader configuration > file and the MAC address of the boot NIC automatically gets appended to your > kernel parameters as "BOOTIF=XX:XX:XX:XX:XX:XX". 

Incomplete sentence in the latest documentation (Output terminal)?

2013-04-27 Thread Andrey Borzenkov
The latest doc contains: If fonts contain all required characters then bidirectional text, cursive variants and combining marks other than enclosing, half (e.g. left half tilde or combining overline) and double ones. This sentence looks incomplete. Probably it is missing final "are supported"? _

grub stack size limit?

2013-04-21 Thread Andrey Borzenkov
Are there limits for stack size used in grub? I.e. is allocation of several KB on stack acceptable or it should go into heap in this case? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-19 Thread Andrey Borzenkov
В Fri, 12 Apr 2013 11:27:21 +0400 Vladimir Testov пишет: > >I think "XXX deg" is enough. It avoids confusion with single/plural > >forms and we just need something to distinguish from plain number. > > Maybe we should use all three keywords - "deg", "degree", "degrees" ? > I do not see any rea

Re: [PATCH] reimplement grub-reboot to nor depend on GRUB_DEFAULT=saved

2013-04-19 Thread Andrey Borzenkov
В Sun, 07 Apr 2013 14:38:40 +0200 Paul Menzel пишет: > > s,nor,not, > > > s,consequitive,consecutive, > > > *variab*l*e > > > Otherwise I did not spot anything. > Thank you for review. Updated patch follows. From: Andrey Borzenkov Subject: [PATCH] r

Re: [PATCH] 30_os-prober: add $onstr ot top level Linux entries too

2013-04-19 Thread Andrey Borzenkov
В Thu, 11 Apr 2013 00:13:55 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 05.04.2013 09:30, Andrey Borzenkov wrote: > > > This fixes two issues > > > > 1. It visually distinguishes between multiple installations of the > > same OS version. Cu

Re: Still unable to build from tardist due to libgcrypt (and probably more) POTFILES

2013-04-18 Thread Andrey Borzenkov
В Wed, 17 Apr 2013 21:49:02 +0400 Andrey Borzenkov пишет: > I do not quite understand how po/POTFILES are maintained but they refer > to files that are not distributed, so rebuild later fails. > OK, I fixed out package to avoid attempt to rebuild pot files. > It is not just one

Still unable to build from tardist due to libgcrypt (and probably more) POTFILES

2013-04-17 Thread Andrey Borzenkov
I do not quite understand how po/POTFILES are maintained but they refer to files that are not distributed, so rebuild later fails. [ 270s] TARGET_OBJ2ELF= sh genmod.sh moddep.lst gcry_whirlpool.module gcry_whirlpool.mod [ 270s] make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/grub-2.00/

make failure in grub-core/gnulib in trunk

2013-04-16 Thread Andrey Borzenkov
It fails immediately. bor@opensuse:~/build/grub> LC_MESSAGES=C make bison -d -p grub_script_yy -b grub_script ./grub-core/script/parser.y flex -o grub_script.yy.c --header-file=grub_script.yy.h ./grub-core/script/yylex.l gcc -E -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIB

[PATCH] really limit size of efidisk transfer to 0x500

2013-04-16 Thread Andrey Borzenkov
Rev 4859 failed to actually limit transfer size. Signed-off-by: Andrey Borzenkov --- ChangeLog| 4 grub-core/disk/efi/efidisk.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6f33ff1..77a0819 100644 --- a/ChangeLog

Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Andrey Borzenkov
В Tue, 16 Apr 2013 13:04:28 +0400 Vladimir Testov пишет: > >Please don't use // comments. > O.k. I won't. > >This code completely forgets the cases > >when even the first word doesn't fit in the available space. > > Mmm. It can handle this case actually. > > >The code as whole breaks some unico

Re: [PATCH] [9/11] [gfxmenu/list] minmax functions (taken from GRUB2 source code)

2013-04-11 Thread Andrey Borzenkov
В Thu, 11 Apr 2013 15:38:10 +0400 Vladimir Testov пишет: > functions currently included in grub2 source code. > (grub_min, grub_max) > > patch only for compatibility so someone could make grub2 binaries from > grub-2.00.tar.gz > Already in trunk. _

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-11 Thread Andrey Borzenkov
В Thu, 11 Apr 2013 19:48:35 +0400 Vladimir Testov пишет: > Like that? :) > > use > start_angle = "XXX degree" > or start_angle = "XXX degrees" I think "XXX deg" is enough. It avoids confusion with single/plural forms and we just need something to distinguish from plain number. Please add also

Re: [PATCH] fix autogen.sh on "dirty" tree

2013-04-10 Thread Andrey Borzenkov
В Tue, 9 Apr 2013 20:20:26 +0400 Andrey Borzenkov пишет: > for x in mpi-asm-defs.h mpih-add1.c mpih-sub1.c mpih-mul1.c mpih-mul2.c > mpih-mul3.c mpih-lshift.c mpih-rshift.c; do > -if [ -f grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then > +if [ -h grub-core/lib/

[PATCH] fix autogen.sh on "dirty" tree

2013-04-09 Thread Andrey Borzenkov
ady exists WARNING: grub-core/lib/libgcrypt-grub/src already exists ln: failed to create symbolic link 'grub-core/lib/libgcrypt-grub/mpi/mpih-add1.c': File exists These files are symbolic links, so was not caught by "test -f". Use "test -h". Signed-off-by: Andre

Re: [PATCH] fix menu size calculation in presence of selected item pixmap

2013-04-09 Thread Andrey Borzenkov
В Mon, 08 Apr 2013 20:51:17 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 21.02.2013 18:36, Andrey Borzenkov wrote: > > > draw_menu() acconted for upper border of selected item pixmap, but not > > for lower. So it could happen that lower border was vis

Re: [PATCH] add elfXX.c as extra_dist to grub-core/Makefile.core.def

2013-04-08 Thread Andrey Borzenkov
В Sun, 7 Apr 2013 00:22:33 +0400 Andrey Borzenkov пишет: > [ 327s] gcc -E -DGRUB_LST_GENERATOR -Dgrub_fs_register=FS_LIST_MARKER > -Dgrub_video_register=VIDEO_LIST_MARKER > -Dgrub_parttool_register=PARTTOOL_LIST_MARKER > -Dgrub_partition_map_register=PARTMAP

Re: Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.)

2013-04-08 Thread Andrey Borzenkov
В Mon, 08 Apr 2013 18:51:15 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 08.04.2013 18:40, Andrey Borzenkov wrote: > > > В Mon, 08 Apr 2013 18:34:27 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >> On 08.04.20

Re: Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.)

2013-04-08 Thread Andrey Borzenkov
В Mon, 08 Apr 2013 18:34:27 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 08.04.2013 17:51, Andrey Borzenkov wrote: > > > See http://susepaste.org/75296605 > > > > Notice that screen width is reported as 79. > > > > This is abs

Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.)

2013-04-08 Thread Andrey Borzenkov
See http://susepaste.org/75296605 Notice that screen width is reported as 79. This is absolutely reproducible with and without plymouth. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] fix entry editor screen screen layout corruption in trunk

2013-04-07 Thread Andrey Borzenkov
В Sun, 7 Apr 2013 22:50:29 +0400 Andrey Borzenkov пишет: > В Sun, 07 Apr 2013 17:49:09 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > On 07.04.2013 14:26, Andrey Borzenkov wrote: > > > > > В Wed, 03 Apr 2013 15:22:31 +0200 > >

Re: [PATCH] reimplement grub-reboot to nor depend on GRUB_DEFAULT=saved

2013-04-07 Thread Andrey Borzenkov
В Sat, 06 Apr 2013 21:52:15 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 30.01.2013 10:08, Andrey Borzenkov wrote: > > > + savenev next_entry > > + savenev next_entry > > Have you actually tested this patch? This is not a correct comand n

Re: [PATCH] 30_os-prober: add $onstr ot top level Linux entries too

2013-04-06 Thread Andrey Borzenkov
В Sat, 06 Apr 2013 21:39:24 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 05.04.2013 09:30, Andrey Borzenkov wrote: > > > This fixes two issues > > > > 1. It visually distinguishes between multiple installations of the > > same OS version. Cu

Re: autogen.sh from bzr failed : configure.ac:382: error: expected source file, required through AC_LIBSOURCES, not found

2013-04-06 Thread Andrey Borzenkov
В Sun, 07 Apr 2013 00:04:08 -0400 Daniel Kahn Gillmor пишет: > hi grub folk-- > > I'm trying to build grub from the current bzr head on a powerpc64 debian > unstable system. I'm afraid i'm getting stuck right at the beginning, > as i try to autogen: > > 0 dkg@reason:~/src/grub/grub$ ./autogen.

[PATCH] add elfXX.c as extra_dist to grub-core/Makefile.core.def

2013-04-06 Thread Andrey Borzenkov
./../grub-core -I.. -I../.. -I../../include -I../include -I../../grub-core/lib/libgcrypt-grub/include -I../../grub-core/lib/libgcrypt-grub/src/ ../../grub-core/kern/elf.c > elf.marker.new || (rm -f elf.marker; exit 1) [ 327s] ../../grub-core/kern/elf.c:132:19: fatal error: elfXX.c: No such file

Re: [PATCH] Fix prefix autodetection when booting from EFI CD-ROM

2013-04-05 Thread Andrey Borzenkov
В Fri, 05 Apr 2013 15:12:26 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 31.01.2013 13:24, Andrey Borzenkov wrote: > > > Fix autodetection of $prefix when booted from EFI CD-ROM. > > > > Based on patch from Matthew Garrett, modified to not overw

[PATCH] do not hardcode grub.mo in grub-install_header

2013-04-05 Thread Andrey Borzenkov
TEXTDOMAIN is set to @PACKAGE@ everywhere, use the same instead of hardcoding "grub.mo". Signed-off-by: Andrey Borzenkov --- ChangeLog| 5 + util/grub-install_header | 8 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/Chang

Re: [PATCH] make autogen.sh work on tardist again

2013-04-05 Thread Andrey Borzenkov
В Fri, 05 Apr 2013 13:48:34 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Please includew ChangeLog entry From: Andrey Borzenkov To: grub-devel@gnu.org Subject: [PATCH] make autogen.sh work on tardist again bor@opensuse:~/build/grub/foo/grub-2.00> ./autogen.sh I

[PATCH] make autogen.sh work on tardist again

2013-04-05 Thread Andrey Borzenkov
xists sed: ?? ??? util/import_gcrypth.sed: ??? ?? ? ??? Signed-off-by: Andrey Borzenkov --- conf/Makefile.extra-dist | 2 ++ 1 file changed, 2 insertions(+) diff --git a/conf/Makefile.extra-dist b/conf/Makefile.extra-dist index c862206..2e36500 100644 --- a/conf/Makef

Re: How do I find out what module is needed for a command?

2013-04-05 Thread Andrey Borzenkov
В Fri, 05 Apr 2013 12:28:37 +0200 Paul Menzel пишет: > Dear GRUB developers, > > > is there a program/script, which module I need to load to get a certain > command? Using my distribution `/boot/grub/grub.cfg` > /usr/lib/grub/i386-pc/command.lst replace i386-pc with your platform. >

Re: Command documentation part 1.

2013-04-05 Thread Andrey Borzenkov
В Fri, 05 Apr 2013 09:45:38 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > Yes. Could you send the patch as whole so I can commit it? > > From: Andrey Borzenkov Subject: [PATCH v4] document grub commands Add documentation for more grub commands. Signed-of

Re: Command documentation part 1.

2013-04-05 Thread Andrey Borzenkov
В Wed, 03 Apr 2013 11:11:44 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 30.03.2013 09:46, Andrey Borzenkov wrote: > > > В Tue, 26 Mar 2013 11:48:37 +0100 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >>> +@deffn Co

[PATCH] 30_os-prober: add $onstr ot top level Linux entries too

2013-04-05 Thread Andrey Borzenkov
as already appended to all other generated Linux menu entries. Signed-off-by: Andrey Borzenkov --- util/grub.d/30_os-prober.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in index bf47dc3..4cd45e8 100644 --- a/u

Re: [PATCH] suppress error message "/grub2/locale/en.mo.gz not found"

2013-04-05 Thread Andrey Borzenkov
В Tue, 25 Sep 2012 22:52:29 +0100 Colin Watson пишет: > On Mon, Sep 24, 2012 at 02:51:49PM +0800, Michael Chang wrote: > > We don't insert gettext module if message catalog file missing to > > prevent error message from being logged. > > I already posted a patch against the gettext module itself

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-04 Thread Andrey Borzenkov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 В Thu, 04 Apr 2013 15:02:13 -0400 Phillip Susi пишет: >Also you > appear to be using the now popular and vile reply-to-list function to > send replies only to the mailing list. Actually lis

Re: [PATCH] Make grub_efidisk_get_device_name() work on 4K native disks.

2013-04-04 Thread Andrey Borzenkov
В Thu, 4 Apr 2013 13:52:05 -0400 Peter Jones пишет: > On Wed, Apr 03, 2013 at 11:03:46PM +0400, Andrey Borzenkov wrote: > > В Wed, 3 Apr 2013 11:53:06 -0400 > > Peter Jones пишет: > > > > > When we have 4kB sectors instead of 512b sectors, hd.partition_start and

Re: [PATCH] Make grub_efidisk_get_device_name() work on 4K native disks.

2013-04-03 Thread Andrey Borzenkov
В Wed, 3 Apr 2013 11:53:06 -0400 Peter Jones пишет: > When we have 4kB sectors instead of 512b sectors, hd.partition_start and > grub_partition_get_start() won't match - the latter assumes 512-byte > sectors, and the former gives us the correct number based on the > physical media's sector size.

[PATCH] Re: Grub verify module failed to verify a signed file

2013-03-31 Thread Andrey Borzenkov
В Sun, 31 Mar 2013 17:38:58 +0400 Andrey Borzenkov пишет: > В Sun, 31 Mar 2013 14:25:35 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > Only DSA is supported for now and your key is RSA. > > > > I have exactly the same problem with DSA key:

Re: Grub verify module failed to verify a signed file

2013-03-31 Thread Andrey Borzenkov
В Sun, 31 Mar 2013 14:25:35 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Only DSA is supported for now and your key is RSA. > I have exactly the same problem with DSA key: bor@opensuse:~> gpg --list-keys DA5DF78C pub 1024D/DA5DF78C 2002-02-07 uid

Re: Grub verify module failed to verify a signed file

2013-03-30 Thread Andrey Borzenkov
В Thu, 28 Mar 2013 16:15:09 -0700 Wei Hu пишет: > Hi, > > I am trying to use the grub verify module to verify a detached signature I > signed using gpg on Linux. I did two different signings. Both of them failed, > but at the different places in grub_verify_signature(). I am wonder if I did >

Re: Command documentation part 1.

2013-03-30 Thread Andrey Borzenkov
В Tue, 26 Mar 2013 11:48:37 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > +@deffn Command background_color color > > +Set background color for active terminal. For valid color specifications > > see > > +@pxref{Theme file format, ,Colors}. Background color can be changed only > > when

[PATCH] reset LC_MESSAGES to C too

2013-03-30 Thread Andrey Borzenkov
`/home/bor/build/grub' The reason is, grub Makefile resets LC_CTYPE to C. This makes it impossible to translate messages into current locale (C at the time tools are running). Reset LC_MESSAGES to C as well, it is better to have them in English than do not have them at all. Problem obs

GRUB_CRYPTODISK_ENABLE undocumented

2013-03-29 Thread Andrey Borzenkov
Is it intentional? I hit it when testing grub on encrypted partition. When no, I'll submit a patch. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: module to read uefi vars

2013-03-21 Thread Andrey Borzenkov
В Thu, 21 Mar 2013 15:59:04 -0600 Dany Flores пишет: > Hi to all in this list. > I don't know is something like this exist but I believe that not, I want > to create a new module/command to read uefi vars and convert the value into > vars that we can use in a script, > My question is

[PATCH] remove remaining refrence to deleted pit.c

2013-03-16 Thread Andrey Borzenkov
make[3]: Entering directory `/home/bor/build/grub/po' make[3]: *** No rule to make target `.././grub-core/kern/i386/pit.c', needed by `grub.pot-update'. Stop. Signed-off-by: Andrey Borzenkov --- ChangeLog |4 po/POTFILES.in |1 - 2 files changed, 4 insertions

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-03-15 Thread Andrey Borzenkov
В Wed, 13 Mar 2013 14:52:13 +0400 Vladimir Testov пишет: > In current state, start angle is measured in "parrots", where 1 "parrot" = 1 > / > 256 of full circle. > > With simple patch we can set start angle in degrees (which makes no > difference > for the program, but makes configuration to

Re: USB3 3TB HDD boot

2013-03-14 Thread Andrey Borzenkov
В Thu, 14 Mar 2013 20:18:46 -0600 Chris Murphy пишет: > > On Mar 5, 2013, at 12:22 AM, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: > > > On 05.03.2013 00:16, Chris Murphy wrote: > > > >> > >> On Mar 4, 2013, at 12:43 PM, "Lennart Sorensen" > >> wrote: > >> > >>> On Mon, Mar 04, 2013 a

Re: Command documentation part 1.

2013-03-10 Thread Andrey Borzenkov
t be shown immediately. > > @end deffn > > > > > > +@node test > > +@subsection test > > + > > +@deffn Command test expression > > +Evaluate @var{expression} and return zero exit status if result is true, > > +non zero status otherwise. >

Re: [PATCH] Ignore symlink traversal failures in grub-mount readdir

2013-03-09 Thread Andrey Borzenkov
sting to work again. I can extend it with info.is_link to return proper filetype to FUSE, but implementing full support needs adding readlink that is a separate topic. I tested it with ext4 and cpio and it works. Testing on more systems (in particular, NTFS, which is the only one with non-trivial ch

[PATCH] return failure from grub-mount if fuse_main failed

2013-03-09 Thread Andrey Borzenkov
value be correct. Ref: https://bugzilla.novell.com/show_bug.cgi?id=802983 Signed-off-by: Andrey Borzenkov --- ChangeLog |5 + util/grub-mount.c |5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3b4b3b4..bb9f431 100644 --- a

Re: Command documentation part 1.

2013-03-08 Thread Andrey Borzenkov
В Thu, 07 Mar 2013 12:06:56 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 24.02.2013 08:40, Andrey Borzenkov wrote: > > > > > @menu > > +* [:: Check file types and compare values > > * acpi::

Re: [PATCH] fixed progress_bar highlight_style box displaying

2013-03-07 Thread Andrey Borzenkov
В Thu, 07 Mar 2013 11:50:27 +0400 Vladimir Testov пишет: > Before - without patch. > After - with patch. > > bar_style and highlight_style - both set to different pixmap boxes with 9 > slices. > > Though the color scheme is not ideal, screenshots are demonstrating my idea. > > The differences

Re: [PATCH] fixed progress_bar highlight_style box displaying

2013-03-06 Thread Andrey Borzenkov
On Thu, Mar 7, 2013 at 8:29 AM, Vladimir Testov wrote: >>I am curious why would you need border elements. To me having left and > >>right padding sounds like being wrong for horizontal progress bar. It > >>draws something when there is zero content. > > Didn't get your idea. If we don't have borde

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-06 Thread Andrey Borzenkov
On Thu, Mar 7, 2013 at 8:22 AM, Vladimir Testov wrote: >>This loses original OOM error if it was returned. May be make it return > >>true/false and check if grub_errno is set on false. Not sure. > >> > >>Do you have any real problem to solve? I wonder if these errors are > >>visible to user at all

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-06 Thread Andrey Borzenkov
В Mon, 04 Mar 2013 15:27:51 +0400 Vladimir Testov пишет: > GRUB does not show errors about non-existing properties or wrong values. > property name and error hadling works only for global properties > > This patch fixes this misbehavior. > I find diff -p... generally more readable by providing

Re: [PATCH] fixed progress_bar highlight_style box displaying

2013-03-06 Thread Andrey Borzenkov
В Wed, 06 Mar 2013 17:08:16 +0400 Vladimir Testov пишет: > In current state we could not correctly use styled box for highlight_style. > > We could set only center slice for highlight_style. Otherwise highlighted > area > won't be correctly displayed. > > Patch included. I am curious why wou

[PATCH] add ext4 inode inline data support to grub2

2013-03-05 Thread Andrey Borzenkov
ned-off-by: Andrey Borzenkov --- grub-core/fs/ext2.c | 255 ++- 1 file changed, 214 insertions(+), 41 deletions(-) diff --git a/grub-core/fs/ext2.c b/grub-core/fs/ext2.c index 18429ac..7304891 100644 --- a/grub-core/fs/ext2.c +++ b/grub-core

[PATCH] remove always_inline from fs/iso9660.c, caused gcc error

2013-03-04 Thread Andrey Borzenkov
NESS FOR A PARTICULAR PURPOSE. Signed-off-by: Andrey Borzenkov --- ChangeLog |5 + grub-core/fs/iso9660.c |2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index cacba37..9cab5c7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2

Re: Console Resolution with GRUB2

2013-03-02 Thread Andrey Borzenkov
В Sat, 2 Mar 2013 01:56:32 -0500 "D.J.J. Ring, Jr." пишет: > Replacing the old linux kernel boot arg vga=791 (for example), kernel boot arg vga=791 still works as intended with grub2 so I am not sure what exactly you complain about. ___ Grub-devel ma

Re: Console Resolution with GRUB2

2013-03-01 Thread Andrey Borzenkov
В Fri, 1 Mar 2013 16:43:10 -0800 Jordan Uggla пишет: > > So if GRUB_GFXMODE=640x480 is not getting you what you want, then > you're not seeing a difference between grub legacy and grub2, you're > seeing a difference between older *kernels* and newer *kernels* with > technology like Kernel Mode S

Re: Console Resolution with GRUB2

2013-02-28 Thread Andrey Borzenkov
В Thu, 28 Feb 2013 18:13:47 -0600 Bruce Dubbs пишет: > D.J.J. Ring, Jr. wrote: > > Hello Bruce, > > > > The "problem" with this is that grub.cfg says "Do Not Edit this File". > > The reason it says this is that it is embedded in the script > grub-mkconfig. It overwrites the grub.cfg, but if yo

Re: Console Resolution with GRUB2

2013-02-28 Thread Andrey Borzenkov
В Thu, 28 Feb 2013 18:44:05 -0500 "D.J.J. Ring, Jr." пишет: > Hello Bruce, > > The "problem" with this is that grub.cfg says "Do Not Edit this File". > > Why cannot grub2 have an easy way to change console resolution? > info grub2 > Configuration > Simple configuration `GRUB_GFXMODE' Se

Re: Command documentation part 1.

2013-02-23 Thread Andrey Borzenkov
В Sat, 09 Feb 2013 12:48:19 +0100 Francesco Lavra пишет: Thank you for review! > Hi, > > On 01/29/2013 11:25 AM, Andrey Borzenkov wrote: > > В Tue, 22 Jan 2013 17:12:18 + > > Colin Watson пишет: > > > >> On Tue, Jan 22, 2013 at 05:08:51PM +0400,

Re: grub_efi_finish_boot_services not spec-compliant

2013-02-23 Thread Andrey Borzenkov
В Sat, 23 Feb 2013 20:35:17 -0800 Seth Goldberg пишет: > Hi there, > > On some systems, ExitBootServices() will fail due to a change in the memory > map during execution of the boot services call. The UEFI spec says that in > that event, GetMemoryMap() should be repeated, then the new key

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-21 Thread Andrey Borzenkov
Sorry for delay. В Thu, 07 Feb 2013 14:07:08 +0400 Vladimir Testov пишет: > >I am not sure whether it is appropriate fix. After your patch "box > >effect" on selected item is effectively lost (it makes > >selected_item_box the same height as selected item itself). > About "box effect" - there is

[PATCH] fix menu size calculation in presence of selected item pixmap

2013-02-21 Thread Andrey Borzenkov
draw_menu() acconted for upper border of selected item pixmap, but not for lower. So it could happen that lower border was visually cut off. Also various calculations of menu vertical size did not account for space for lower border Signed-off-by: Andrey Borzenkov --- grub-core/gfxmenu

[PATCH] fix last column in BIOS console

2013-02-21 Thread Andrey Borzenkov
documentation indicates that it is available since 1986, so I guess any system that exists today should implement it. Signed-off-by: Andrey Borzenkov --- grub-core/term/i386/pc/console.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/grub-core/term/i386/pc

[PATCH] Fix unallocated memory access in insert_string

2013-02-19 Thread Andrey Borzenkov
When appending string at the end, there is nothing to shift down and (screen->line + 2) points beyond allocated array. Signed-off-by: Andrey Borzenkov --- ChangeLog |5 + grub-core/normal/menu_entry.c | 11 ++- 2 files changed, 11 insertions(+)

[PATCH] Fix stuck down arrow in menu entry editor

2013-02-19 Thread Andrey Borzenkov
Variable `off' was never incremented so down arrow was always printed, even when we have scrolled to the end of entry. Signed-off-by: Andrey Borzenkov --- ChangeLog |5 + grub-core/normal/menu_entry.c |3 +-- 2 files changed, 6 insertions(+), 2 dele

Re: GRUB and the risk of block list corruption in extX

2013-02-18 Thread Andrey Borzenkov
On Thu, Feb 7, 2013 at 2:47 PM, Martin Wilck wrote: > Hello, > Hi Martin > this is a question about the long-running topic of installing GRUB in > partitions or partitionless disks. > > Recently I have been involved in discussions about this on > https://bugzilla.redhat.com/show_bug.cgi?id=872826

Re: GRUB and the risk of block list corruption in extX

2013-02-18 Thread Andrey Borzenkov
On Tue, Feb 19, 2013 at 1:07 AM, Chris Murphy wrote: > > Chainloading was never a good idea, it was the only idea for supporting > multiboot on hardware with a brain dead BIOS that was never designed with > multiboot in mind. > Chainloading is actually the only sane way to do multiboot. While i

[PATCH] fix entry editor screen screen layout corruption in trunk

2013-02-17 Thread Andrey Borzenkov
See screenshot for what I get using current trunk. I do not pretend to fully understand all this code so review is appreciated. So far it does fix both gfxterm and console cases for me. Patch follows. --- From: Andrey Borzenkov Subject: [PATCH] fix entry editor screen corruption Fixes the

Re: GRUB and the risk of block list corruption in extX

2013-02-08 Thread Andrey Borzenkov
В Fri, 8 Feb 2013 13:58:36 -0500 "Lennart Sorensen" пишет: > On Fri, Feb 08, 2013 at 12:56:52PM -0600, Bruce Dubbs wrote: > > You don't need an EFI system to give GRUB enough space. You just > > need to partition the drive so the first partition starts at 1MB > > instead of sector 63. I think u

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-06 Thread Andrey Borzenkov
В Tue, 5 Feb 2013 19:44:14 +0300 (MSK) Vladimir Testov пишет: > I'm going to write some patches for GRUB2 - mainly for theme handling. > > First one - I've faced some bug: maximum number of displayed boot elements is > counted in presumption that element's height is item_height and distance >

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-05 Thread Andrey Borzenkov
В Tue, 5 Feb 2013 23:21:05 +0300 (MSK) Vladimir Testov пишет: > Sorry, misprint. Should be "horizontal_pad" rather than "vertical_pad" in the > patch included. > Could you resend it without unrelated white space changes? ___ Grub-devel mailing list

Re: for ppc, include all modules in the core image

2013-02-01 Thread Andrey Borzenkov
В Mon, 22 Oct 2012 19:53:17 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 22.10.2012 19:30, Paulo Flabiano Smorigo/Brazil/IBM wrote: > > > > > Quoting Vladimir 'φ-coder/phcoder' Serbinenko : > > > >> On 16.10.2012 12:28, Paulo Flabiano Smorigo/Brazil/IBM wrote: > >> > >>> Hi all! > >

Re: DSA GnuPG signatures

2013-01-31 Thread Andrey Borzenkov
В Fri, 11 Jan 2013 21:54:22 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > Hello, all. I've just committed import of libgcrypt and implementation > of related code to check signatures. Short usage: > verify_detached FILE FILE.sig [pubkey.gpg] > trust KEY.gpg > distruct KEYID > check_signatu

[PATCH] Fix prefix autodetection when booting from EFI CD-ROM

2013-01-31 Thread Andrey Borzenkov
found. Signed-off-by: Andrey Borzenkov --- grub-core/disk/efi/efidisk.c | 121 +++--- 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c index 98cd226..15c8109 100644 --- a/grub-core/disk

<    1   2   3   4   5   6   >