[PATCH] mkdevicemap for Cygwin

2007-11-13 Thread Christian Franke
Some changes for grub-mkdevicemap on Cygwin. Christian 2007-11-13 Christian Franke [EMAIL PROTECTED] * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin device names. (get_ide_disk_name): Disable on __CYGWIN__. (get_scsi_disk_name): Add Cygwin device

Re: [PATCH] Avoid crash on empty menu

2007-11-10 Thread Christian Franke
Marco Gerards wrote: + e = get_entry (menu, boot_entry); + if (! e) + continue; /* menu is empty */ Please use proper interpunctions for comments. Fixed. Christian 2007-11-10 Christian Franke [EMAIL PROTECTED] * normal/menu.c (run_menu): Check

Re: [PATCH] Fix grub-emu curses KEY_* mapping

2007-11-10 Thread Christian Franke
Marco Gerards wrote: Christian Franke [EMAIL PROTECTED] writes: Curses function keys do not work in grub-emu, this patch fixes this in grub_ncurses_getkey(). Ha! I once noticed this and forgot to document this bug :( Another approach would be to remove the scancode translation

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Christian Franke
Marco Gerards wrote: .. 2007-10-25 Christian Franke [EMAIL PROTECTED] * disk/host.c (grub_host_open): Add check for host. This fixes the problem that grub-emu does not find partitions. Please mention the attribute change. ... static grub_err_t -grub_host_open

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Christian Franke
Robert Millan wrote: On Fri, Nov 09, 2007 at 10:17:19PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote: static grub_err_t -grub_host_open (const char *name __attribute((unused)), grub_disk_t

Re: [PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-11-10 Thread Christian Franke
Marco Gerards wrote: ... 2007-11-09 Christian Franke [EMAIL PROTECTED] * util/hostfs.c (is_dir): New function. (grub_hostfs_dir): Handle missing dirent.d_type case. (grub_hostfs_read): Add missing fseek(). (grub_hostfs_label): Clear label pointer. This fixes

[PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE)

2007-11-10 Thread Christian Franke
/finit search for modules converted from non-ELF format (which do not support the function symbol type). A bug in symbol table scan is fixed. Christian 2007-11-10 Christian Franke [EMAIL PROTECTED] * genkernsyms.sh.in: Handle HAVE_ASM_USCORE case. * genmk.rb: Handle

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2007-11-10 Thread Christian Franke
Marco Gerards wrote: Christian Franke [EMAIL PROTECTED] writes: ... volatile is necessary here to tell the complier that the memory address might not behave like regular memory. Otherwise, the optimizer might legitimately remove memory accesses and then constant propagation detects

Re: [PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-11-09 Thread Christian Franke
= initialization) style, which is state of the art in most (all?) modern languages. This C++ (1986) feature and early GCC (1.*) extension was finally included into C99, so it is portable now. is_dir() rewritten accordingly. Christian 2007-11-09 Christian Franke [EMAIL PROTECTED] * util/hostfs.c

Re: [PATCH] grub-probe -t prefix, -t all

2007-11-09 Thread Christian Franke
Robert Millan wrote: On Mon, Oct 29, 2007 at 09:20:00PM +0100, Christian Franke wrote: This patch adds '-t prefix', '-t all', and allows multiple -t options to be specified. '-t prefix' was initially added to test grub_get_prefix() on Cygwin, but may be useful in scripts. What does

Re: [PATCH] grub-probe -t prefix, -t all

2007-11-09 Thread Christian Franke
Robert Millan wrote: ... Note that make_system_path_relative_to_its_root() actually exists :-/ Sorry, I didn't search update-grub_lib.in :-\ Apparently both grub_get_prefix() and make_system_path_relative_to_its_root() use the same algorithm. Both do not work on Cygwin due to special

[PATCH] Avoid crash on empty menu

2007-11-07 Thread Christian Franke
(and produce this leak) if the file is missing. An error message should IMO be printed instead. - The sequence c - rescue - normal appends the same entries to the existing menu, because the old entry is reused from menu data slot. Thanks for any comment. Christian 2007-11-07 Christian Franke [EMAIL

Re: [PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-11-02 Thread Christian Franke
Second version of the patch. It fixes another bug: missing fseek() in grub_hostfs_read(). Christian 2007-11-02 Christian Franke [EMAIL PROTECTED] * util/hostfs.c (is_dir): New function. (grub_hostfs_dir): Handle missing dirent.d_type case. (grub_hostfs_read): Add

[PATCH] Fix grub-emu curses KEY_* mapping

2007-11-02 Thread Christian Franke
platform specific. Christian 2007-11-02 Christian Franke [EMAIL PROTECTED] * util/console.c (grub_ncurses_getkey): Change curses KEY_* mapping, now return control chars instead of GRUB_CONSOLE_KEY_* constants. This fixes the problem that function keys did not work

[PATCH] grub-probe -t prefix, -t all

2007-10-29 Thread Christian Franke
This patch adds '-t prefix', '-t all', and allows multiple -t options to be specified. '-t prefix' was initially added to test grub_get_prefix() on Cygwin, but may be useful in scripts. Christian 2007-10-29 Christian Franke [EMAIL PROTECTED] * util/grub-probe.c (#define PRINT_

[PATCH] Add host open devicename check

2007-10-25 Thread Christian Franke
grub-emu ls command does not list any partitions. Device scan in grub_disk_open() stops early because grub_host_open() returns success on all device names. Christian 2007-10-25 Christian Franke [EMAIL PROTECTED] * disk/host.c (grub_host_open): Add check for host. This fixes

Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-10-23 Thread Christian Franke
Robert Millan wrote: ... +/* Compile time assert to check packing */ +typedef char ASSERT_sizeof_grub_machine_mmap_entry[ + sizeof (struct grub_machine_mmap_entry) == 4+8+8+4 ? 1 : -1]; Nice, I didn't know you could do compile time assertion in C. But is it really necessary to check

[PATCH] Fix eisa_mmap evaluation, add memory existence check

2007-10-23 Thread Christian Franke
not necessary. Regions are merged a few lines later. During testing, I added a primitive memory to detect such problems early. It was difficult to find why grub crashes during module load. Christian 2007-10-23 Christian Franke [EMAIL PROTECTED] * kern/i386/pc/init.c (addr_is_valid

[PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-10-23 Thread Christian Franke
fixes a grub-emu crash. Christian 2007-10-23 Christian Franke [EMAIL PROTECTED] * util/hostfs.c (is_dir): New function. (grub_hostfs_dir): Handle missing dirent.d_type case. (grub_hostfs_label): Clear label pointer. This fixes a crash of grub-emu on ls (host

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2007-10-23 Thread Christian Franke
Robert Millan wrote: On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote: This patch fixes the broken evaluation of the E801 EISA memory map. The shift was too much, the high word is already shifted :-) The bug was hidden until the E820 memory map evaluation was broken due

[PATCH] Fix packing issue of machine_mmap_entry

2007-10-22 Thread Christian Franke
First patch related to the Cygwin port: struct machine_mmap_entry is sensitive to packing of 64 bit values which apparently differs between gcc releases. Christian 2007-10-22 Christian Franke [EMAIL PROTECTED] * include/grub/i386/pc/init.h (struct grub_machine_mmap_entry

Re: [PATCH] grub2 for Cygwin

2007-10-21 Thread Christian Franke
Robert Millan wrote: On Tue, Oct 16, 2007 at 02:03:35PM +0200, Christian Franke wrote: A patch vs. current CVS (cvs co -D 2007-10-16 UTC ...) is available here: http://franke.dvrdns.org/cygwin/grub/grub2-20071016-cygwin.patch A proposed changelog entry is located in the patch itself

Re: [PATCH] grub2 for Cygwin

2007-10-21 Thread Christian Franke
Vesa Jääskeläinen wrote: Christian Franke wrote: Robert Millan wrote: On Tue, Oct 16, 2007 at 02:03:35PM +0200, Christian Franke wrote: Could you send it as an attachment? This way it's easier to comment on it contextualy. I didn't want to send a ~45KB attachment in my

Re: [PATCH] startup.S does not find includes

2007-10-21 Thread Christian Franke
Robert Millan wrote: On Sun, Oct 21, 2007 at 06:56:21PM +0200, Christian Franke wrote: Hi, some recent checkin appearently introduces the following regression: Compilation fails if configure'd outside of $(srcdir). #include kern/i386/realmode.S and kern/i386/loader.S fail in startup.S

[PATCH] grub2 for Cygwin

2007-10-16 Thread Christian Franke
Hi, I would like to contribute my Cygwin port of grub2. A patch vs. current CVS (cvs co -D 2007-10-16 UTC ...) is available here: http://franke.dvrdns.org/cygwin/grub/grub2-20071016-cygwin.patch A proposed changelog entry is located in the patch itself (Changelog.cygwin). A compiled version is

<    1   2   3