RE: [PATCH] util: Detect more I/O errors

2019-02-28 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Grub-devel On > Behalf Of Colin Watson > Sent: Wednesday, February 27, 2019 3:10 AM > Subject: [PATCH] util: Detect more I/O errors > ... > -void > +int > grub_util_file_sync (FILE *f) > { > - fflush (f); > + if (fflush (f) != 0) > +return -1; >

RE: [PATCH] efi: Free malloc regions on exit

2016-05-23 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Grub-devel [mailto:grub-devel-bounces+elliott=hpe@gnu.org] > On Behalf Of Alexander Graf > Sent: Thursday, May 19, 2016 8:38 AM > Subject: [PATCH] efi: Free malloc regions on exit ... > +struct efi_allocation { If no other file is using this, mark it as

[PATCH] debug mmap: print actual ending addresses

2016-05-06 Thread Elliott, Robert (Persistent Memory)
For debug=mmap, print the actual ending address of each region rather than the address after the ending address. This matches the lsmmap and lsefimmap command outputs. Old: mmap/efi/mmap.c:66: EFI memory region 0x168000-0x1c8000: 0 lsefimmap output: reserved

build error - grub_crypto_get_random in xnu

2016-03-28 Thread Elliott, Robert (Persistent Memory)
After patch 22aa31bcc33, I get this build error: mv syminfo.lst.new syminfo.lst cat syminfo.lst | sort | gawk -f ./genmoddep.awk > moddep.lst || (rm -f moddep.lst; exit 1) grub_crypto_get_random in xnu is not defined Makefile:42418: recipe for target 'moddep.lst' failed make[3]: *** [moddep.lst]

RE: [PATCH v2 3/3] disk: read into cache directly

2016-03-02 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Leif Lindholm > Sent: Tuesday, March 01, 2016 6:14 PM > To: grub-devel@gnu.org > Subject: [PATCH v2 3/3] disk: read into cache directly > > From:

RE: [PATCH v2] lsefimmap: support persistent memory and other UEFI 2.5 features

2015-12-18 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Andrei Borzenkov > Sent: Thursday, December 17, 2015 12:06 PM > To: grub-devel@gnu.org > Subject: Re: [PATCH v2] lsefimmap: support persistent memory

RE: [PATCH v2] Translate UEFI persistent memory type

2015-12-15 Thread Elliott, Robert (Persistent Memory)
Re: [PATCH v2] Translate UEFI persistent memory type > > 14.12.2015 03:41, Elliott, Robert (Persistent Memory) пишет: > > Per the thread: > > grub causing NVDIMMs to be treated as normal memory > > > > > > Robert Elliott (3): > > Translate UEFI persiste

[PATCH v2] Translate UEFI persistent memory type

2015-12-13 Thread Elliott, Robert (Persistent Memory)
Per the thread: grub causing NVDIMMs to be treated as normal memory Robert Elliott (3): Translate UEFI persistent memory type efiemu: Handle all reserved UEFI memory map types the same way Bump version to 2.03 NEWS| 20 configure.ac

RE: grub causing NVDIMMs to be treated as normal memory

2015-12-08 Thread Elliott, Robert (Persistent Memory)
treated as normal memory > > 03.12.2015 20:50, Elliott, Robert (Persistent Memory) пишет: > > From bd13098e80422444d60e08cb856093bf671df2bf Mon Sep 17 00:00:00 > 2001 > > From: Robert Elliott <elli...@hpe.com> > > Date: Thu, 3 Dec 2015 11:38:36 -0600 > > S

RE: grub causing NVDIMMs to be treated as normal memory

2015-12-03 Thread Elliott, Robert (Persistent Memory)
> > -Original Message- > > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > > bounces+elliott=hp@gnu.org] On Behalf Of Vladimir 'f- > > coder/phcoder' Serbinenko > > Sent: Friday, November 27, 2015 5:08 AM > > To: The development of GNU GRUB >

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-30 Thread Elliott, Robert (Persistent Memory)
> grub-core/efiemu/mm.c: > * efiemu_alloc_requests reqorder[] - add GRUB_EFI_PERSISTENT_MEMORY > (although we don't want to encourage ever allocating these >ranges, UNUSABLE_MEMORY is already there) Reviewing that code, since this array has one entry per EFI memory type: static grub_size_t

RE: [PATCH] calibrate_tsc(): use the Stall() EFI boot service on GRUB_MACHINE_EFI

2015-11-27 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Andrei Borzenkov > Sent: Friday, November 27, 2015 11:56 AM > To: The development of GNU GRUB ; > vkuzn...@redhat.com;

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-27 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: grub-devel-bounces+elliott=hp@gnu.org [mailto:grub-devel- > bounces+elliott=hp@gnu.org] On Behalf Of Vladimir 'f- > coder/phcoder' Serbinenko > Sent: Friday, November 27, 2015 5:08 AM > To: The development of GNU GRUB > Subject:

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Andrei Borzenkov [mailto:arvidj...@gmail.com] > Sent: Thursday, November 26, 2015 10:55 AM > To: Elliott, Robert (Persistent Memory) <elli...@hpe.com>; The > development of GNU GRUB <grub-devel@gnu.org>; > dan.j.willi...@intel.

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-26 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Andrei Borzenkov [mailto:arvidj...@gmail.com] > Sent: Thursday, November 26, 2015 9:58 PM > To: Elliott, Robert (Persistent Memory) <elli...@hpe.com>; The > development of GNU GRUB <grub-devel@gnu.org>; > dan.j.willi...@intel.

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
sts.01.org > Subject: Re: grub causing NVDIMMs to be treated as normal memory > > 25.11.2015 02:52, Elliott, Robert (Persistent Memory) пишет: > > We've noticed that some combinations of grub and old linux kernels > > > > end up interpreting the UEFI memory map EfiPers

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
t: Re: grub causing NVDIMMs to be treated as normal memory > > On Wed, Nov 25, 2015 at 2:52 AM, Elliott, Robert (Persistent Memory) > <elli...@hpe.com> wrote: > > We've noticed that some combinations of grub and old linux kernels > > end up interpreting the UEFI memory ma

RE: grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Andrei Borzenkov [mailto:arvidj...@gmail.com] ... > From the build directory > > pkgdatadir=$PWD ./grub-install --bootloader-id testgrub -d grub-core > > This should install grub in \EFI\testgrub on ESP and add EFI menu for > it. You can add --no-nvram to

grub causing NVDIMMs to be treated as normal memory

2015-11-25 Thread Elliott, Robert (Persistent Memory)
We've noticed that some combinations of grub and old linux kernels end up interpreting the UEFI memory map EfiPersistentMemory type 14 (formerly a reserved value) as regular memory in the linux e820 table, causing silent data corruption on the NVDIMMs. That occurs even though grub prints this