Make use of this new keyword in the bli module definition.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
v2:
- fix out-of-source builds
.gitignore | 1 -
conf/Makefile.common| 1 +
gentpl.py | 7 +++
grub-core/Makefile.am | 9
gt; Fixes: 154dcb1ae (build: Allow explicit module dependencies)
> >
> > Signed-off-by: Oskari Pirhonen
>
> Reviewed-by: Daniel Kiper
>
> Daniel
>
I had assumed that this went in already.
I think this is OK if we want the simple solution.
For
Make use of this new keyword in the bli module definition.
Signed-off-by: Oliver Steffen
---
.gitignore | 1 -
conf/Makefile.common| 1 +
gentpl.py | 7 +++
grub-core/Makefile.am | 7 +--
grub-core/Makefile.core.def | 1 +
grub-core/extra_dep
Quoting Olaf Hering (2023-12-21 11:50:49)
> Thu, 21 Dec 2023 02:42:46 -0800 Oliver Steffen :
>
> > Although its name suggests that it is a generated file (.lst ending!),
> > extra_deps.lst is actually tracked in git and is not generated by the
> > build system.
>
> I
Quoting Oskari Pirhonen (2023-12-21 08:17:35)
> Fixes build failure due to the extra_deps.lst file not existing in the
> tarball. Found while trying to package GRUB 2.12 for Gentoo.
>
> make[3]: *** No rule to make target
>
Quoting Olaf Hering (2023-12-21 10:12:24)
> Thu, 21 Dec 2023 01:17:35 -0600 Oskari Pirhonen :
>
> > Fixes build failure due to the extra_deps.lst file not existing in the
> > tarball.
>
> Maybe maybe maybe this is another slight hint that this file needs to be
> generated at build time, like all
Quoting Julian Andres Klode (2023-12-08 18:29:52)
> On Fri, Dec 08, 2023 at 01:20:37PM +0100, Daniel Kiper wrote:
> > On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote:
> > > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote:
> > > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper
Quoting Mate Kukri (2023-12-08 18:20:12)
> 154dcb1aea9f8fc42b2bce98bebed004d7783a7d broke out of tree builds by
> introducing the extra_deps.lst file into the source tree but referencing
> it just by name in grub-core/Makefile.am.
>
> Signed-off-by: Mate Kukri
> ---
> grub-core/Makefile.am | 4
oot Loader Interface specification, which bli aims to
implement, requires GPT formatted drives. The bli module ignores all
other partition formats.
Signed-off-by: Oliver Steffen
---
grub-core/extra_deps.lst | 1 +
1 file changed, 1 insertion(+)
diff --git a/grub-core/extra_deps.lst b/grub-core/extr
are set to be ignored by git, add an exception for
extra_deps.lst.
Additionally, introduce a new keyword for the syminfo.lst syntax:
"depends" allows specifying a module dependency directly:
depends ...
Signed-off-by: Oliver Steffen
---
.gitignore | 1 +
grub-core/M
rub-devel/2023-11/msg00077.html
[2] https://mail.gnu.org/archive/html/grub-devel/2023-11/msg00096.html
Oliver Steffen (3):
Allow explicit module dependencies
bli: Add explicit dependency on the part_gpt module
bli: Improve documentation
.gitignore | 1 +
docs/grub.texi |
Improve the documentation of the bli module, explain in more detail what
it does. Make clear that GPT formatted drives are expected and other
partition formats are ignored.
Also reorder and reword this section a bit.
Signed-off-by: Oliver Steffen
---
docs/grub.texi | 17 +
1
explicit_dependencies.lst -> extra_deps.lst
- explain what bli does/why it needs part_gpt in the commit message
- and in the module documentation as well.
[1] https://mail.gnu.org/archive/html/grub-devel/2023-11/msg00077.html
Oliver Steffen (3):
Allow explicit module dependencies
bli:
, introduce a new keyword for the syminfo.lst syntax:
"depends" allows specifying a module dependency directly:
depends ...
Signed-off-by: Oliver Steffen
---
grub-core/Makefile.am| 4 ++--
grub-core/extra_deps.lst | 0
grub-core/genmoddep.awk | 4
3 files changed, 6 insert
Improve the documentation of the bli module, explain in more detail what
it does. Make clear that GPT formatted drives are expected and other
partition formats are ignored.
Also reorder and reword this section a bit.
Signed-off-by: Oliver Steffen
---
docs/grub.texi | 17 +
1
oot Loader Interface specification, which bli aims to
implement, requires GPT formatted drives. The bli module ignores all
other partition formats.
Signed-off-by: Oliver Steffen
---
grub-core/extra_deps.lst | 1 +
1 file changed, 1 insertion(+)
diff --git a/grub-core/extra_deps.lst b/grub-core/extr
Quoting Daniel Kiper (2023-11-15 15:14:50)
> On Wed, Nov 15, 2023 at 03:12:44AM -0800, Oliver Steffen wrote:
> > Quoting Vladimir 'phcoder' Serbinenko (2023-11-14 19:21:49)
> > > In general series looks good. Few comments:
> > > * I'm unsure about the name. It seems
is not GPT or otherwise not reachable, then it does not
set the corresponding EFI variable, but c
> Le mar. 14 nov. 2023, 17:45, Oliver Steffen a écrit :
>
> The bli module has a hidden/implicit dependency on the part_gpt module.
> The part_gpt module has to be loaded before the b
.
Additionally, introduce a new keyword for the syminfo.lst syntax:
"depends" allows specifying a module dependency directly:
depends ...
Signed-off-by: Oliver Steffen
---
grub-core/Makefile.am | 4 ++--
grub-core/explicit_dependencies.lst | 0
grub-core/genmoddep.awk
to parse GPT formatted disks.
This series introduces a mechanism that allows specifying module
dependencies explicitly in a new file called explicit_dependencies.lst.
An explicit dependency is then added for the bli module on the part_gpt
module.
Oliver Steffen (2):
Allow explicit module
ed is also important:
part_gpt needs to be loaded before the bli module.
To solve this, track this dependency explicitly.
Signed-off-by: Oliver Steffen
---
grub-core/explicit_dependencies.lst | 1 +
1 file changed, 1 insertion(+)
diff --git a/grub-core/explicit_dependencies.lst
b
to get the partition UUID of the ESP.
Adding this dummy call to bli.c causes part_gpt to appear as a
dependency:
(void) grub_gpt_partition_map_iterate (NULL, NULL, NULL);
Thanks, I understand the problem now.
Oliver
> > On 4 Oct 2023, at 8:31 pm, Oliver Steffen wrote:
> >
> &
Signed-off-by: Oliver Steffen
---
grub-core/commands/acpi.c| 4 +-
grub-core/commands/bli.c | 2 +-
grub-core/commands/efi/efifwsetup.c | 4 +-
grub-core/commands/efi/loadbios.c| 14 +++---
grub-core/commands/efi/lsefi.c | 4 +-
grub-core/commands/efi/lsefisys
.html
[5] https://mail.gnu.org/archive/html/grub-devel/2023-08/msg00030.html
[6] https://mail.gnu.org/archive/html/grub-devel/2023-09/msg00093.html
[7] https://mail.gnu.org/archive/html/grub-devel/2023-10/msg0.html
Oliver Steffen (4):
bli: don't use %pG format specifier
Revert "guid: Mak
This reverts commit f82dbf2bd871e9cce327b511a393ffa543d7f69e.
Signed-off-by: Oliver Steffen
---
grub-core/kern/misc.c | 81 +++
1 file changed, 21 insertions(+), 60 deletions(-)
diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
index b57249acb
We are about to revert the unified GUID type and it's printf format
specifier, so do use the explicit printf statement for the partition
UUID here instread.
Signed-off-by: Oliver Steffen
---
grub-core/commands/bli.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
This reverts commit 6ad116e5ff459ae06eb993d386da5e7589242667.
Signed-off-by: Oliver Steffen
---
grub-core/commands/efi/lsefi.c | 13 -
grub-core/commands/efi/lsefisystab.c | 6 +-
grub-core/commands/probe.c | 12
grub-core/kern/efi/efi.c
on
GUIDs after the release.
Oliver
Quoting Oliver Steffen (2023-09-13 13:48:21)
> On Wed, Sep 13, 2023 at 1:43 PM Ard Biesheuvel wrote:
> >
> > On Wed, 13 Sept 2023 at 13:42, Vladimir 'phcoder' Serbinenko
> > wrote:
> > >
> > >
> > >
> > &
Hi,
Is there a way to specify dependencies for a module? As in a list of
other modules that need to be loaded before?
I found a macro named GRUB_MOD_DEP in dh.h, but when I use it in the
module's .c file I get errors about a missing .moddeps section. It also
does not seem to be in use anywhere.
Quoting Oliver Steffen (2023-10-02 10:28:08)
> On Sun, Oct 1, 2023 at 4:08 PM Tobias Powalowski
> wrote:
> >
> > Am 27.09.23 um 09:43 schrieb Oliver Steffen:
> > > Quoting Daniel Kiper (2023-09-26 17:57:05)
> > >> On Sat, Aug 12, 2023 at 03:01:19PM +0200, T
On Mon, Oct 2, 2023 at 6:54 AM Tobias Powalowski
wrote:
>
> Am 27.09.23 um 09:43 schrieb Oliver Steffen:
> > Quoting Daniel Kiper (2023-09-26 17:57:05)
> >> On Sat, Aug 12, 2023 at 03:01:19PM +0200, Tobias Powalowski via Grub-devel
> >> wrote:
> >>> A
On Sun, Oct 1, 2023 at 4:08 PM Tobias Powalowski
wrote:
>
> Am 27.09.23 um 09:43 schrieb Oliver Steffen:
> > Quoting Daniel Kiper (2023-09-26 17:57:05)
> >> On Sat, Aug 12, 2023 at 03:01:19PM +0200, Tobias Powalowski via Grub-devel
> >> wrote:
> >>> A
Quoting Daniel Kiper (2023-09-26 17:57:05)
> On Sat, Aug 12, 2023 at 03:01:19PM +0200, Tobias Powalowski via Grub-devel
> wrote:
> > Am 12.08.23 um 14:52 schrieb Oliver Steffen:
> > > Quoting Daniel Kiper (2023-08-11 18:13:57)
> > > > Hi,
> > > >
>
On Wed, Sep 13, 2023 at 12:20 PM John Paul Adrian Glaubitz
wrote:
>
> Hi Oliver!
>
> On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote:
> > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote:
> > >
> > >
> > > I can confirm that,
Paul Adrian Glaubitz
> >> wrote:
> >> >
> >> > Hi Oliver!
> >> >
> >> > On Wed, 2023-09-13 at 12:14 +0200, Oliver Steffen wrote:
> >> > > On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo
> >> > > wrote:
&g
On Wed, Sep 13, 2023 at 6:10 AM Pedro Miguel Justo wrote:
>
>
> I can confirm that, taking [1][2] and making [3] on top of it, my
> Montvale-based rx2660 machine still boots fine.
Wonderful! Thanks for testing!
Oliver
>
> [1] - https://github.com/phcoder/GRUB.git
> [2] - cfa21b94e
> [3] :
>
>
Quoting Vladimir 'phcoder' Serbinenko (2023-08-15 18:14:11)
>
>
> Le mar. 15 août 2023, 14:00, Laszlo Ersek <[1]ler...@redhat.com> a écrit :
>
> On 8/15/23 10:17, Ard Biesheuvel wrote:
> > On Tue, 15 Aug 2023 at 05:42, Vladimir 'phcoder' Serbinenko
> > <[2]phco...@gmail.com> wrote:
>
glaub...@physik.fu-berlin.de> wrote:
> >
> > Hi Daniel!
> >
> > On Fri, 2023-08-11 at 17:31 +0200, Daniel Kiper wrote:
> >> On Fri, Aug 11, 2023 at 04:10:14AM -0700, Oliver Steffen wrote:
> >>> Quoting Jo
l.com> a écrit :
>
>
>
> Le dim. 13 août 2023, 00:57, Pedro Miguel Justo <[6]
> pm...@texair.net> a écrit :
>
>
>
> > On Aug 12, 2023, at 11:04, John Paul Adrian Glaubitz
> <[7]
> glaub
erruptible
just after the line loading the bli module. This is to keep the
messages visible for a moment before the menu clears the screen (should
it get to there).
This might give us a hint where it goes wrong.
From cda95baaf0a3c0f277a5e37aff399574627b2263 Mon Sep 17 00:00:00 2001
From: Oliver St
Quoting John Paul Adrian Glaubitz (2023-08-11 10:32:17)
> Hi Oliver!
>
> On Fri, 2023-05-26 at 13:35 +0200, Oliver Steffen wrote:
> > There are 3 implementations of a GUID in Grub. Replace them with a
> > common one, placed in types.h.
> >
> > It uses the &q
li.in
> > > index 6e4538716..26e27a019 100644
> > > --- a/util/grub.d/25_bli.in
> > > +++ b/util/grub.d/25_bli.in
> > > @@ -1,4 +1,4 @@
> > > -#!/usr/bin/sh
> > > +#! /bin/sh
> > > set -e
> > >
> > > # grub-mkconfig helper scri
There are 3 implementations of a GUID in Grub. Replace them with a
common one, placed in types.h.
It uses the "packed" flavor of the GUID structs, the alignment attribute
is dropped, since it is not required.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-cor
, because it needs to be reachable from the
kern/efi code.
Add a check for integer overflow and remove redundant NUL-termination.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 21 ++---
grub-core/kern/misc.c| 32
Use the new printf format specifier %pG.
Fixes the text representation of GUIDs in the output of the lsefisystab
command (missing 4th dash).
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/commands/efi/lsefi.c | 13 +
grub-core/commands/efi
be the
bli module there.
[0] https://systemd.io/BOOT_LOADER_INTERFACE/
[1]
https://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html
[2]
https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
Signed-off-by: Oliver Steffen
---
docs
In the same way as GRUB_SIZE_MAX, add GRUB_SSIZE_MAX.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
include/grub/types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/grub/types.h b/include/grub/types.h
index c56ce9820..9f43a5580 100644
--- a/include/grub/types.h
Added config drop-in file that loads the module on EFI
v1:
- https://mail.gnu.org/archive/html/grub-devel/2023-01/msg00104.html
Oliver Steffen (11):
efi: Add grub_efi_set_variable_with_attributes()
Unify GUID types
kern/misc: Add a format specifier GUIDs
grub-core: Make use of guid
Add a new configuration drop-in file that loads the bli module and runs
the command if booting on the EFI platform.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
Makefile.util.def | 6 ++
util/grub.d/25_bli.in | 24
2 files changed, 30 insertions
Reword some section headings, remove "The List of" from titles. While
grammatically correct, this phrase can be omitted to increase
readability, especially in the table of contents.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
docs/grub.texi | 20 ++
Add checks for NULL pointers to grub_device_close() and
grub_disk_close() to make these functions more robust.
Signed-off-by: Oliver Steffen
---
grub-core/kern/device.c | 3 +++
grub-core/kern/disk.c | 4
2 files changed, 7 insertions(+)
diff --git a/grub-core/kern/device.c b/grub-core
Extend the printf format specifier for pointers (%p) to accept a suffix
specifier G to print GUIDs: %pG can be used to print grub_guid structs.
This does not interfere with the -Wformat checking of gcc. Note that
the data type is not checked though (%p accepts void*).
Signed-off-by: Oliver
Add a function to the EFI module that allows setting EFI variables
with specific attributes.
This is useful for marking variables as volatile, for example.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 20 +---
include/grub/efi/efi.h
Add a function that sets an EFI variable to a string value.
The string is converted from UTF-8 to UTF-16.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 22 ++
include/grub/efi/efi.h | 3 +++
2 files changed, 25 insertions(+)
diff
There are 3 implementations of a GUID in Grub. Replace them with a
common one, placed in types.h.
It uses the "packed" flavor of the GUID structs, the alignment attribute
is dropped, since it is not required.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-cor
Add a function to the EFI module that allows setting EFI variables
with specific attributes.
This is useful for marking variables as volatile, for example.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 19 +--
include/grub/efi/efi.h
In the same way as GRUB_SIZE_MAX, add GRUB_SSIZE_MAX.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
include/grub/types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/grub/types.h b/include/grub/types.h
index c56ce9820..9f43a5580 100644
--- a/include/grub/types.h
Reword some section headings, remove "The List of" from titles. While
grammatically correct, this phrase can be omitted to increase
readability, especially in the table of contents.
Signed-off-by: Oliver Steffen
---
docs/grub.texi | 20 ++--
1 file changed, 10 inserti
be the
bli module there.
[0] https://systemd.io/BOOT_LOADER_INTERFACE/
[1]
https://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html
[2]
https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
Signed-off-by: Oliver Steffen
---
docs
Add a function that sets an EFI variable to a string value.
The string is converted from UTF-8 to UTF-16.
Signed-off-by: Oliver Steffen
---
grub-core/kern/efi/efi.c | 22 ++
include/grub/efi/efi.h | 3 +++
2 files changed, 25 insertions(+)
diff --git a/grub-core/kern/efi
Add a new configuration drop-in file that loads the bli module and runs
the command if booting on the EFI platform.
Signed-off-by: Oliver Steffen
---
Makefile.util.def | 6 ++
util/grub.d/25_bli.in | 24
2 files changed, 30 insertions(+)
create mode 100644
ml/grub-devel/2023-02/msg00099.html
- Addressed comments from Daniel
- Added a print function for gpt guids`
- Added integer overflow check in UTF16 conversion
- Added config drop-in file that loads the module on EFI
v1:
- https://mail.gnu.org/archive/html/grub-devel/2023-01/msg00104.html
Olive
Extend the printf format specifier for pointers (%p) to accept a suffix
specifier G to print GUIDs: %pG can be used to print grub_guid structs.
This does not interfere with the -Wformat checking of gcc. Note that
the data type is not checked though (%p accepts void*).
Signed-off-by: Oliver
, because it needs to be reachable from the
kern/efi code.
Add a check for integer overflow and remove redundant NUL-termination.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 21 ++---
grub-core/kern/misc.c| 32
Use the new printf format specifier %pG.
Fixes the text representation of GUIDs in the output of the lsefisystab
command (missing 4th dash).
Signed-off-by: Oliver Steffen
---
grub-core/commands/efi/lsefi.c | 13 +
grub-core/commands/efi/lsefisystab.c | 6 +-
grub-core
Quoting Daniel Kiper (2023-05-19 16:19:28)
> On Wed, May 03, 2023 at 03:50:09PM +0200, Oliver Steffen wrote:
> > This is a step towards supporting unified kernel images (UKI) in Grub.
[...]
> Sadly there are still some problems with this patch set... :-(
Sorry about that...
> Firs
Use the new printf format specifier %pG.
Fixes the text representation of GUIDs in the output of the lsefisystab
command.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/commands/efi/lsefi.c | 13 +
grub-core/commands/efi/lsefisystab.c | 6 +-
grub
Add a function that sets an EFI variable to a string value.
The string is converted from UTF-8 to UTF-16.
Signed-off-by: Oliver Steffen
---
grub-core/kern/efi/efi.c | 22 ++
include/grub/efi/efi.h | 3 +++
2 files changed, 25 insertions(+)
diff --git a/grub-core/kern/efi
, because it needs to be reachable from the
kern/efi code.
Add a check for integer overflow and remove redundant NUL-termination.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 21 ++---
grub-core/kern/misc.c| 32
be the
bli module there.
[0] https://systemd.io/BOOT_LOADER_INTERFACE/
[1]
https://www.freedesktop.org/software/systemd/man/systemd-gpt-auto-generator.html
[2]
https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
Signed-off-by: Oliver Steffen
---
docs
Reword some section headings, remove "The List of" from titles. While
grammatically correct, this phrase can be omitted to increase
readability, especially in the table of contents.
Signed-off-by: Oliver Steffen
---
docs/grub.texi | 20 ++--
1 file changed, 10 inserti
Extend the printf format specifier for pointers (%p) to accept a suffix
specifier G to print GUIDs: %pG can be used to print grub_guid structs.
This does not interfere with the -Wformat checking of gcc. Note that
the data type is not checked though (%p accepts void*).
Signed-off-by: Oliver
Add a function to the EFI module that allows setting EFI variables
with specific attributes.
This is useful for marking variables as volatile, for example.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 19 +--
include/grub/efi/efi.h
Add a new configuration drop-in file that loads the bli module and runs
the command if booting on the EFI platform.
Signed-off-by: Oliver Steffen
---
Makefile.util.def | 6 ++
util/grub.d/25_bli.in | 24
2 files changed, 30 insertions(+)
create mode 100644
3-01/msg00104.html
Oliver Steffen (10):
efi: Add grub_efi_set_variable_with_attributes()
Unify GUID types
kern/misc: Add a format specifier GUIDs
grub-core: Make use of guid printf format specifier
types.h: Add GRUB_SSIZE_MAX
kern/misc, kern/efi: Extract UTF-8 to UTF-16 co
There are 3 implementations of a GUID in Grub. Replace them with a
common one, placed in types.h.
It uses the "packed" flavor of the GUID structs, the alignment attribute
is dropped, since it is not required.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-cor
In the same way as GRUB_SIZE_MAX, add GRUB_SSIZE_MAX.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
include/grub/types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/grub/types.h b/include/grub/types.h
index c56ce9820..9f43a5580 100644
--- a/include/grub/types.h
Hi Phil,
Quoting Philip Rhoades via Grub-devel (2023-04-22 07:37:45)
> People,
>
> My Fedora WS has 4 drive bays and I access old boot and other HDs in
> bays 2-4. I just did a clean install of Fedora Sway to /dev/sda -
> everything is fine and the system boots OK but I am confused:
>
> - cat
On Fri, Apr 14, 2023 at 4:01 PM Daniel Kiper wrote:
> On Tue, Apr 11, 2023 at 05:51:42PM +0200, Oliver Steffen wrote:
> > On Tue, Apr 11, 2023 at 4:10 PM Oliver Steffen
> wrote:
> > On Wed, Apr 5, 2023 at 5:57 PM Daniel Kiper
> > wrote:
> >
/software/systemd/man/systemd-gpt-auto-generator.html
[2]
https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
Signed-off-by: Oliver Steffen
---
grub-core/Makefile.core.def | 6 ++
grub-core/commands/bli.c| 122
include/grub
Extend the printf format specifier for pointers (%p) to accept a suffix
specifier G to print GUIDs: %pG can be used to print grub_guid structs.
This does not interfere with the -Wformat checking of gcc. Note that
the data type is not checked though (%p accepts void*).
Signed-off-by: Oliver
Add a function that sets an EFI variable to a string value.
The string is converted from UTF-8 to UTF-16.
Signed-off-by: Oliver Steffen
---
grub-core/kern/efi/efi.c | 22 ++
include/grub/efi/efi.h | 3 +++
2 files changed, 25 insertions(+)
diff --git a/grub-core/kern/efi
There are 3 implementations of a GUID in Grub. Replace them with a
common one, placed in types.h.
It uses the "packed" flavor of the GUID structs, the alignment attribute
is dropped, since it is not required.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-cor
Use the new printf format specifier %pG.
Fixes the text representation of GUIDs in the output of the lsefisystab
command.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/commands/efi/lsefi.c | 13 +
grub-core/commands/efi/lsefisystab.c | 6 +-
grub
Add a new configuration drop-in file that loads the bli module and runs
the command if booting on the EFI platform.
Signed-off-by: Oliver Steffen
---
Makefile.util.def | 6 ++
util/grub.d/25_bli.in | 24
2 files changed, 30 insertions(+)
create mode 100644
ile that loads the module on EFI
v1:
- https://mail.gnu.org/archive/html/grub-devel/2023-01/msg00104.html
Oliver Steffen (9):
efi: Add grub_efi_set_variable_with_attributes()
Unify GUID types
kern/misc: Add a format specifier GUIDs
grub-core: Make use of guid printf format specifier
types.h:
Add a function to the EFI module that allows setting EFI variables
with specific attributes.
This is useful for marking variables as volatile, for example.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 19 +--
include/grub/efi/efi.h
In the same way as GRUB_SIZE_MAX, add GRUB_SSIZE_MAX.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
include/grub/types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/grub/types.h b/include/grub/types.h
index c56ce9820..9f43a5580 100644
--- a/include/grub/types.h
, because it needs to be reachable from the
kern/efi code.
Add a check for integer overflow and remove redundant NUL-termination.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 21 ++---
grub-core/kern/misc.c| 32
On Tue, Apr 11, 2023 at 4:10 PM Oliver Steffen wrote:
> On Wed, Apr 5, 2023 at 5:57 PM Daniel Kiper wrote:
>
>> On Thu, Mar 30, 2023 at 01:18:13PM +0200, Oliver Steffen wrote:
>> > Add a new configuration drop-in file that loads the bli module and runs
>> > the
On Wed, Apr 5, 2023 at 5:57 PM Daniel Kiper wrote:
> On Thu, Mar 30, 2023 at 01:18:13PM +0200, Oliver Steffen wrote:
> > Add a new configuration drop-in file that loads the bli module and runs
> > the command if booting on the EFI platform.
> >
> > Si
, because it needs to be reachable from the
kern/efi code.
Add a check for integer overflow and remove redundant NUL-termination.
Signed-off-by: Oliver Steffen
---
grub-core/kern/efi/efi.c | 21 ++---
grub-core/kern/misc.c| 32
include/grub/misc.h
Extend the printf format specifier for pointers (%p) to accept a suffix
specifier G to print GUIDs: %pG can be used to print grub_guid structs.
This does not interfere with the -Wformat checking of gcc. Note that
the data type is not checked though (%p accepts void*).
Signed-off-by: Oliver
]
https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
Signed-off-by: Oliver Steffen
---
docs/grub.texi | 22 +
grub-core/Makefile.core.def | 6 ++
grub-core/commands/bli.c| 166
include/grub/efi/api.h
There are 3 implementations of a GUID in Grub. Replace them with a
common one, placed in types.h.
It uses the "packed" flavor of the GUID structs, the alignment attribute
is dropped, since it is not required.
Signed-off-by: Oliver Steffen
---
grub-core/commands/acpi.c|
Use the new printf format specifier %pG.
Fixes the text representation of GUIDs in the output of the lsefisystab
command.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/commands/efi/lsefi.c | 13 +
grub-core/commands/efi/lsefisystab.c | 6 +-
grub
In the same way as GRUB_SIZE_MAX, add GRUB_SSIZE_MAX.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
include/grub/types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/grub/types.h b/include/grub/types.h
index c56ce9820..9f43a5580 100644
--- a/include/grub/types.h
Add a new configuration drop-in file that loads the bli module and runs
the command if booting on the EFI platform.
Signed-off-by: Oliver Steffen
---
Makefile.util.def | 6 ++
util/grub.d/25_bli.in | 25 +
2 files changed, 31 insertions(+)
create mode 100644
ids`
- Added integer overflow check in UTF16 conversion
- Added config drop-in file that loads the module on EFI
v1:
- https://mail.gnu.org/archive/html/grub-devel/2023-01/msg00104.html
Oliver Steffen (8):
efi: Add grub_efi_set_variable_with_attributes
Unify GUID types
kern/misc: Add a format specif
Add a function to the EFI module that allows setting EFI variables
with specific attributes.
This is useful for marking variables as volatile, for example.
Signed-off-by: Oliver Steffen
Reviewed-by: Daniel Kiper
---
grub-core/kern/efi/efi.c | 19 +--
include/grub/efi/efi.h
1 - 100 of 137 matches
Mail list logo
