s. It expects the directory
> structure to be the same as fonts stored in the prefix path
> (ie, /fonts/.pf2).
>
> Signed-off-by: Chris Coulson
Thanks for posting this.
Reviewed-by: Robbie Harwood
Be well,
--Robbie
signature.asc
Description: PGP signature
___
dd fw_path variable to detect config file on efi
Peter Jones (4):
efinet + bootp: add net_bootp6 command supporting dhcpv6
efinet: also use the firmware acceleration for http
efi/http: match protocol+hostname of boot url in root_url
Try mac/guid/etc before grub.cfg on tftp config files
Robb
the configuration file.
To allow GRUB to continue working on that scenario, fallback to
iterating over all the available devices if reading the config failed
when using the prefix and fw_path variables.
Signed-off-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie
From: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/net.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/grub-core/net/efi/net.c b/grub-core/net/efi/net.c
index 012dc654c5..9ea7ed141f 100644
--- a/grub-core/net/efi/net.c
From: Michael Chang
Update grub documentation for net_bootp6 command.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
index bca1407bf3
From: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/kern/ieee1275/init.c | 28 +++
grub-core/net/net.c| 2 +-
grub-core/normal/main.c| 129 +
3 files changed, 82 insertions(+), 77 deletions
From: Paulo Flabiano Smorigo
This patch makes grub look for its config file on efi where the app was
found.
Resolves: rhbz#857936, rhbz#1616395
Co-authored-by: Matthew Garrett
Co-authored-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Paulo Flabiano Smorigo
Signed
From: Ian Page Hands
If a proxyDHCP configuration is used, the server name, server IP and
boot file values should be taken from the DHCP proxy offer instead of
the DHCP server ack packet.
Signed-off-by: Ian Page Hands
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub
y proposed to grub in 2016).
This reverts commit ac8a37dda0eabdd80506bebe4fb9a5a9fd227935.
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 33 -
grub-core/net/http.c | 40 ++--
2 files changed, 2 insertions(+), 71
From: Peter Jones
This lets you write config files that don't know urls.
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/http.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/grub-core/net/efi/http.c b/grub-core/net/efi/http.c
index
-by: Robbie Harwood
---
docs/grub.texi | 12 +++
grub-core/net/http.c | 18 ---
grub-core/net/net.c | 77 +---
grub-core/net/tftp.c | 6 +++-
include/grub/net.h | 1 +
5 files changed, 104 insertions(+), 10 deletions(-)
diff --git a/docs
Feb 2020 17:45:58 GMT
ETag: "206-59f924b24b1da"
Accept-Ranges: bytes
Content-Length: 518
Resolves: rhbz#1732765
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/http.c | 37 -
1 file changed, 28 insert
t" vendor class identifier in DHCPACK
packet by treating it as HTTP format, not as the PXE format.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/bootp.c | 55 +++
include/grub/net.h| 1 +
in the prefix
directory which may not be the same fw_path. This patch changes that
behavior to use the fw_path directory for the fallback search. Only if
fw_path is NULL will the prefix directory be searched.
Signed-off-by: Mark Salter
Signed-off-by: Robbie Harwood
---
grub-core/normal/main.c | 5 +++--
1
From: Peter Jones
Implement new net_bootp6 command for IPv6 network auto configuration via
the DHCPv6 protocol (RFC3315).
Signed-off-by: Peter Jones
Co-authored-by: Michael Chang
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie
From: Stephen Benjamin
This sets a couple of variables. With the url http://www.example.com/foo/bar :
http_path: /foo/bar
http_url: http://www.example.com/foo/bar
Resolves: rhbz#1616395
Co-authored-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Peter Jones
Signed
functions to ensure the network
interface is setting up the same way it used to be.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 160 +
include/grub/efi/api.h | 77
this, and make them agnostic
between ipv4 and ipv6.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 2 +
include/grub/efi/api.h | 71 ++
2 files
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 278 +++--
include/grub/efi/api.h | 11 ++
2 files changed, 274 insertions(+), 15 deletions(-)
diff --git a/grub-core/net/drivers/efi/efinet.c
b/grub-core/net/drivers
http_path, but the http driver doesn't. So using this driver and
attempting to fetch a resource using a relative path fails. Match the
behavior of efi/http.
Signed-off-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub-core/net/http.c | 10
Co-authored-by: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/net/http.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/grub-core/net/http.c b/grub-core/net/http.c
index df690acf67..406777b01b 100644
--- a/grub-core/net/http.c
+++ b
Michael Chang via Grub-devel writes:
> On Tue, Mar 28, 2023 at 11:00:01AM +0530, Mukesh Kumar Chaurasiya wrote:
>> Sometimes, when booting from a very busy SAN, the access to the
>> disk can fail and then grub will eventually drop to grub prompt.
>> This scenario is more frequent when deploying
on success.
Signed-off-by: Robbie Harwood
---
grub-core/loader/emu/linux.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/loader/emu/linux.c b/grub-core/loader/emu/linux.c
index 0cf378a376..7de3f7f861 100644
--- a/grub-core/loader/emu/linux.c
+++ b/grub-core/loader/emu/linux.c
@@ -7
Glenn Washburn writes:
> On 3/9/23 23:00, Robbie Harwood wrote:
>> Glenn Washburn writes:
>>
>>> If the configure option --enable-efi-debug is given, then enable the
>>> printing early in EFI startup of the command needed to load symbols for
>>> the G
Glenn Washburn writes:
> If the configure option --enable-efi-debug is given, then enable the
> printing early in EFI startup of the command needed to load symbols for
> the GRUB EFI kernel. This is needed because EFI firmware determines where
> to load the GRUB EFI at runtime, and so the
and set the MAX
> CPUs bits to this value.
>
> Add an IBM/ieee1275 vTPM 2.0 driver that requires the preceeding memory
> patches due to the grub's TPM subsystem needing large chunks of memory for
> hashing of files such as initrd and kernel.
>
> Stefan
For the series:
Re
Glenn Washburn writes:
> If the configure option --enable-efi-debug is given, then enable the
> printing early in EFI startup of the command needed to load symbols for
> the GRUB EFI kernel. This is needed because EFI firmware determines where
> to load the GRUB EFI at runtime, and so the
~50MB
>
> - a RHEL8.2 ppc64le pseries KVM guest:
> vmlinux: ~30MB
> initrd: ~30MB
>
> So to give us a little wriggle room, I think we want to leave at least
> 128MB for the loader to put vmlinux and initrd in memory and leave Linux
> with space to satisfy its e
pseries because it will mess with region merging.
>
> Signed-off-by: Daniel Axtens
> Reviewed-by: Daniel Kiper
Reviewed-by: Robbie Harwood
Be well,
--Robbie
signature.asc
Description: PGP signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
message to be displayed in the Linux kernel log. Those users will
> have to update their machines to the firmware levels mentioned
> above.
>
> Cc: Eric Snowberg
> Signed-off-by: Stefan Berger
> Signed-off-by: Daniel Axtens
> Reviewed-by: Daniel Kiper
Reviewed-by: Ro
Stefan Berger writes:
> -/* The maximum heap size we're going to claim */
> +/* The maximum heap size we're going to claim at boot. Not used by sparc. */
> #ifdef __i386__
> #define HEAP_MAX_SIZE(unsigned long) (64 * 1024 * 1024)
> -#else
> +#else /* __powerpc__ */
> #define
George Barrett writes:
> The module loader contains the following check:[1]
>
> /* Me, Vladimir Serbinenko, hereby I add this module check as per new
>GNU module policy. Note that this license check is informative only.
>Modules have to be licensed under GPLv3 or GPLv3+
Stefan Berger writes:
> +.vec5_size = 1 + sizeof (struct option_vector5) - 2,
> +.vec5 = {
> + 0, 0, 0, 0, 0, 0, 0, 0, 256
> +}
Hi Stefan and Diego, are you able to speak to vec5 setting?
I have been talking with Avnish Chouhan (CC'd) downstream and requested
they sync with
Glenn Washburn writes:
> On Mon, 23 Jan 2023 10:28:09 +0100
> Gerd Hoffmann wrote:
>
>> On Sat, Jan 21, 2023 at 12:15:20AM -0600, Glenn Washburn wrote:
>> > The current qemu firmware paths for arm-efi and arm64-efi are not
>> > available on Ubuntu/Debian but are hardcoded. Switch to first
>> >
"Vladimir 'phcoder' Serbinenko" writes:
> This is not properly restricted to just raid. Only mdraid 1.1 is
> affected. The condition should probably be along the lines "if msdos
> is embedded in a device of unknown size, then skip mdraid 1.1 probing"
My testing suggested it was both mdraid1x
"Vladimir 'phcoder' Serbinenko" writes:
> The ,0 suffix sounds like a bug in a detection
> As for the prefix, can‘t we solve it by setting prefix properly.
> If there is really no better solution (doubtful) then it needs to be
> restricted to chrp platforms and even there, probably only a subset
: on CDs, we always want the raw device. This fixes an issue
where grub would successfully load the menu from an image, but then
produce the error:
error: ../../grub-core/net/net.c:1552:disk `ieee1275/cdrom,0' not found.
and fail to boot further.
Signed-off-by: Robbie Harwood
---
grub-core
image appear to diagree on the blocksize (512
vs. 2048), and the diskfilter RAID probing is too much for it. We won't
be seeing RAID on bootable CDs, so just turn it off.
Signed-off-by: Robbie Harwood
---
grub-core/disk/diskfilter.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/g
Fix three issues uncovered while trying to use the same core.elf on both
installed systems and boot media. CCing POWER folks I have working
emails for in case they have a better way to do any of this.
Be well,
--Robbie
Robbie Harwood (2):
Skip diskfilter on powerpc CDs
Fix prefix and root
the configuration file.
To allow GRUB to continue working on that scenario, fallback to
iterating over all the available devices if reading the config failed
when using the prefix and fw_path variables.
Signed-off-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie
http_path, but the http driver doesn't. So using this driver and
attempting to fetch a resource using a relative path fails. Match the
behavior of efi/http.
Signed-off-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub-core/net/http.c | 10
From: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/kern/ieee1275/init.c | 28 +++
grub-core/net/net.c| 2 +-
grub-core/normal/main.c| 129 +
3 files changed, 82 insertions(+), 77 deletions
functions to ensure the network
interface is setting up the same way it used to be.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 160 +
include/grub/efi/api.h | 77
From: Aaron Miller
Allow specifying port numbers for http and tftp paths, and allow ipv6
addresses to be recognized with brackets around them, which is required
to specify a port number.
Signed-off-by: Aaron Miller
Co-authored-by: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie
From: Peter Jones
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/net.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/grub-core/net/efi/net.c b/grub-core/net/efi/net.c
index 012dc654c5..9ea7ed141f 100644
--- a/grub-core/net/efi/net.c
in the prefix
directory which may not be the same fw_path. This patch changes that
behavior to use the fw_path directory for the fallback search. Only if
fw_path is NULL will the prefix directory be searched.
Signed-off-by: Mark Salter
Signed-off-by: Robbie Harwood
---
grub-core/normal/main.c | 5 +++--
1
From: Michael Chang
Update grub documentation for net_bootp6 command.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/grub.texi b/docs/grub.texi
index ed295dabd2
From: Peter Jones
Implement new net_bootp6 command for IPv6 network auto configuration via
the DHCPv6 protocol (RFC3315).
Signed-off-by: Peter Jones
Co-authored-by: Michael Chang
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie
From: Paulo Flabiano Smorigo
This patch makes grub look for its config file on efi where the app was
found.
Resolves: rhbz#857936, rhbz#1616395
Co-authored-by: Matthew Garrett
Co-authored-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Paulo Flabiano Smorigo
Signed
Feb 2020 17:45:58 GMT
ETag: "206-59f924b24b1da"
Accept-Ranges: bytes
Content-Length: 518
Resolves: rhbz#1732765
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/http.c | 37 -
1 file changed, 28 insert
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 278 +++--
include/grub/efi/api.h | 11 ++
2 files changed, 274 insertions(+), 15 deletions(-)
diff --git a/grub-core/net/drivers/efi/efinet.c
b/grub-core/net/drivers
This reverts commit ac8a37dda0eabdd80506bebe4fb9a5a9fd227935.
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 33 -
grub-core/net/http.c | 40 ++--
2 files changed, 2 insertions(+), 71 deletions(-)
diff --git a/docs
From: Ian Page Hands
If a proxyDHCP configuration is used, the server name, server IP and
boot file values should be taken from the DHCP proxy offer instead of
the DHCP server ack packet.
Signed-off-by: Ian Page Hands
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub
h variable to detect config file on efi
Peter Jones (4):
efinet + bootp: add net_bootp6 command supporting dhcpv6
efinet: also use the firmware acceleration for http
efi/http: match protocol+hostname of boot url in root_url
Try mac/guid/etc before grub.cfg on tftp config files
Robbie
this, and make them agnostic
between ipv4 and ipv6.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Co-authored-by: Robbie Harwood
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/efi/efinet.c | 2 +
include/grub/efi/api.h | 71 ++
2 files
t" vendor class identifier in DHCPACK
packet by treating it as HTTP format, not as the PXE format.
Signed-off-by: Michael Chang
Signed-off-by: Ken Lin
Signed-off-by: Robbie Harwood
---
grub-core/net/bootp.c | 55 +++
include/grub/net.h| 1 +
From: Stephen Benjamin
This sets a couple of variables. With the url http://www.example.com/foo/bar :
http_path: /foo/bar
http_url: http://www.example.com/foo/bar
Resolves: rhbz#1616395
Co-authored-by: Javier Martinez Canillas
Co-authored-by: Robbie Harwood
Signed-off-by: Peter Jones
Signed
From: Peter Jones
This lets you write config files that don't know urls.
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
grub-core/net/efi/http.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/grub-core/net/efi/http.c b/grub-core/net/efi/http.c
index
Zhang Boyang writes:
> On 2022/12/21 06:58, Robbie Harwood wrote:
>> Zhang Boyang writes:
>>
>>> This patch add version information to GRUB modules. Specifically,
>>> PACKAGE_VERSION is embedded as null-terminated string in .modver
>>> section. Thi
Zhang Boyang writes:
> This patch add version information to GRUB modules. Specifically,
> PACKAGE_VERSION is embedded as null-terminated string in .modver
> section. This string is checked at module loading time. That module will
> be rejected if mismatch is found. This will prevent loading
Ard Biesheuvel writes:
> As for supporing kernels from 2012: I don't see why upstream GRUB
> should care about that. If your distro fork supports those today, you
> will simply need to carry those patches out of tree a bit longer.
No, it's not a question of distros supporting themselves like
Zhang Boyang writes:
> Since font files can be wrapped as PE images by grub-wrap, use shim to
> verify font files if Secure Boot is enabled. To prevent other PE files
> (e.g. kernel images) used as wrappers, it only allows files marked as
> Windows GUI used as wrappers.
Thanks for writing this;
Zhang Boyang writes:
> On 2022/11/30 02:35, Steve McIntyre wrote:
>
>> AFAIK Chris Coulson has a patch for the font loader to cause it to try
>> loading fonts from the embedded memdisk first. Is that the best
>> approach? If so, what fonts should we be embedding in the signed
>> image? It's a
Steve McIntyre writes:
> Hey folks!
>
> So, with the latest set of GRUB CVE patches we've fixed up a bunch of
> potential crashes in font-handling code that could lead to Secure Boot
> holes. These are good and useful fixes, and thanks to Zhang Boyang and
> everyone else involved!
>
> There were
Steve McIntyre writes:
> Hi all!
>
> программист некто (in CC) reported this bug a few weeks back in
> Debian. Since I applied the bundle of filesystem bounds-checking fixes
> a few months back, he can't run grub-install. He's done the work to
> determine that the patch that breaks things for
Daniel Kiper writes:
> On Fri, Nov 04, 2022 at 01:05:37PM -0400, Robbie Harwood wrote:
>
>> ---
>> grub-core/commands/help.c | 2 ++
>> grub-core/normal/main.c | 3 ++-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/grub-core/c
This is not an ideal solution, as interactive users must always ru na
command in order to get the behavior they want, but it avoids
problematic interactions between prompting and sourcing files.
Signed-off-by: Robbie Harwood
---
grub-core/commands/help.c | 2 ++
grub-core/normal/main.c | 3
Rewrite to address review and clarifications with suggestion from Daniel
(thanks).
Be well,
--Robbie
Robbie Harwood (1):
Add paging instructions to normal and help prompts
grub-core/commands/help.c | 2 ++
grub-core/normal/main.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion
the previous behavior.
Also-authored-by: Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 10 ++
grub-core/commands/tpm.c | 21 +++--
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Robbie Harwood
---
grub-core/kern/env.c | 13 +
include/grub/env.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/grub-core/kern/env.c b/grub-core/kern/env.c
index 10e08ad76c..7640688963 100644
--- a/grub-core/kern/env.c
+++ b/grub-core/kern/env.c
@@ -144,6
,
--Robbie
Robbie Harwood (3):
types: make bool generally available
env: add function for retrieving variables as booleans
tpm: Don't propagate measurement failures to the verifiers layer
docs/grub.texi | 10 ++
grub-core/commands/parttool.c | 2 +-
grub-core/commands
Add an include on stdbool.h, making the bool type generally available
within grub without needing to add a file-specific include every time it
would be used.
Signed-off-by: Robbie Harwood
---
grub-core/commands/parttool.c | 2 +-
grub-core/loader/arm64/linux.c | 1 -
grub-core/parttool
Daniel Kiper writes:
> On Mon, Oct 31, 2022 at 03:35:49PM -0400, Robbie Harwood wrote:
>> Conditionally add instructions for enabling paging to the prompt of
>> interactive shells. This is not an ideal solution, as ineractive users
>> must always run a command in orde
the previous behavior.
Also-authored-by: Javier Martinez Canillas
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 9 +
grub-core/commands/tpm.c | 29 ++---
2 files changed, 35 insertions(+), 3 deletions
Address Daniel's and James's feedback on previous version by adding an
environment variable to restore the TPM hard failure behavior. Interdiff
attached.
Be well,
--Robbie
Robbie Harwood (1):
tpm: Don't propagate measurement failures to the verifiers layer
docs/grub.texi | 9
This patch replaces the earlier "Enable pager by default" from Peter and
Javier with the solution requested by Vladimir.
Be well,
--Robbie
Robbie Harwood (1):
normal: Add paging instructions to interactive prompt
grub-core/normal/main.c | 4 +++-
grub-core/normal/term.c | 6 +
-by: Robbie Harwood
---
grub-core/normal/main.c | 4 +++-
grub-core/normal/term.c | 6 ++
include/grub/normal.h | 1 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
index cb0e8e7fd2..d9d7c4ad28 100644
--- a/grub-core/normal
-off-by: John Jolly
Signed-off-by: Javier Martinez Canillas
[rharwood: documentation, code style]
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 30 --
grub-core/Makefile.am| 1 +
grub-core/Makefile.core.def | 2 +-
grub-core/kern/emu/main.c| 4 +
grub
Address feedback from Daniel's third review (interdiff attached).
Be well,
--Robbie
Raymund Will (1):
Add support for grub-emu to kexec Linux menu entries
docs/grub.texi | 30 --
grub-core/Makefile.am| 1 +
grub-core/Makefile.core.def | 2 +-
Daniel Kiper writes:
> On Wed, Oct 19, 2022 at 02:50:00PM -0400, Robbie Harwood wrote:
>
>> diff --git a/grub-core/kern/emu/misc.c b/grub-core/kern/emu/misc.c
>> index d0e7a107e7..521220b49d 100644
>> --- a/grub-core/kern/emu/misc.c
>> +++ b/grub-core/ker
Address feedback from Daniel's review (interdiff attached). Specifically,
perform a style cleanup, add more documentation, and add three comments.
Be well,
--Robbie
Raymund Will (1):
Add support for grub-emu to kexec Linux menu entries
docs/grub.texi | 28 --
-off-by: John Jolly
Signed-off-by: Javier Martinez Canillas
[rharwood: documentation, code style]
Signed-off-by: Robbie Harwood
---
docs/grub.texi | 28 --
grub-core/Makefile.am| 1 +
grub-core/Makefile.core.def | 2 +-
grub-core/kern/emu/main.c| 4 +
grub
Daniel Kiper writes:
> On Tue, Oct 04, 2022 at 03:16:48PM -0400, Robbie Harwood wrote:
>
>> + return rc;
>> +}
>> +
>> +static grub_err_t
>> +grub_linux_unload (void)
>> +{
>> + grub_dl_unref (my_mod);
>
> I understand that this marks
Oskari Pirhonen writes:
> On Tue, Oct 04, 2022 at 15:16:48 -0400, Robbie Harwood wrote:
>> From: Raymund Will
>>
>> The GRUB emulator is used as a debugging utility but it could also be
>> used as a user-space bootloader if there is support to boot an operating
include dirs, which -I options we use, etc., but this makes it so you
can do the checking on the file you're editing, rather than on a
different file.
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
include/grub/elf.h| 4 ++--
util/grub-module-verifier32.c | 2 ++
util/gr
(Resend since not all changes were in v4 that were supposed to be.)
Address Daniel's comments on v2/v3.
In particular, gcc (Debian 12.2.0-3) only warns when the redefinition is
to a different value. It gets confused by the space, so just remove it.
This causes
gcc -x c -fsyntax-only
Address Daniel's comments on previous version.
In particular, gcc (Debian 12.2.0-3) only warns when the redefinition is
to a different value. It gets confused by the space, so just remove it.
This causes
gcc -x c -fsyntax-only -Iinclude -I. util/grub-module-verifierXX.c
to build without
include dirs, which -I options we use, etc., but this makes it so you
can do the checking on the file you're editing, rather than on a
different file.
Signed-off-by: Peter Jones
Signed-off-by: Robbie Harwood
---
util/grub-module-verifier32.c | 2 ++
util/grub-module-verifier64.c | 2 ++
util/grub
-off-by: John Jolly
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Robbie Harwood
---
grub-core/Makefile.am| 1 +
grub-core/Makefile.core.def | 2 +-
grub-core/kern/emu/main.c| 4 +
grub-core/kern/emu/misc.c| 18 +++-
grub-core/loader/emu/linux.c | 181
Address feedback from Raymund's review. Interdiff attached.
Be well,
--Robbie
Raymund Will (1):
Add support for grub-emu to kexec Linux menu entries
grub-core/Makefile.am| 1 +
grub-core/Makefile.core.def | 2 +-
grub-core/kern/emu/main.c| 4 +
grub-core/kern/emu/misc.c
setup
> --is-supported`) but if it's not available the behavior before 26031d3b1
> is maintained (unconditionally show the menu entry on EFI platforms).
>
> Also do this only on the EFI platform as Dimitri John Ledkov suggested.
>
> Cc: Javier Martinez Canillas
> Cc: Robbie Harwood
>
Renaud Métrich writes:
> When efi.quickboot is enabled on VMWare (which is the default for
> hardware release 16 and later), it may happen that not all EFI devices
> are connected. Due to this, browsing the devices in make_devices() just
> fails to find devices, in particular disks or partitions
amp;2
>
> cat << EOF
> -fwsetup --is-supported
> -if [ "\$grub_platform" = "efi" -a "\$?" = 0 ]; then
> +if [ "\$grub_platform" = "efi" ]; then
> menuentry '$LABEL' \$menuentry_id_option 'uefi-firmware' {
> fwsetup
> }
> --
> 2.37.1
While we could revert the entire --is-supported logic as well, since
this is upstream pre-release code, it's probably easier for the
downstreams that pulled this change if we don't, so:
Reviewed-by: Robbie Harwood .
Be well,
--Robbie
signature.asc
Description: PGP signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Philip Müller writes:
>> Hello Robbie, hello Daniel,
>>
>> with the commit 26031d3b101648352e4e427f04bf69d320088e77
>> 30_uefi-firmware will always call `fwsetup --is-supported' to check
>> if the system supports EFI or not. However most installed grub
>> versions on MBR don't support the
John Paul Adrian Glaubitz writes:
> On 8/30/22 18:37, Robbie Harwood wrote:
>
>> As the person currently responsible for the Red Hat tree: I am also
>> not happy about this state of affairs.
>
> I don't want to sound rude, but GRUB isn't a RedHat-only project, it
"Vladimir 'phcoder' Serbinenko" writes:
> Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit :
>
>> Let me answer this out of order.
>>
>>> I understand the need to sometimes get rid of old code, but since
>>> the HFS module can be blacklisted as Vladimir explains, I don't
>>> really understand
Daniel Axtens writes:
>>> Have you checked that you can't boot them with HFS+? Because HFS+
>>> came in 1998, which was (AFAICT) pretty early on in the G3
>>> lifecycle. So I'd be really surprised if the firmware didn't support
>>> booting from HFS+. I'd be very keen to hear.
>>
>> I have not
Changes in this version:
- Replaced changed swap_bytes32(le_to_cpu32()) with be_to_cpu32().
Please note that I'm not an expert on this platform and can only perform very
basic testing there. However, this patch is functionally the same as one
we've been carrying downstream since late 2016
# ~grub_be_to_cpu32 (subnet_mask.ipv4)
The count of zero with __builtin_clz can be 22. (clz counts the number
of one bits preceding the most significant zero bit)
Signed-off-by: Masahiro Matsuya
Signed-off-by: Robbie Harwood
---
grub-core/net/drivers/ieee1275/ofnet.c | 3 +--
1 file
Raymund Will writes:
> Robbie Harwood wrote on 2022-08-23T17:15:42 -0400:
>> From: Raymund Will
> [...]
>> By default the systemctl kexec option is used so systemd can shutdown
>> all of the running services before doing a reboot using kexec. But if
>> thi
1 - 100 of 265 matches
Mail list logo
