Committed
Christian Franke wrote:
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
I actually seen the '/' case and have incorrectly assumed it's always
so. However there is still one case when you patch changes the
behaviour:
$ grub-mkrelpath /
$ ./grub-mkrelpath /
/
Although:
$
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
+ /* Include leading slash. */
+ offset = 0;
+ break;
Why do you make this change? It seems to make the behaviour of
make_path_relative_to_its root inconsistent since E.g.
/boot/grub - grub
Christian Franke wrote:
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
+ /* Include leading slash. */
+ offset = 0;
+ break;
Why do you make this change? It seems to make the behaviour of
make_path_relative_to_its root inconsistent since E.g.
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
I actually seen the '/' case and have incorrectly assumed it's always
so. However there is still one case when you patch changes the behaviour:
$ grub-mkrelpath /
$ ./grub-mkrelpath /
/
Although:
$ ./grub-mkrelpath /mnt/boot/
$ grub-mkrelpath
Christian Franke wrote:
The Cywin path handling is broken since
make_system_path_relative_to_its_root() functionality was moved from
the lib script to misc.c.
This patch should fix this. It reuses the Cygwin specific code from
getroot.c:grub_get_prefix() which apparently is a different
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
The Cywin path handling is broken since
make_system_path_relative_to_its_root() functionality was moved from
the lib script to misc.c.
This patch should fix this. It reuses the Cygwin specific code from
Christian Franke wrote:
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
Christian Franke wrote:
The Cywin path handling is broken since
make_system_path_relative_to_its_root() functionality was moved from
the lib script to misc.c.
This patch should fix this. It reuses the Cygwin specific
The Cywin path handling is broken since
make_system_path_relative_to_its_root() functionality was moved from the
lib script to misc.c.
This patch should fix this. It reuses the Cygwin specific code from
getroot.c:grub_get_prefix() which apparently is a different
implementation of the same
