Re: [PATCH] Handling command line option for core.img and g2ldr

2008-03-04 Thread Bean
Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-03-03 Thread Robert Millan
On Sun, Mar 02, 2008 at 04:10:35PM +0800, Bean wrote: > Hi, > > Perhaps i can check in the part that sets boot device for multiboot > loader first. I think we all agree that this part is desirable :-) -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you a

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-03-02 Thread Bean
Hi, Perhaps i can check in the part that sets boot device for multiboot loader first. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-28 Thread Yoshinori K. Okuji
On Thursday 28 February 2008 17:58, Robert Millan wrote: > On Fri, Feb 29, 2008 at 12:14:06AM +0800, Bean wrote: > > > There are worse situations in fact (in that they're more common), like > > > RAID and LVM drives (which can be the boot device too). > > > > > > But I don't think we need parser

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-28 Thread Robert Millan
On Fri, Feb 29, 2008 at 12:14:06AM +0800, Bean wrote: > > > > There are worse situations in fact (in that they're more common), like RAID > > and LVM drives (which can be the boot device too). > > > > But I don't think we need parser code for that. The path part of the > > prefix > > (/boot/g

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-28 Thread Bean
On Thu, Feb 28, 2008 at 11:33 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > [ readding CC to grub-devel ] > > > > On Thu, Feb 28, 2008 at 08:26:12PM +0800, Bean wrote: > > On Thu, Feb 28, 2008 at 6:18 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > On Mon, Feb 25, 2008 at 02:10:46AM -0500

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-28 Thread Robert Millan
[ readding CC to grub-devel ] On Thu, Feb 28, 2008 at 08:26:12PM +0800, Bean wrote: > On Thu, Feb 28, 2008 at 6:18 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 25, 2008 at 02:10:46AM -0500, Pavel Roskin wrote: > > > Quoting Bean <[EMAIL PROTECTED]>: > > > > > > >This patch allo

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-28 Thread Robert Millan
On Mon, Feb 25, 2008 at 02:10:46AM -0500, Pavel Roskin wrote: > Quoting Bean <[EMAIL PROTECTED]>: > > >This patch allow passing command line options to core.img or g2ldr: > > Isn't it an overkill? When do you think it would be really needed in > practice? I don't feel good about adding code j

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-25 Thread Bean
On Mon, Feb 25, 2008 at 10:08 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-25 at 15:50 +0800, Bean wrote: > > On Mon, Feb 25, 2008 at 3:10 PM, Pavel Roskin <[EMAIL PROTECTED]> wrote: > > > Quoting Bean <[EMAIL PROTECTED]>: > > > > > > > This patch allow passing command line op

Re: [PATCH] Handling command line option for core.img and g2ldr

2008-02-24 Thread Pavel Roskin
Quoting Bean <[EMAIL PROTECTED]>: This patch allow passing command line options to core.img or g2ldr: Isn't it an overkill? When do you think it would be really needed in practice? I don't feel good about adding code just because we can. This patch also set the boot device in the multib

[PATCH] Handling command line option for core.img and g2ldr

2008-02-24 Thread Bean
Hi, This patch allow passing command line options to core.img or g2ldr: For example, in grub2: multiboot /core.img prefix=(hd0,1)/boot/grub multiboot /core.img root=(hd0,1) linux /g2ldr prefix=(hd0,1)/boot/grub linux /g2ldr root=(hd0,1) prefix will take preference over root. you can also set o