Re: [PATCH] Split #2: parser/reader separation

2009-05-02 Thread Bean
Hi, Thanks for the review, commit it now. On Sat, May 2, 2009 at 6:15 AM, Vladimir 'phcoder' Serbinenko phco...@gmail.com wrote: Patch looks fine for me. I think you can commit it As for lua put the origin clearly and put the original copyright notice below grub's one. Tomorrow I'll do the

Re: [PATCH] Split #2: parser/reader separation

2009-05-01 Thread Vladimir 'phcoder' Serbinenko
Patch looks fine for me. I think you can commit it As for lua put the origin clearly and put the original copyright notice below grub's one. Tomorrow I'll do the same for freebsd64 patch and will merge it Oh, I think it is quite compact already, have you got any suggestion to reduce its size ?

Re: [PATCH] Split #2: parser/reader separation

2009-04-26 Thread Vladimir 'phcoder' Serbinenko
Hello this patch breaks grub-emu. Also some files include grub/rescue.h and this has to be fixed. Also there is a bug is that in case of syntax error reader continues to ask for more lines. E.g grub if ; syntax error Then it's impossible to exit from this bug mode. It's not your fault but since

Re: [PATCH] Split #2: parser/reader separation

2009-04-26 Thread Bean
On Sun, Apr 26, 2009 at 11:50 PM, Vladimir 'phcoder' Serbinenko phco...@gmail.com wrote: Hello this patch breaksĀ  grub-emu. Also some files include grub/rescue.h and this has to be fixed. Hi, For large patch, I normally add only the necessary changes to make it compile in i386-pc. As commits

Re: [PATCH] Split #2: parser/reader separation

2009-04-21 Thread Bean
Hi, ping ? On Sun, Apr 12, 2009 at 12:36 AM, Bean bean12...@gmail.com wrote: Hi, This patch moves the parser from normal.mod to script/sh, it also split rescue mode to rescue_reader and rescue_parser. dynamic command support and auto fs loader is moved to standalone source file