Re: [PATCH] Tidy up 'make' output

2008-06-18 Thread Robert Millan
On Wed, Jun 18, 2008 at 12:22:43AM +0200, Stefan Reinauer wrote: I would not consider this hiding information. The information you see (CFLAGS for example) don't really change across the lines and there's always the chance to say V=1 to see all the compiler lines. The opposite: The current

Re: [PATCH] Tidy up 'make' output

2008-06-18 Thread Robert Millan
On Tue, Jun 17, 2008 at 03:31:54PM -0700, Colin D Bennett wrote: I'm all for warning-free code, but if we try to use -Werror, the code won't even begin to compile in the current state. Of course, I wasn't proposing to add -Werror in the current state and just throw the hot potato into everyone

Re: [PATCH] Tidy up 'make' output

2008-06-18 Thread Pavel Roskin
On Wed, 2008-06-18 at 19:46 +0200, Robert Millan wrote: On Tue, Jun 17, 2008 at 03:31:54PM -0700, Colin D Bennett wrote: I'm all for warning-free code, but if we try to use -Werror, the code won't even begin to compile in the current state. Of course, I wasn't proposing to add -Werror in

Re: [PATCH] Tidy up 'make' output

2008-06-18 Thread Robert Millan
On Wed, Jun 18, 2008 at 02:02:17PM -0400, Pavel Roskin wrote: On Wed, 2008-06-18 at 19:46 +0200, Robert Millan wrote: On Tue, Jun 17, 2008 at 03:31:54PM -0700, Colin D Bennett wrote: I'm all for warning-free code, but if we try to use -Werror, the code won't even begin to compile in the

[PATCH] Tidy up 'make' output

2008-06-17 Thread Colin D Bennett
When thousands of long, wrapped lines full of command line options and file names are scrolling by on your terminal, it is very hard to pick out the irregularities in the build process, such as error and warnings. To make the output of ``make`` easier to parse by eye as it scrolls by, I added

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Pavel Roskin
On Tue, 2008-06-17 at 10:44 -0700, Colin D Bennett wrote: When thousands of long, wrapped lines full of command line options and file names are scrolling by on your terminal, it is very hard to pick out the irregularities in the build process, such as error and warnings. I like the idea, but

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Colin D Bennett
On Tue, 17 Jun 2008 15:57:47 -0400 Pavel Roskin [EMAIL PROTECTED] wrote: On Tue, 2008-06-17 at 10:44 -0700, Colin D Bennett wrote: When thousands of long, wrapped lines full of command line options and file names are scrolling by on your terminal, it is very hard to pick out the

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Pavel Roskin
On Tue, 2008-06-17 at 13:07 -0700, Colin D Bennett wrote: On Tue, 17 Jun 2008 15:57:47 -0400 Pavel Roskin [EMAIL PROTECTED] wrote: On Tue, 2008-06-17 at 10:44 -0700, Colin D Bennett wrote: When thousands of long, wrapped lines full of command line options and file names are scrolling

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Robert Millan
On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote: with output that, in my opinion, makes it easier to see warnings and errors: COMPILE ../util/getroot.c COMPILE ../kern/device.c ../kern/device.c: In function 'grub_device_iterate': ../kern/device.c:84:

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Pavel Roskin
On Tue, 2008-06-17 at 22:37 +0200, Robert Millan wrote: I don't like the idea of hiding information this way. If something fails, make V=1 can be used to find the command. If the goal is to catch warnings, I think -Werror can do a much better job (and catching errors shouldn't be a problem

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Stefan Reinauer
Robert Millan wrote: On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote: with output that, in my opinion, makes it easier to see warnings and errors: COMPILE ../util/getroot.c COMPILE ../kern/device.c ../kern/device.c: In function

Re: [PATCH] Tidy up 'make' output

2008-06-17 Thread Colin D Bennett
On Tue, 17 Jun 2008 22:37:10 +0200 Robert Millan [EMAIL PROTECTED] wrote: On Tue, Jun 17, 2008 at 10:44:48AM -0700, Colin D Bennett wrote: with output that, in my opinion, makes it easier to see warnings and errors: COMPILE ../util/getroot.c COMPILE