Re: [PATCH] try to avoid false positives on FAT filesystem

On Sun, Feb 08, 2009 at 08:59:58PM +0100, Felix Zielcke wrote: Am Sonntag, den 08.02.2009, 20:56 +0100 schrieb Robert Millan: I reviewed this thread and couldn't find it. Did you send it elsewhere? In my first message where you quoted the changelog entry. Well again attached. Sorry, I

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Montag, den 09.02.2009, 15:07 +0100 schrieb Robert Millan: Looks good to me. But please add spaces between ')' and 'b', and after ','. Ok commited. -- Felix Zielcke ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] try to avoid false positives on FAT filesystem

On Sun, Feb 08, 2009 at 10:03:43AM +0100, Felix Zielcke wrote: 2009-02-08 Felix Zielcke fziel...@z-51.de * conf/common.rmk (grub_probe_SOURCES): Move fs/ext2.c before fs/fat.c to avoid false posivites with FAT. (grub_fstest_SOURCES): Likewise. * conf/i386-pc.rmk

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Montag, den 09.02.2009, 15:40 +0100 schrieb Robert Millan: After your other commit, is this one still needed/useful? Well my other commit just fixes the problem probable for these Dell utiliti FAT partitions because they don't have a valid FAT16 string. It could be still useful for the

Re: [PATCH] try to avoid false positives on FAT filesystem

On Mon, Feb 09, 2009 at 03:49:46PM +0100, Felix Zielcke wrote: Am Montag, den 09.02.2009, 15:40 +0100 schrieb Robert Millan: After your other commit, is this one still needed/useful? Well my other commit just fixes the problem probable for these Dell utiliti FAT partitions because

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Montag, den 09.02.2009, 18:06 +0100 schrieb Robert Millan: No objection from me. Ok commited. -- Felix Zielcke ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Samstag, den 07.02.2009, 23:52 +0100 schrieb Robert Millan: There's one, you forgot to attach it ;-) Actually I didn't forgot it, I was too lazy. I thought such a simple change doestn't need a patch send to list :) Well here it is. -- Felix Zielcke 2009-02-08 Felix Zielcke

Re: [PATCH] try to avoid false positives on FAT filesystem

On Sun, Feb 08, 2009 at 10:03:43AM +0100, Felix Zielcke wrote: Am Samstag, den 07.02.2009, 23:52 +0100 schrieb Robert Millan: There's one, you forgot to attach it ;-) Actually I didn't forgot it, I was too lazy. I thought such a simple change doestn't need a patch send to list :) Well

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Sonntag, den 08.02.2009, 19:02 +0100 schrieb Robert Millan: This looks different than what you described: Here's a little patch to check if bpb.version_specific.fat12_or_fat16.fstype or bpb.version_specific.fat32.fstype has the string FAT12/FAT16/FAT32 Uhm for this change I did

Re: [PATCH] try to avoid false positives on FAT filesystem

On Sun, Feb 08, 2009 at 08:18:07PM +0100, Felix Zielcke wrote: Am Sonntag, den 08.02.2009, 19:02 +0100 schrieb Robert Millan: This looks different than what you described: Here's a little patch to check if bpb.version_specific.fat12_or_fat16.fstype or

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Sonntag, den 08.02.2009, 20:56 +0100 schrieb Robert Millan: I reviewed this thread and couldn't find it. Did you send it elsewhere? In my first message where you quoted the changelog entry. Well again attached. -- Felix Zielcke 2009-02-05 Felix Zielcke fziel...@z-51.de fs/fat.c

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Freitag, den 06.02.2009, 16:46 +0100 schrieb Felix Zielcke: But yes the best would be to probe for FAT at last but I don't know how to change the order, in fs.lst FAT is listed after ext2 but it seems that FAT is checked before ext2. Ok for grub-probe and probable grub-emu it seems to

Re: [PATCH] try to avoid false positives on FAT filesystem

On Thu, Feb 05, 2009 at 09:39:20PM +0100, Felix Zielcke wrote: Here's a little patch to check if bpb.version_specific.fat12_or_fat16.fstype or bpb.version_specific.fat32.fstype has the string FAT12/FAT16/FAT32 As can be seen on [0] and [1] Dell PCs have a small FAT partition containing some

Re: [PATCH] try to avoid false positives on FAT filesystem

If I understood you correctly you propose to use partition table information to determine filesystem. I'm personally against it. First of all it isn't portable - it probably wouldn't work on GPT. Second if you just do mkfs.* device the partition type isn't changed. Linux ignores partition type

Re: [PATCH] try to avoid false positives on FAT filesystem

Am Freitag, den 06.02.2009, 07:07 +0100 schrieb phcoder: If I understood you correctly you propose to use partition table information to determine filesystem. I'm personally against it. First of all it isn't portable - it probably wouldn't work on GPT. Second if you just do mkfs.* device

Re: [PATCH] try to avoid false positives on FAT filesystem

Currently GRUB tries first the filesystem which was loaded at last. If you do rmmod ext2 insmod ext2 then ext2 will be probed first. If we want reliable ordering we need priority field. Thanks Vladimir 'phcoder' Serbinenko Felix Zielcke wrote: Am Freitag, den 06.02.2009, 07:07 +0100 schrieb

[PATCH] try to avoid false positives on FAT filesystem

Here's a little patch to check if bpb.version_specific.fat12_or_fat16.fstype or bpb.version_specific.fat32.fstype has the string FAT12/FAT16/FAT32 As can be seen on [0] and [1] Dell PCs have a small FAT partition containing some utilities. It seems like mkfs.ext2 isn't always clearing the first