Re: [PATCH 1/2] Cryptomount support LUKS detached header

2020-03-01 Thread Patrick Steinhardt
On Fri, Feb 21, 2020 at 10:03:48PM +0100, Denis 'GNUtoo' Carikli wrote: > From: John Lane > > Signed-off-by: John Lane > gnu...@cyberdimension.org: rebase > Signed-off-by: Denis 'GNUtoo' Carikli We usually prefix commit subjects by the respective subsystem they're touching. For example somethi

Re: [PATCH 1/2] Cryptomount support LUKS detached header

2020-02-25 Thread Patrick Steinhardt
On Mon, Feb 24, 2020 at 12:12:37PM +0100, Daniel Kiper wrote: > Adding Patrick... > > On Fri, Feb 21, 2020 at 10:03:48PM +0100, Denis 'GNUtoo' Carikli wrote: > > From: John Lane > > Both patches require explanation what they do and more importantly why > they are needed... And it would be nice t

Re: [PATCH 1/2] Cryptomount support LUKS detached header

2020-02-24 Thread Daniel Kiper
Adding Patrick... On Fri, Feb 21, 2020 at 10:03:48PM +0100, Denis 'GNUtoo' Carikli wrote: > From: John Lane Both patches require explanation what they do and more importantly why they are needed... And it would be nice to have cover letter. ...and please CC Patrick next time... Daniel > Signe

[PATCH 1/2] Cryptomount support LUKS detached header

2020-02-21 Thread Denis 'GNUtoo' Carikli
From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase Signed-off-by: Denis 'GNUtoo' Carikli --- grub-core/disk/cryptodisk.c | 22 ++ grub-core/disk/geli.c | 7 -- grub-core/disk/luks.c | 45 ++--- include/gru