Re: [PATCH 1/3] Added net_bootp6 command

2015-05-30 Thread Andrei Borzenkov
В Tue, 19 May 2015 16:42:00 +0800 Michael Chang mch...@suse.com пишет: +#define GRUB_DHCPv6_OPTION_CLIENTID 1 +#define GRUB_DHCPv6_OPTION_SERVERID 2 +#define GRUB_DHCPv6_OPTION_IA_NA 3 +#define GRUB_DHCPv6_OPTION_IAADDR 5 +#define GRUB_DHCPv6_OPTION_ORO 6 +#define

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-19 Thread Michael Chang
Hi Andrey, Please see my inline comments. And if I have left anything un-answered or not clear please let me know. And thanks a lot to your time and effort for doing the review. Thanks, Michael On Fri, May 15, 2015 at 09:26:06AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 16:49:48 +0800

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-15 Thread Andrei Borzenkov
В Tue, 12 May 2015 16:49:48 +0800 Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 895 -

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-15 Thread Michael Chang
On Fri, May 15, 2015 at 09:26:06AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 16:49:48 +0800 Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c

Re: [PATCH 1/3] Added net_bootp6 command

2015-05-15 Thread Andrei Borzenkov
В Fri, 15 May 2015 21:57:28 +0800 Michael Chang mch...@suse.com пишет: On Fri, May 15, 2015 at 09:26:06AM +0300, Andrei Borzenkov wrote: В Tue, 12 May 2015 16:49:48 +0800 Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the

[PATCH 1/3] Added net_bootp6 command

2015-05-12 Thread Michael Chang
The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 895 - grub-core/net/ip.c| 35 ++ include/grub/net.h| 19 + 3 files changed, 948

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-19 Thread Andrei Borzenkov
В Fri, 17 Apr 2015 13:04:27 +0800 Michael Chang mch...@suse.com пишет: +static const struct grub_dhcpv6_option* +find_dhcpv6_option (const struct grub_net_dhcpv6_packet *packet, + grub_uint16_t option) +{ + grub_uint16_t code, len; + const struct

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-19 Thread Michael Chang
On Sun, Apr 19, 2015 at 11:15:21AM +0300, Andrei Borzenkov wrote: В Fri, 17 Apr 2015 13:04:27 +0800 Michael Chang mch...@suse.com пишет: +static const struct grub_dhcpv6_option* +find_dhcpv6_option (const struct grub_net_dhcpv6_packet *packet, + grub_uint16_t

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-19 Thread Andrei Borzenkov
В Mon, 20 Apr 2015 11:09:10 +0800 Michael Chang mch...@suse.com пишет: + + ip_start = ip_end = NULL; + ip_start = bootfile_url + grub_strlen(pr); + + if (*ip_start != '[') +ip_start = NULL; + else +ip_end = grub_strchr (++ip_start, ']');

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-16 Thread Andrei Borzenkov
В Wed, 15 Apr 2015 17:05:07 +0800 Michael Chang mch...@suse.com пишет: The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 885 +++-

Re: [PATCH 1/3] Added net_bootp6 command

2015-04-16 Thread Michael Chang
Hi Andrei, Please see my comments and please let me know any problems remains. I'll submit next version soon. Thanks a lot for your detailed review. Regards, Michael On Thu, Apr 16, 2015 at 05:40:56PM +0300, Andrei Borzenkov wrote: В Wed, 15 Apr 2015 17:05:07 +0800 Michael Chang

[PATCH 1/3] Added net_bootp6 command

2015-04-15 Thread Michael Chang
The net_bootp6 is used to configure the ipv6 network interface through the DHCPv6 protocol Solict/Advertise/Request/Reply. --- grub-core/net/bootp.c | 885 +++- grub-core/net/ip.c | 35 ++ include/grub/efi/api.h | 56 +++- include/grub/net.h